Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Quota APIs to Capacity RP. #6906

Merged
merged 193 commits into from
Jan 23, 2020
Merged

Adding Quota APIs to Capacity RP. #6906

merged 193 commits into from
Jan 23, 2020

Conversation

rahuls-microsoft
Copy link
Member

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 8, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Aug 8, 2019

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpf2ezs088/rest/specification/reservations/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpgj9ndow0']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

@azuresdkci azuresdkci requested a review from jhendrixMSFT August 8, 2019 20:36
@jhendrixMSFT jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 8, 2019
rahuls-microsoft and others added 3 commits August 8, 2019 13:56
…019-07-19-preview/quota.json

Co-Authored-By: Nick Schonning <[email protected]>
…019-07-19-preview/quota.json

Co-Authored-By: Nick Schonning <[email protected]>
…019-07-19-preview/quota.json

Co-Authored-By: Nick Schonning <[email protected]>
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 12, 2019

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Output shows no Issues-
D:\src\azureAPI\azure-rest-api-specs>prettier -c specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/*.json
Checking formatting...
All matched files use Prettier code style!
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rahuls-microsoft
Copy link
Member Author

Hi, I am constantly getting PrettierCheck failure from Azure API build.

When I run it locally it passes-
D:\src\azureAPI\azure-rest-api-specs>prettier -c specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/*.json
Checking formatting...
All matched files use Prettier code style!

Fails on Azure build-
https://dev.azure.com/azure-sdk/public/_build/results?buildId=240008&view=logs&j=b56e9678-4dad-5642-289c-5530cc4dad11&t=9e18c5d1-dc43-58a1-0344-6ef37d05bd7f
Checking formatting...
specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/quota.json
Code style issues found in the above file(s). Forgot to run Prettier?

Any idea - How to fix it?
I ran Prettier.

Thanks.
Rahul.

@PhoenixHe-NV
Copy link
Contributor

@rahuls-microsoft Please merge from latest master and try again

@rahuls-microsoft
Copy link
Member Author

rahuls-microsoft commented Jan 22, 2020

@rahuls-microsoft Please merge from latest master and try again

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs cf3b90a
@rahuls-microsoft
Merge branch 'master' into rahuls-quota-spec

Still same error.
What else is required?
Thanks.
Rahul.

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 6906 in repo Azure/azure-rest-api-specs

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rahuls-microsoft
Copy link
Member Author

Can we merge the API? We are stating preview at 1/31/20.
Thanks.

@jhendrixMSFT
Copy link
Member

The CI needs to pass before this can be merged.

@jhendrixMSFT
Copy link
Member

/azp run automation

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@rahuls-microsoft
Copy link
Member Author

No pipelines are associated with this pull request.

What's required from my side?
How do I trigger - /azp run automation

@jhendrixMSFT
Copy link
Member

I don't know why it says "no pipeline are associated", hopefully @NullMDR can help with that.

@PhoenixHe-NV
Copy link
Contributor

/azp run automation - sdk

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoenixHe-NV
Copy link
Contributor

@jhendrixMSFT That's kind of known bug I'll fix later. Currently you can use "/azp run automation - sdk" to workaround this issue

@jhendrixMSFT jhendrixMSFT merged commit 9b6d3ad into Azure:master Jan 23, 2020
@zikalino
Copy link

/azp run automation - sdk

ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
* Adding swagger Spec for Quota RP API.

* Adding Quota RP swagger API.

* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json

Co-Authored-By: Nick Schonning <[email protected]>

* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json

Co-Authored-By: Nick Schonning <[email protected]>

* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json

Co-Authored-By: Nick Schonning <[email protected]>

* Updated based on the comments.

* Updating based on the comments from jhendrixMSFT

* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json

Co-Authored-By: Nick Schonning <[email protected]>

* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json

Co-Authored-By: Nick Schonning <[email protected]>

* Updating quota request status parameter.

* Making all response for all quotaRequests status response same, for one or collection.

* Adding Filter for quotaRequest by requestSubmitTime.

* Fixing casing of the operationId - QuotaRequest_Status

* Removing unused model and adding initial version of readme.md

* Adding Readme.md File.

* Updated path for quota.json.

* Chaning filename Quota.json to quota.json in readme.ms. Looks like it's
case-sensitive.

* Fixing json.

* Updating based on build errors.

* Updating suppression directive for opeartions.

* Fixing Suppression Directive.

* Fixing List operationId name.

* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json

Co-Authored-By: Nick Schonning <[email protected]>

* 1. Updated the _list_ as suggested in the build.
2. Removed the 4XX responses.

* Adding example file.

* 1.Adding providerId in the parameter List.

* 1. Changed the namesace to Microsoft.Capacity. Work with Capacity RP Team (Reservation) to share the namespace.
2. Updated the API to Get and Put pair. Use the same model for Get and Put as suggested.

Todo:
1. Once Apis are finalized add samples for each api.

* 1. Fixing spelling.
2. Updateing the Put datamodel to match Get data model.

* rename QuotaRequests_list_Status - QuotaRequests_listStatus.
There was a warning for QuotaRequests_list_Status.

* 1. Updated API.
2. Added example for Put /serviceLimits.
3. Updated Get example - /serviceLimits.

* 1. Adding examples for /quotaRequests/{id}
2. Adding examples for /quotaRequests

* 1. Formatting changes.
2. Fixing example.

* 1. Removing nextLink from get /serviceLimits, as the RPs doesn't support nextLink for /usages.

* 1. Moving the examples, next to the operationId.
2. Making the arrary "value" instead of quotaRequests.

* 1. Changing quotaRequests to value.

* Fixing example filed name to match the model.

* 1. Fixing example for Put request.
2. Supressing warning PageableOperation or Get /serviceLimits, as all the RPs /usages api doesn't support pagable operation.

* Fixing readme.md

* 1. Removing pageableOperation Suppression.
2. Removing readonly roperties from put parameters.

* 1. Changing quotaRequests to value to address - warning PutRequestResponseScheme.
2. Suppressing RequiredPropertiesMissingInResourceModel. The quotaRequest doesn't have the parameters specified.

* 1. Making Put request and response same to address PutRequestResponseScheme

* 1. Changing requestId to id to address BodyTopLevelProperties

* Adding example for BatchAI /serviceLimits

* 1. Adding the swagger definition files for Quota.
2. Updating Readme.md to include Quota.json
3. Updating the title to "Microsoft.Capacity", it's required to be same in all the files.

* Updating readme.md to resolve conflicy with master.

* Removing the conflict.

* Removing space, which was causing merge conflict.

* Removing files from Quota path.
The Quota APIs will be hosted with Microsoft.Capacity RP.

* 1. Addressing SDK warning for - XmsResourceInPutResponse.

* Updating QuotaRequestResponse Model.

* Updating examples, based on the model change.

* Model change.

* Model Update.

* Adding description.

* Updated example

* 1. Validating new APIs.
2. Will add examples in next iteration.

* 1. Updating AI and adding examples.

* 1. Changing Operation_id

* 1. Added examples.
2. Added properties object to hold additional properties from different resource providers.

* Adding examples for QuotaRequests.

* Adding missing example file.
adding x-ms-azure-resource : true

* Setting - x-ms-azure-resource : true

* Adding example for MsSql get usages.
Fixing few warnings.

* Setting "x-ms-pageable": {
          "nextLinkName": "nextLink"
        }

for the APIs, which are not pageable, returns only one object.

* Removing extra ,

* Updating name to resourceLimits

* Adding example of quotaRequest in progress and quotaRequest Failed.

* Changing name back to serviceLimits.

* Removing "x-ms-client-flatten": true, from the propties,
which may hold specific properties for the RP.

* 1. Fixing errors - Reming Nulls for next page link.
2. The get request for 1 item doesn't need to be pageable.

* 1.Updating the name for ResourceType

* 1. Adding Auto Quota Request API.

* 1. Updated AQI Api.

* Fixing recipients spelling.
Removing x-ms-azure-resource

* 1. Adding examples for Auto Quota Increase.

* 1. Adding example for turning off th Auto Quota Invrease.
2. Fixing examples.

* Updating the model.

* Fixing reference.

* Fixing spelling of Sev

* Adding "x-ms-azure-resource": true,

* Adding name, type parameters.

* Fixing top level elements.

* Updating descriptions and summary text.

* Updating Id with full resource path.

* Speeling fix for specified

* Removing '' from the json.

* ,

* 1. Updating operations ID as suggested.
2. Updated summary to clarify one resource vs multiple reources.
3. Updated autoQuota Increase data model and examples.

* Updated examples.

* Fixinf spelling.

* 1. Changing the enums to OnSuccess, OnFailure.

* 1. Changing the serviceLimits/requests to /quotaRequests.
The requests cannot be child resource of /serviceLimits.

* 1. Updating the quotaRequests to serviceRequests.
2. Updating the examples.

* Changing the serviceRequest to serviceLimitsRequests, as suggested.

* Changing emailActions to emailAction.

* 1. Adding eTag header.
2. Adding oData $metadata.

* 1. Making etag required parameter for put.
2. Updating metadata example.

* Updating the name to - "name": "Automatic Quota Increase",

* Adding $skipToken parameter.

* Adding If-Match to the put and patch examples for quota.

* 1. Updating the Examles based on the model.

* Updating examples based on model.

* Fixing examples' model for autoQuotaIncrease.

* Fixing examples Model errors.

* Fixing recipients.

* Changing the AutoQuotaIncrease Put data model.

* Fixing json.

* Fixing example.

* Removing $metadata api.

* 1. Adding subRequestId for subrequests.
2. Updating examples with subRequestId.

* 1. Updating long running task response based on comments.
2. Updating Auto Quota Increase request.
Auto Quota increase is a functionality/service, where a customer can opt in for - service monitoring the usages and quota value and automatically increase the quota, when a threshold is reached.

* Fixing builderror camel case.
Fixing example.

* Changing "operationId": "AutoQuotaIncrease_Create"

* Changing the field names to lower case.

* Changing case.

* Changing Case.

* Updating Auto Quota Increase schema.

* Fixing AQI examples.

* Removing readonly properties from Set requests.

* Removing unused model.

* changing to lowercase

* Fixing schema.

* Fixing nested refs.

* Changing type to object.

* example fix.

* Updated the Put schema and examle, as per discussion.

* Updated Examples and formatting.

* Fixing errors/warnings.

* Put Response fix.

* Model Fix.

* Model Fixes.

* removing "x-ms-azure-resource": true from request.

* Updating response schema for Put.

* Put examples fixing.

* Adding type= object for top level models.

* Example fix.

* Quota request response updates.

* Example Fix.

* Model fix.

* Changing model.

* Example Fix.

* One SKU Put quota request update.

* Fixing Put requests.

* Example updates.

* Making currentValue readonly.

* Remove currentValue from quota update response.

* Model Fix for put.

* Fixing Patch example.

* Making proerties read-only.

* Removing readonly properties from resource name and unit

* removing ready-only from unit.

* 1. Removing collection Put and Patch.
2. Adding patch for single resource.

* 1. Making Put request and response body same.
2. Making provisioningState as readonly property.
3. Updated Examples accordingly.

* Updating Patch operation name to _Update.

* Model Update.

* Fixing examples.

* Fixing examples.

* 1. Fixing Examples.

* Updating operation id as suggested.

* Updated Operation Id: "operationId": "Quotas_GetStatus",

* Fixing issue - The PUT/GET/PATCH operations must have same schema response.

* 1. Adding id, name, type properties in reponse example.
2. Making ResourceType property setable for Put,Patch request.

* Updating the samples

* Updating the samples

* Revert commit.

* Formatting the json.
Example spelling correction.

* 1. Chaging resource name from Providers to resourceProviders, as suggested by ARM team.
2. Updating examples.

* Fixing jSon.

* Adding patch API.

* Adding resource name to the example.

* Updating patch example.

* Updating Patch example.

* Patch example fix.

* Remove unit from request example.

* Removing readonly property Unit from request.

* Updating request format.

* Changing the title to match the reservation - Azure Reservation API

* Changing the tile back to - Microsoft.Capacity

* Removing Readonly roperty from the quota request.

* Including stable version of Reservation API for tag-
 tag: package-preview-2019-07-19.

* Matching the title with the released version of reservation Api.

* Including the reservation latest swagger file.
Matching the Title to Microsoft.Capacity.

* Reverting the title back to Azure Reservation API

* Running json formatter.

* Formatting json from vscode.

The prettier didn't work! Used vscode to format the json.

Error:
D:\src\azureAPI\azure-rest-api-specs>npm run prettier -- --write "specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/**/*.json"
npm ERR! missing script: prettier

* Running json Prettier.

* Running formatting from visul studio.

* Running prettier check.
Output shows no Issues-
D:\src\azureAPI\azure-rest-api-specs>prettier -c specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/*.json
Checking formatting...
All matched files use Prettier code style!

* Running Prettier.

Co-authored-by: Nick Schonning <[email protected]>
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
* Adding swagger Spec for Quota RP API.

* Adding Quota RP swagger API.

* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json

Co-Authored-By: Nick Schonning <[email protected]>

* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json

Co-Authored-By: Nick Schonning <[email protected]>

* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json

Co-Authored-By: Nick Schonning <[email protected]>

* Updated based on the comments.

* Updating based on the comments from jhendrixMSFT

* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json

Co-Authored-By: Nick Schonning <[email protected]>

* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json

Co-Authored-By: Nick Schonning <[email protected]>

* Updating quota request status parameter.

* Making all response for all quotaRequests status response same, for one or collection.

* Adding Filter for quotaRequest by requestSubmitTime.

* Fixing casing of the operationId - QuotaRequest_Status

* Removing unused model and adding initial version of readme.md

* Adding Readme.md File.

* Updated path for quota.json.

* Chaning filename Quota.json to quota.json in readme.ms. Looks like it's
case-sensitive.

* Fixing json.

* Updating based on build errors.

* Updating suppression directive for opeartions.

* Fixing Suppression Directive.

* Fixing List operationId name.

* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json

Co-Authored-By: Nick Schonning <[email protected]>

* 1. Updated the _list_ as suggested in the build.
2. Removed the 4XX responses.

* Adding example file.

* 1.Adding providerId in the parameter List.

* 1. Changed the namesace to Microsoft.Capacity. Work with Capacity RP Team (Reservation) to share the namespace.
2. Updated the API to Get and Put pair. Use the same model for Get and Put as suggested.

Todo:
1. Once Apis are finalized add samples for each api.

* 1. Fixing spelling.
2. Updateing the Put datamodel to match Get data model.

* rename QuotaRequests_list_Status - QuotaRequests_listStatus.
There was a warning for QuotaRequests_list_Status.

* 1. Updated API.
2. Added example for Put /serviceLimits.
3. Updated Get example - /serviceLimits.

* 1. Adding examples for /quotaRequests/{id}
2. Adding examples for /quotaRequests

* 1. Formatting changes.
2. Fixing example.

* 1. Removing nextLink from get /serviceLimits, as the RPs doesn't support nextLink for /usages.

* 1. Moving the examples, next to the operationId.
2. Making the arrary "value" instead of quotaRequests.

* 1. Changing quotaRequests to value.

* Fixing example filed name to match the model.

* 1. Fixing example for Put request.
2. Supressing warning PageableOperation or Get /serviceLimits, as all the RPs /usages api doesn't support pagable operation.

* Fixing readme.md

* 1. Removing pageableOperation Suppression.
2. Removing readonly roperties from put parameters.

* 1. Changing quotaRequests to value to address - warning PutRequestResponseScheme.
2. Suppressing RequiredPropertiesMissingInResourceModel. The quotaRequest doesn't have the parameters specified.

* 1. Making Put request and response same to address PutRequestResponseScheme

* 1. Changing requestId to id to address BodyTopLevelProperties

* Adding example for BatchAI /serviceLimits

* 1. Adding the swagger definition files for Quota.
2. Updating Readme.md to include Quota.json
3. Updating the title to "Microsoft.Capacity", it's required to be same in all the files.

* Updating readme.md to resolve conflicy with master.

* Removing the conflict.

* Removing space, which was causing merge conflict.

* Removing files from Quota path.
The Quota APIs will be hosted with Microsoft.Capacity RP.

* 1. Addressing SDK warning for - XmsResourceInPutResponse.

* Updating QuotaRequestResponse Model.

* Updating examples, based on the model change.

* Model change.

* Model Update.

* Adding description.

* Updated example

* 1. Validating new APIs.
2. Will add examples in next iteration.

* 1. Updating AI and adding examples.

* 1. Changing Operation_id

* 1. Added examples.
2. Added properties object to hold additional properties from different resource providers.

* Adding examples for QuotaRequests.

* Adding missing example file.
adding x-ms-azure-resource : true

* Setting - x-ms-azure-resource : true

* Adding example for MsSql get usages.
Fixing few warnings.

* Setting "x-ms-pageable": {
          "nextLinkName": "nextLink"
        }

for the APIs, which are not pageable, returns only one object.

* Removing extra ,

* Updating name to resourceLimits

* Adding example of quotaRequest in progress and quotaRequest Failed.

* Changing name back to serviceLimits.

* Removing "x-ms-client-flatten": true, from the propties,
which may hold specific properties for the RP.

* 1. Fixing errors - Reming Nulls for next page link.
2. The get request for 1 item doesn't need to be pageable.

* 1.Updating the name for ResourceType

* 1. Adding Auto Quota Request API.

* 1. Updated AQI Api.

* Fixing recipients spelling.
Removing x-ms-azure-resource

* 1. Adding examples for Auto Quota Increase.

* 1. Adding example for turning off th Auto Quota Invrease.
2. Fixing examples.

* Updating the model.

* Fixing reference.

* Fixing spelling of Sev

* Adding "x-ms-azure-resource": true,

* Adding name, type parameters.

* Fixing top level elements.

* Updating descriptions and summary text.

* Updating Id with full resource path.

* Speeling fix for specified

* Removing '' from the json.

* ,

* 1. Updating operations ID as suggested.
2. Updated summary to clarify one resource vs multiple reources.
3. Updated autoQuota Increase data model and examples.

* Updated examples.

* Fixinf spelling.

* 1. Changing the enums to OnSuccess, OnFailure.

* 1. Changing the serviceLimits/requests to /quotaRequests.
The requests cannot be child resource of /serviceLimits.

* 1. Updating the quotaRequests to serviceRequests.
2. Updating the examples.

* Changing the serviceRequest to serviceLimitsRequests, as suggested.

* Changing emailActions to emailAction.

* 1. Adding eTag header.
2. Adding oData $metadata.

* 1. Making etag required parameter for put.
2. Updating metadata example.

* Updating the name to - "name": "Automatic Quota Increase",

* Adding $skipToken parameter.

* Adding If-Match to the put and patch examples for quota.

* 1. Updating the Examles based on the model.

* Updating examples based on model.

* Fixing examples' model for autoQuotaIncrease.

* Fixing examples Model errors.

* Fixing recipients.

* Changing the AutoQuotaIncrease Put data model.

* Fixing json.

* Fixing example.

* Removing $metadata api.

* 1. Adding subRequestId for subrequests.
2. Updating examples with subRequestId.

* 1. Updating long running task response based on comments.
2. Updating Auto Quota Increase request.
Auto Quota increase is a functionality/service, where a customer can opt in for - service monitoring the usages and quota value and automatically increase the quota, when a threshold is reached.

* Fixing builderror camel case.
Fixing example.

* Changing "operationId": "AutoQuotaIncrease_Create"

* Changing the field names to lower case.

* Changing case.

* Changing Case.

* Updating Auto Quota Increase schema.

* Fixing AQI examples.

* Removing readonly properties from Set requests.

* Removing unused model.

* changing to lowercase

* Fixing schema.

* Fixing nested refs.

* Changing type to object.

* example fix.

* Updated the Put schema and examle, as per discussion.

* Updated Examples and formatting.

* Fixing errors/warnings.

* Put Response fix.

* Model Fix.

* Model Fixes.

* removing "x-ms-azure-resource": true from request.

* Updating response schema for Put.

* Put examples fixing.

* Adding type= object for top level models.

* Example fix.

* Quota request response updates.

* Example Fix.

* Model fix.

* Changing model.

* Example Fix.

* One SKU Put quota request update.

* Fixing Put requests.

* Example updates.

* Making currentValue readonly.

* Remove currentValue from quota update response.

* Model Fix for put.

* Fixing Patch example.

* Making proerties read-only.

* Removing readonly properties from resource name and unit

* removing ready-only from unit.

* 1. Removing collection Put and Patch.
2. Adding patch for single resource.

* 1. Making Put request and response body same.
2. Making provisioningState as readonly property.
3. Updated Examples accordingly.

* Updating Patch operation name to _Update.

* Model Update.

* Fixing examples.

* Fixing examples.

* 1. Fixing Examples.

* Updating operation id as suggested.

* Updated Operation Id: "operationId": "Quotas_GetStatus",

* Fixing issue - The PUT/GET/PATCH operations must have same schema response.

* 1. Adding id, name, type properties in reponse example.
2. Making ResourceType property setable for Put,Patch request.

* Updating the samples

* Updating the samples

* Revert commit.

* Formatting the json.
Example spelling correction.

* 1. Chaging resource name from Providers to resourceProviders, as suggested by ARM team.
2. Updating examples.

* Fixing jSon.

* Adding patch API.

* Adding resource name to the example.

* Updating patch example.

* Updating Patch example.

* Patch example fix.

* Remove unit from request example.

* Removing readonly property Unit from request.

* Updating request format.

* Changing the title to match the reservation - Azure Reservation API

* Changing the tile back to - Microsoft.Capacity

* Removing Readonly roperty from the quota request.

* Including stable version of Reservation API for tag-
 tag: package-preview-2019-07-19.

* Matching the title with the released version of reservation Api.

* Including the reservation latest swagger file.
Matching the Title to Microsoft.Capacity.

* Reverting the title back to Azure Reservation API

* Running json formatter.

* Formatting json from vscode.

The prettier didn't work! Used vscode to format the json.

Error:
D:\src\azureAPI\azure-rest-api-specs>npm run prettier -- --write "specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/**/*.json"
npm ERR! missing script: prettier

* Running json Prettier.

* Running formatting from visul studio.

* Running prettier check.
Output shows no Issues-
D:\src\azureAPI\azure-rest-api-specs>prettier -c specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/*.json
Checking formatting...
All matched files use Prettier code style!

* Running Prettier.

Co-authored-by: Nick Schonning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review DoNotMerge <valid label in PR review process> use to hold merge after approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.