Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Health Probe Method, Health Probe Enabled, SendRecvTimeoutseconds, and MinimumTLSVersion #6895

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

atshaw42
Copy link
Contributor

@atshaw42 atshaw42 commented Aug 7, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 7, 2019

In Testing, Please Ignore

[Logs] (Generated from 5804933, Iteration 5)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Warning preview/frontdoor/mgmt/2018-08-01-preview [Logs]
  • Warning preview/frontdoor/mgmt/2019-04-01 [Logs]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Warning @azure/arm-frontdoor [Logs]

@AutorestCI
Copy link

AutorestCI commented Aug 7, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Aug 7, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@ruowan
Copy link
Member

ruowan commented Aug 8, 2019

It seems that you didn't add tag: package-2019-09-05 in the readme.md. This PR is a little different from your private PR. Pls, double-check.

@ravbhatnagar ravbhatnagar added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 8, 2019
@ravbhatnagar
Copy link
Contributor

This was approved in the private repo. https://github.com/Azure/azure-rest-api-specs-pr/pull/827/

@yungezz
Copy link
Member

yungezz commented Aug 8, 2019

It seems that you didn't add tag: package-2019-09-05 in the readme.md. This PR is a little different from your private PR. Pls, double-check.

hi @atshaw42 could you pls make change based on @ruowan 's comments? then we'll review again and merge if no other issue.

@yungezz yungezz merged commit af9780e into Azure:master Aug 8, 2019
@yungezz
Copy link
Member

yungezz commented Aug 8, 2019

@atshaw42 I've merged the PR, pls create another PR to include the new 2019-05 tag in readme file if you want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants