Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add short url for all api resources #6884

Merged
merged 15 commits into from Sep 11, 2019
Merged

Add short url for all api resources #6884

merged 15 commits into from Sep 11, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 6, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Aug 6, 2019

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#7184

@AutorestCI
Copy link

AutorestCI commented Aug 6, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5740

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yungezz yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 7, 2019
@ryansbenson ryansbenson added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 15, 2019
@sanjaiganesh sanjaiganesh removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 22, 2019
@sanjaiganesh sanjaiganesh added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 22, 2019
@ghost
Copy link
Author

ghost commented Aug 22, 2019

Please hold merge

@yungezz yungezz added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 22, 2019
@yungezz
Copy link
Member

yungezz commented Aug 28, 2019

Hi @bizarreWizard what's the plan to proceed this PR? is it ok to close it for now and reopen you're ready for merge?

@ghost
Copy link
Author

ghost commented Aug 29, 2019

Hi @bizarreWizard what's the plan to proceed this PR? is it ok to close it for now and reopen you're ready for merge?

The PR should be able to merge on the beginning of Sep. We are waiting for prod deployment.

@ghost
Copy link
Author

ghost commented Sep 10, 2019

Please merge the PR, thanks!

@yungezz yungezz merged commit ea148fd into Azure:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review DoNotMerge <valid label in PR review process> use to hold merge after approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants