Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orphan property removed #6844

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Orphan property removed #6844

merged 1 commit into from
Sep 11, 2019

Conversation

VitaliyKurokhtin
Copy link
Contributor

@VitaliyKurokhtin VitaliyKurokhtin commented Aug 1, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 1, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 94dbf0a, Iteration 3)

Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Warning @azure/arm-apimanagement [Logs]
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@azuresdkci azuresdkci requested a review from anuchandy August 1, 2019 21:59
@VitaliyKurokhtin
Copy link
Contributor Author

This is not an API change of any sort, merely correcting documentation to match real world since removed property was exposed by mistake and does not affect anything.

@AutorestCI AutorestCI mentioned this pull request Aug 1, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 1, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7206

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Aug 1, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 1, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5753

@anuchandy
Copy link
Member

seems javascript job is failing, restarted the job.

@anuchandy anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 6, 2019
@anuchandy
Copy link
Member

Requested ARM Review since the pr removes property from stable api-version.

@ravbhatnagar
Copy link
Contributor

ravbhatnagar commented Aug 7, 2019 •
edited
Loading

@VitaliyKurokhtin This is a breaking change in a stable API-version. Why do you want to remove this property?

@ravbhatnagar ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 7, 2019
@VitaliyKurokhtin
Copy link
Contributor Author

Because this property was never functional. It does present on one of the internal contracts that we use to pass information from controller to custom formatter, so it never makes it's way to the client. Due to some refactoring it slipped to public documentation, but it does nothing if you send it in PUT/PATCH and we never actually return it in JSON response.

@yungezz
Copy link
Member

yungezz commented Aug 28, 2019

Hi @VitaliyKurokhtin @ravbhatnagar any update on this PR? can it be merged?

@yungezz
Copy link
Member

yungezz commented Sep 2, 2019

@VitaliyKurokhtin are you still on this PR? is it ok to close if you're not working on it anymore?

@VitaliyKurokhtin
Copy link
Contributor Author

There is nothing to do. As I said earlier we're removing orphan non functional property. Still sending this property will not result in an error, and it was never returned. So this is not breaking by any means.

@yungezz
Copy link
Member

yungezz commented Sep 2, 2019

There is nothing to do. As I said earlier we're removing orphan non functional property. Still sending this property will not result in an error, and it was never returned. So this is not breaking by any means.

hi @ravbhatnagar could you pls label ARMSignedOff then I'll merge the PR if above makes sense to you?

KrisBash
KrisBash approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the understanding that this is aligning swagger to server behavior, signing off for ARM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 6, 2019
@yungezz
Copy link
Member

yungezz commented Sep 11, 2019

CI passed in azure pipeline https://github.com/Azure/azure-rest-api-specs/pull/6844/checks?check_run_id=183465797.

@anuchandy anuchandy merged commit 8b3322c into Azure:master Sep 11, 2019
@AutorestCI AutorestCI mentioned this pull request Sep 11, 2019
Merged
leni-msft pushed a commit to leni-msft/azure-rest-api-specs that referenced this pull request May 13, 2022
@devanshjainms
User/devanshjain/discovery ha ers props (Azure#6844)
f547ddb 
* added ers props

* added health status to ers props

* removed status from ers props

* added ersType property

* added instance no to DB Server Props

* changed ersType to ersVersion

* changed ers inactive style

* fixed comments

* added back primary secondary CS types

* removed the database instance no prop

* removed database instance no prop

* added custom word in the txt file
@VitaliyKurokhtin VitaliyKurokhtin deleted the vvk/subscription-key branch September 19, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash approved these changes

@anuchandy anuchandy anuchandy approved these changes

@solankisamir solankisamir Awaiting requested review from solankisamir solankisamir is a code owner

Assignees

@anuchandy anuchandy

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@VitaliyKurokhtin @AutorestCI @azuresdkci @anuchandy @ravbhatnagar @yungezz @KrisBash