Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger: Allowing for VMSS reference during VM creation #6836

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Swagger: Allowing for VMSS reference during VM creation #6836

merged 2 commits into from
Aug 14, 2019

Conversation

shpa-microsoft
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 1, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 2723517, Iteration 2)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress Ruby: test-repo-billy/azure-sdk-for-ruby [Logs]
  • Package generation in progress.

@AutorestCI AutorestCI mentioned this pull request Aug 1, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 1, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6461

@AutorestCI AutorestCI mentioned this pull request Aug 1, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 1, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5524

@azuresdkci azuresdkci requested a review from jhendrixMSFT August 1, 2019 18:28
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

jhendrixMSFT
jhendrixMSFT requested changes Aug 1, 2019
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One spelling mistake to fix. Also can you please ACK that this functionality is live?

@shpa-microsoft shpa-microsoft mentioned this pull request Aug 5, 2019
Closed
@shpa-microsoft
Copy link
Contributor Author

One spelling mistake to fix. Also can you please ACK that this functionality is live?

Fixed the typo. Also it should be made available starting aug 16th.

@jhendrixMSFT jhendrixMSFT added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 7, 2019
@jhendrixMSFT
Copy link
Member

Awesome, please ping back when this is live so this can get merged.

@shpa-microsoft
Copy link
Contributor Author

Hey can you please merge this change in today?

@jhendrixMSFT jhendrixMSFT removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 14, 2019
@jhendrixMSFT jhendrixMSFT merged commit 87061cd into Azure:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@huangpf huangpf Awaiting requested review from huangpf

@hyonholee hyonholee Awaiting requested review from hyonholee

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shpa-microsoft @AutorestCI @azuresdkci @jhendrixMSFT @nschonni