Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing monitoring hana instance API #6778

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

pabowers
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Jul 29, 2019

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#6535

@AutorestCI
Copy link

AutorestCI commented Jul 29, 2019

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#5374

Copy link
Contributor

@AprilZhaoWY AprilZhaoWY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Question: are there CLI commands depending on the spec? If so, would deleting the spec break the CLI?

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@pabowers
Copy link
Contributor Author

@AprilZhaoWY, yes, this call will also need to be removed from the CLI extension. Once the Python SDK is generated here, and the corresponding python PR is merged, then I will update our CLI extension.

@AprilZhaoWY
Copy link
Contributor

@AprilZhaoWY, yes, this call will also need to be removed from the CLI extension. Once the Python SDK is generated here, and the corresponding python PR is merged, then I will update our CLI extension.

I see. I just thought of another scenario: After we delete the monitoring spec and RP code, people who have an older version of our CLI extension will always fail when running the monitoring commands. In that case, are we breaking our SLA on the CLI extension? Or do we state we only support the latest version?@PakDLiu

@pabowers
Copy link
Contributor Author

@AprilZhaoWY true, but the only people that have the monitoring features enabled are on our team anyway

@jhendrixMSFT jhendrixMSFT merged commit 11b1c5f into master Jul 30, 2019
@JackTn JackTn deleted the pabowers/remove-monitor-hana-instance branch August 9, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants