-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing monitoring hana instance API #6778
Conversation
SDK Automation [Logs] (Generated from a6757c4, Iteration 1)
|
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-goA PR has been created for you: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Question: are there CLI commands depending on the spec? If so, would deleting the spec break the CLI?
Can one of the admins verify this patch? |
@AprilZhaoWY, yes, this call will also need to be removed from the CLI extension. Once the Python SDK is generated here, and the corresponding python PR is merged, then I will update our CLI extension. |
I see. I just thought of another scenario: After we delete the monitoring spec and RP code, people who have an older version of our CLI extension will always fail when running the monitoring commands. In that case, are we breaking our SLA on the CLI extension? Or do we state we only support the latest version?@PakDLiu |
@AprilZhaoWY true, but the only people that have the monitoring features enabled are on our team anyway |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.