Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datafactory] Add one new connector and new properties into three connectors #6762

Merged
merged 2 commits into from
Jul 31, 2019
Merged

[Datafactory] Add one new connector and new properties into three connectors #6762

merged 2 commits into from
Jul 31, 2019

Conversation

davidzhaoyue
Copy link
Contributor

New connector: Azure Database for MariaDB
New properties in:

  1. Office365Source
  2. RestSource
  3. SapOpenHubSource

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 29, 2019

SDK Automation [Logs] (Generated from 1399f09, Iteration 2)

Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Failed Java: Azure/azure-sdk-for-java [Logs] [Diff]
  • Warning datafactory/resource-manager/v2017_09_01_preview [Logs]
  • Failed datafactory/resource-manager/v2018_06_01 [Logs]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Jul 29, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5747

@AutorestCI
Copy link

AutorestCI commented Jul 29, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5388

@raych1 raych1 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 29, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Member

@raych1 raych1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with @davidzhaoyue , the new model added by this PR which is not first layer model but internal model. And there's no breaking change.

@raych1 raych1 removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 31, 2019
@raych1 raych1 merged commit a3e92fe into Azure:master Jul 31, 2019
leni-msft pushed a commit to leni-msft/azure-rest-api-specs that referenced this pull request May 13, 2022
…on. (Azure#6762)

* Updated common api types to v3 and added crlProperties to CA definition.

* Executed prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants