Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compute] Add missing Gallery Application API in 2019-07-01 version #6745

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

hyonholee
Copy link
Contributor

@hyonholee hyonholee commented Jul 27, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@hyonholee hyonholee requested a review from huangpf as a code owner July 27, 2019 01:18
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 27, 2019

In Testing, Please Ignore

[Logs] (Generated from 6637309, Iteration 8)

Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Failed Java: Azure/azure-sdk-for-java [Logs] [Diff]
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@hyonholee hyonholee changed the title Add missing Gallery Application API in 2019-07-01 version [Compute] Add missing Gallery Application API in 2019-07-01 version Jul 27, 2019
@AutorestCI
Copy link

AutorestCI commented Jul 27, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6461

@AutorestCI
Copy link

AutorestCI commented Jul 27, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5420

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@hyonholee
Copy link
Contributor Author

Gallery API does not have PATCH by design. PUT works as PATCH. So please ignore the following errors.

For the following failures:

R3026 - TrackedResourcePatchOperation

Tracked resource 'GalleryApplication' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.

at specification/compute/resource-manager/Microsoft.Compute/stable/2019-07-01/gallery.json:1346

R3026 - TrackedResourcePatchOperation

Tracked resource 'GalleryApplicationVersion' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.

at specification/compute/resource-manager/Microsoft.Compute/stable/2019-07-01/gallery.json:1401

@anuchandy anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 30, 2019
Copy link
Contributor

@koralski koralski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as 2019-03-01 version
#6411

@sergey-shandar sergey-shandar removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 31, 2019
@sergey-shandar
Copy link
Contributor

@hyonholee could you confirm that this is the same API as in 2019-03-01?

@hyonholee
Copy link
Contributor Author

@sergey-shandar Yes, it is the same as 2019-03-01. Please approve the PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants