Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory] support dataset v2 split name #6738

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

xiaoyingQQ
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 26, 2019

SDK Automation [Logs] (Generated from 04df2c4, Iteration 3)

Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Failed Java: Azure/azure-sdk-for-java [Logs] [Diff]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Jul 26, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5747

@AutorestCI
Copy link

AutorestCI commented Jul 26, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5341

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@daviwil
Copy link
Contributor

daviwil commented Jul 26, 2019

@OpenAPIBot sdkautomation rebuild

@mmyyrroonn
Copy link
Contributor

@erich-wang @NullMDR talked with the author offline, could you please check why .net SDK is not generated?

@xiaoyingQQ xiaoyingQQ changed the title support dataset v2 split name [DataFactory] support dataset v2 split name Jul 29, 2019
@PhoenixHe-NV
Copy link
Contributor

@myronfanqiu @xiaoyingQQ @erich-wang The readme.md for data factory doesn't contain azure-sdk-for-net, the following change is required for enabling net sdk in readme.md:

swagger-to-sdk:
+ - repo: azure-sdk-for-net
  - repo: azure-sdk-for-python
  - repo: azure-sdk-for-java
  - repo: azure-sdk-for-go
  - repo: azure-sdk-for-js
  - repo: azure-sdk-for-node

@xiaoyingQQ
Copy link
Contributor Author

@hvermis , why the "azure-sdk-for-net" is not contained in readme.md?

@mmyyrroonn mmyyrroonn merged commit 74dfcd3 into Azure:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants