Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 #6731

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,6 @@
}
]
},
"202": {
"body": ""
}
"202": {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,6 @@
}
]
},
"202": {
"body": ""
}
"202": {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@
}
}
},
"202": {
"body": ""
}
"202": {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
"reservedResourceType": "VirtualMachines",
"instanceFlexibility": "Off",
"skuDescription": "D1 v2",
"term": "P1Y",
"mergeProperties": {
"mergeSources": [
"/providers/microsoft.capacity/reservationOrders/276e7ae4-84d0-4da6-ab4b-d6b94f3557da/reservations/00238563-7312-4c20-a134-8c030bf938a7",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,6 @@
}
]
},
"202": {
"body": ""
}
"202": {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,6 @@
}
]
},
"202": {
"body": ""
}
"202": {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@
}
}
},
"202": {
"body": ""
}
"202": {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -1012,6 +1012,9 @@
},
"renewProperties": {
"$ref": "#/definitions/RenewPropertiesResponse"
},
"term": {
"$ref": "#/definitions/ReservationTerm"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReservationTerm [](start = 33, length = 15)

You are adding a new property non-readonly property to a stable API version. This is considered a breaking change. You should introduce this change in a new API version.

}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,6 @@
}
]
},
"202": {
"body": ""
}
"202": {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@
}
]
},
"202": {
"body": ""
}
"202": {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@
}
}
},
"202": {
"body": ""
}
"202": {}
}
}