-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deployment APIs at tenant scope #6720
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Can one of the admins verify this patch? |
@OpenAPIBot sdkautomation rebuild |
@OpenAPIBot sdkautomation rebuild |
@Tiano2017 there're errors in CI. pls fix them.
|
@yungezz Looking at my example file: https://github.com/Azure/azure-rest-api-specs/pull/6720/files#diff-30a00039c98a25059cce3712940c7032, I see both parameters are provided. Not sure if there's anything I missed. Can you help me understand the error? |
@Tiano2017 try put |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@yungezz I did pretty much the same as PutRoleDefinition, but it's still failing.. any more suggestions? |
@yungezz I tried a few approaches, but am still getting errors on model validation. Do you have any suggestions on what I need to do to fix them? |
"204": { | ||
"description": "No Content" | ||
}, | ||
"404": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add error code in swagger file, pls add "default" back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to remove error code and add default
@majastrz For export template we can return a response that contains both results and error. For other requests I don't think we do that. |
signing off from ARM side on the changes added after the last sign off! |
@@ -216,6 +216,15 @@ input-file: | |||
- Microsoft.Resources/stable/2019-05-10/resources.json | |||
``` | |||
|
|||
### Tag: package-resources-2019-05 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a typo?
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.