Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment APIs at tenant scope #6720

Merged
merged 13 commits into from
Aug 7, 2019

Conversation

Tiano2017
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@Tiano2017 Tiano2017 requested a review from stankovski as a code owner July 24, 2019 21:42
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2019

In Testing, Please Ignore

[Logs] (Generated from b943cc5, Iteration 15)

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6533

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yungezz yungezz added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required WaitForInternalTeamReview As per the team process, this needs to be reviewed and closed internally in the team and removed WaitForInternalTeamReview As per the team process, this needs to be reviewed and closed internally in the team labels Jul 25, 2019
@ghost
Copy link

ghost commented Jul 25, 2019

@OpenAPIBot sdkautomation rebuild

@PhoenixHe-NV
Copy link
Contributor

@OpenAPIBot sdkautomation rebuild

@yungezz
Copy link
Member

yungezz commented Jul 26, 2019

@Tiano2017 there're errors in CI. pls fix them.

@Tiano2017
Copy link
Contributor Author

@yungezz Looking at my example file: https://github.com/Azure/azure-rest-api-specs/pull/6720/files#diff-30a00039c98a25059cce3712940c7032, I see both parameters are provided. Not sure if there's anything I missed. Can you help me understand the error?

@yungezz
Copy link
Member

yungezz commented Jul 26, 2019

Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 26, 2019
@Tiano2017
Copy link
Contributor Author

@yungezz I did pretty much the same as PutRoleDefinition, but it's still failing.. any more suggestions?

@Tiano2017
Copy link
Contributor Author

@yungezz I tried a few approaches, but am still getting errors on model validation. Do you have any suggestions on what I need to do to fix them?

This was referenced Aug 1, 2019
"204": {
"description": "No Content"
},
"404": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to add error code in swagger file, pls add "default" back.

Copy link
Member

@yungezz yungezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove error code and add default

@majastrz
Copy link
Member

majastrz commented Aug 6, 2019

    },

We never respond with both validation results and error, right? (partial failure)


Refers to: specification/resources/resource-manager/Microsoft.Resources/stable/2019-07-01/resources.json:3788 in a18e248. [](commit_id = a18e248, deletion_comment = True)

@Tiano2017
Copy link
Contributor Author

@majastrz For export template we can return a response that contains both results and error. For other requests I don't think we do that.

@ravbhatnagar
Copy link
Contributor

ravbhatnagar commented Aug 6, 2019

signing off from ARM side on the changes added after the last sign off!

@@ -216,6 +216,15 @@ input-file:
- Microsoft.Resources/stable/2019-05-10/resources.json
```

### Tag: package-resources-2019-05
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a typo?

@yungezz yungezz merged commit f80a6c1 into Azure:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants