Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type name and add timeout property #6717

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

tomersh26
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2019

SDK Automation [Logs] (Generated from 6daaa9b, Iteration 1)

Failed Python: Azure/azure-sdk-for-python [Logs] [Diff]
  • Failed sdk/datafactory/azure-mgmt-datafactory [Logs]
In-Progress Java: Azure/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: Azure/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: Azure/azure-sdk-for-js [Logs]
  • Package generation in progress.

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5747

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5341

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@shahabhijeet shahabhijeet added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 25, 2019
Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change, need ARM signoff

@hvermis
Copy link
Contributor

hvermis commented Jul 25, 2019

This is not breaking change because this type has not been released yet - it closed on the backend, and the type has been added couple days back, and has an issue in the name. This PR is fixing it. The type is pending release based on SDK releases, please help to sign off as soon as you can.

@shahabhijeet shahabhijeet removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 25, 2019
@shahabhijeet shahabhijeet merged commit 548e21c into Azure:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants