Added Sql Stored Procedure for CosmosDB #6659

MehaKaushik · 2019-07-17T23:16:50Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-07-17T23:16:52Z

SDK Automation [Logs] (Generated from 41d23b9, Iteration 5)

Python: Azure/azure-sdk-for-python [Logs] [Diff]

sdk/cosmos/azure-mgmt-cosmosdb [Logs]

Java: Azure/azure-sdk-for-java [Logs] [Diff]

cosmosdb/resource-manager/v2015_04_08 [Logs]

Go: Azure/azure-sdk-for-go [Logs] [Diff]

cosmos-db/mgmt/2015-04-08 [Logs]

JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@azure/arm-cosmosdb [Logs]

AutorestCI · 2019-07-17T23:18:07Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout f75c9001a256d03d0bfb7316fc02076adccc032b
  stderr: 'fatal: reference is not a tree: f75c9001a256d03d0bfb7316fc02076adccc032b'

AutorestCI · 2019-07-17T23:19:55Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout f75c9001a256d03d0bfb7316fc02076adccc032b
  stderr: 'fatal: reference is not a tree: f75c9001a256d03d0bfb7316fc02076adccc032b'

azuresdkci · 2019-07-17T23:25:57Z

Can one of the admins verify this patch?

AutorestCI · 2019-07-18T17:33:22Z

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#3409

sarangan12

Changes look ok. All the Tools are passing, Since there are new APIs defined, I am requesting a ARM review.

anthony-c-martin · 2019-07-22T19:24:55Z

specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2015-04-08/cosmos-db.json

+          }
+        },
+        "x-ms-pageable": {
+          "nextLinkName": null


If you're not supporting paging, do you have any limits on the number of stored procedures that can be created? How big can this response get?

We support paging internally in CosmosDB. Hence, paging is not required here.

anthony-c-martin · 2019-07-22T19:30:31Z

.../Microsoft.DocumentDB/stable/2015-04-08/examples/CosmosDBSqlStoredProcedureCreateUpdate.json

+  "responses": {
+    "200": {
+      "body": {
+        "id": "storedProcedureName",


Please format the "id" correctly

anthony-c-martin · 2019-07-22T19:32:42Z

.../Microsoft.DocumentDB/stable/2015-04-08/examples/CosmosDBSqlStoredProcedureCreateUpdate.json

+    "containerName": "containerName",
+    "storedProcedureName": "storedProcedureName",
+    "createUpdateSqlStoredProcedureParameters": {
+      "properties": {


This doesn't appear to adhere to the expectations around resource CRUD - you're missing "id", "name" and "type" properties, and the shape of the properties on the PUT doesn't match the shape of the properties on the response.

anthony-c-martin · 2019-07-22T19:33:30Z

specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2015-04-08/cosmos-db.json

@@ -4944,6 +5195,20 @@
        "id"
      ]
    },
+    "SqlStoredProcedureResource": {


Calling this a "resource" with an "id" property could make things confusing, as this isn't an Azure resource. Please could you update the naming to avoid confusion?

anthony-c-martin · 2019-07-22T19:36:04Z

specification/cosmos-db/resource-manager/readme.md

@@ -50,6 +50,10 @@ directive:
    from: cosmos-db.json
    where: $.definitions.DatabaseAccountCreateUpdateParameters
    reason: The DatabaseAccount request and response resources differ so the DatabaseAccountCreateUpdateParameters must only have a PUT operation
+  - suppress: TrackedResourcePatchOperation


This seems like a legit problem. Why are you suppressing it?

MehaKaushik · 2019-07-29T20:48:47Z

Because CosmosDB resources are not following the format prescribed by ARM, closing this PR. We are working on fixing all the other resources, the modifications of this work will be included then after.

Meha Kaushik added 4 commits July 17, 2019 13:52

adding stored procedures in cosmos-db.json

7198c7d

fixed a typo

331b75e

example files for stored procedures

a0d488e

changes in readme

42a3078

azuresdkci assigned sarangan12 Jul 17, 2019

AutorestCI mentioned this pull request Jul 17, 2019

[AutoPR cosmos-db/resource-manager] Added Sql Stored Procedure for CosmosDB Azure/azure-sdk-for-python#6392

Closed

azuresdkci requested a review from sarangan12 July 17, 2019 23:18

AutorestCI mentioned this pull request Jul 17, 2019

[AutoPR cosmos-db/resource-manager] Added Sql Stored Procedure for CosmosDB Azure/azure-sdk-for-go#5284

Closed

fixed a typo

82ff450

AutorestCI mentioned this pull request Jul 18, 2019

[AutoPR cosmos-db/resource-manager] Added Sql Stored Procedure for CosmosDB Azure/azure-sdk-for-java#4469

Closed

Meha Kaushik added 3 commits July 18, 2019 11:57

renamed Body to body in example json files

488a195

renamed storedprocedures to storedProcedures in example files

21a3e47

renamed storedprocedures to storedProcedures in cosmos-db.json

41d23b9

sarangan12 approved these changes Jul 19, 2019

View reviewed changes

sarangan12 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 19, 2019

anthony-c-martin requested changes Jul 22, 2019

View reviewed changes

anthony-c-martin added the ARMReviewInProgress label Jul 22, 2019

MehaKaushik closed this Jul 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Sql Stored Procedure for CosmosDB #6659

Added Sql Stored Procedure for CosmosDB #6659

MehaKaushik commented Jul 17, 2019

openapi-sdkautomation bot commented Jul 17, 2019 •

edited

Loading

AutorestCI commented Jul 17, 2019 •

edited

Loading

AutorestCI commented Jul 17, 2019 •

edited

Loading

azuresdkci commented Jul 17, 2019

AutorestCI commented Jul 18, 2019 •

edited

Loading

sarangan12 left a comment

anthony-c-martin Jul 22, 2019

MehaKaushik Jul 23, 2019

anthony-c-martin Jul 22, 2019

anthony-c-martin Jul 22, 2019

anthony-c-martin Jul 22, 2019

anthony-c-martin Jul 22, 2019

MehaKaushik commented Jul 29, 2019 •

edited

Loading

Added Sql Stored Procedure for CosmosDB #6659

Added Sql Stored Procedure for CosmosDB #6659

Conversation

MehaKaushik commented Jul 17, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jul 17, 2019 • edited Loading

SDK Automation [Logs] (Generated from 41d23b9, Iteration 5)

AutorestCI commented Jul 17, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jul 17, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Jul 17, 2019

AutorestCI commented Jul 18, 2019 • edited Loading

Automation for azure-sdk-for-java

sarangan12 left a comment

Choose a reason for hiding this comment

anthony-c-martin Jul 22, 2019

Choose a reason for hiding this comment

MehaKaushik Jul 23, 2019

Choose a reason for hiding this comment

anthony-c-martin Jul 22, 2019

Choose a reason for hiding this comment

anthony-c-martin Jul 22, 2019

Choose a reason for hiding this comment

anthony-c-martin Jul 22, 2019

Choose a reason for hiding this comment

anthony-c-martin Jul 22, 2019

Choose a reason for hiding this comment

MehaKaushik commented Jul 29, 2019 • edited Loading

openapi-sdkautomation bot commented Jul 17, 2019 •

edited

Loading

AutorestCI commented Jul 17, 2019 •

edited

Loading

AutorestCI commented Jul 17, 2019 •

edited

Loading

AutorestCI commented Jul 18, 2019 •

edited

Loading

MehaKaushik commented Jul 29, 2019 •

edited

Loading