-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update attestation swagger #6655
Conversation
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Might be worth fixing #6624 if you're making changes |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-javaEncountered an unknown error: (azure-sdk-for-java)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 172, in rest_handle_action
return rest_pull_sync(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 200, in rest_pull_sync
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
sdk_tag=sdk_tag
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 241, in generate_sdk_from_git_object
raise ValueError("Unable to locate configuration in {}".format(branch_list))
ValueError: Unable to locate configuration in ['restapi_auto_attestation/resource-manager', 'restapi_auto_6655', 'master'] |
…dy appears on the server
@myronfanqiu could you please review this pr? I was waiting for the pull request to close to update the SDK. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to generate net sdk, you should provide the readme.csharp.md file under this folder. Then the CI will try to generate the SDK and check the process.
}, | ||
{ | ||
"name": "providerName", | ||
"in": "path", | ||
"required": true, | ||
"type": "string", | ||
"pattern": "^[a-z0-9]{3,24}$", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this is the real change. Since this is a preview version and this will not bring breaking change. I think it's ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@myronfanqiu The readme.md file is already generated and published in the repo under https://github.com/Azure/azure-rest-api-specs/tree/master/specification/attestation/resource-manager .
This pull request is only a update for the existing attestation.jaon file.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.