Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tenant-level provider list operation to SDK #6645

Merged
merged 4 commits into from
Jul 29, 2019
Merged

Add missing tenant-level provider list operation to SDK #6645

merged 4 commits into from
Jul 29, 2019

Conversation

mentat9
Copy link
Member

@mentat9 mentat9 commented Jul 16, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@mentat9 mentat9 requested a review from stankovski as a code owner July 16, 2019 21:04
@mentat9 mentat9 changed the title Master Add missing tenant-level provider list operation to SDK Jul 16, 2019
@azuresdkci azuresdkci requested a review from mybayern1974 July 16, 2019 21:05
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jul 16, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jul 16, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#6533

@AutorestCI
Copy link

AutorestCI commented Jul 16, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Jul 16, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jul 16, 2019 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#3337

majastrz
majastrz requested changes Jul 16, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment

@majastrz majastrz added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 16, 2019
@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 16, 2019
majastrz
majastrz reviewed Jul 16, 2019
View reviewed changes
specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-10/resources.json Outdated
"tags": [
"Providers"
],
"operationId": "Providers_GetAtTenant",
Copy link
Member

@majastrz majastrz Jul 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providers_GetAtTenant [](start = 24, length = 21)

Let's do Providers_GetAtTenantScope #Closed

Copy link
Member Author

@mentat9 mentat9 Jul 16, 2019 •
edited by majastrz
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, and changed Providers_ListAll to Providers_ListAtTenantScope. #Closed

majastrz
majastrz reviewed Jul 16, 2019
View reviewed changes
specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-10/resources.json Outdated
"tags": [
"Providers"
],
"operationId": "Providers_ListAll",
Copy link
Member

@majastrz majastrz Jul 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providers_ListAll [](start = 24, length = 17)

Let's do Providers_ListAtTenantScope #Closed

Copy link
Member Author

@mentat9 mentat9 Jul 16, 2019 •
edited by majastrz
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. #Closed

majastrz
majastrz approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mentat9
Copy link
Member Author

mentat9 commented Jul 24, 2019

@mybayern1974 can you look at this and sign off or comment?

@majastrz
Copy link
Member

@mybayern1974 can you look at this and sign off or comment?

This has been sitting unreviewed by the SDK side of things for a bit now and it's blocking fixes to our PowerShell cmdlets. @sergey-shandar, do you know if @mybayern1974 is out of office and unavailable to review this?

@sergey-shandar sergey-shandar merged commit 7b603ca into Azure:master Jul 29, 2019
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 29, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 75b22d9, Iteration 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

@sergey-shandar sergey-shandar sergey-shandar approved these changes

@stankovski stankovski Awaiting requested review from stankovski

@mybayern1974 mybayern1974 Awaiting requested review from mybayern1974

Assignees

@sergey-shandar sergey-shandar

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mentat9 @azuresdkci @AutorestCI @majastrz @sergey-shandar @mybayern1974