[Hub Generated] Review request for Microsoft.DevTestLab to add version stable/2018-09-15 #6623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
nschonni
reviewed
Jul 15, 2019
specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2018-09-15/DTL.json
Outdated
Show resolved
Hide resolved
…b/stable/2018-09-15/DTL.json Co-Authored-By: Nick Schonning <[email protected]>
sarangan12
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
Changes are simple. Description changes are ok. I am Ok with enum changes also. But removal of a definition, path and changing from required:false definitely needs ARM review and approval. Adding the appropriate label. From SDK side, I do not have any issue. But I am holding off on the merge until ARM team can review.
specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2018-09-15/DTL.json
Show resolved
Hide resolved
specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2018-09-15/DTL.json
Show resolved
Hide resolved
specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2018-09-15/DTL.json
Show resolved
Hide resolved
sarangan12
added
the
WaitForARMFeedback
KrisBash
suggested changes
Jul 16, 2019
specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2018-09-15/DTL.json
Show resolved
Hide resolved
specification/devtestlabs/resource-manager/Microsoft.DevTestLab/stable/2018-09-15/DTL.json
Show resolved
Hide resolved
KrisBash
approved these changes
Jul 17, 2019
KrisBash
added
ARMSignedOff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist: