[LogicApps] New Api version #6601
Conversation
In Testing, Please Ignore[Logs] (Generated from 56286b2, Iteration 37)
|
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
|
Can one of the admins verify this patch? |
praries880
added
the
WaitForARMFeedback
|
@visharm Kindly fix the following:
And there are a bunch of other CI erros as well. |
| }, | ||
| "parameters": [ | ||
| { | ||
| "$ref": "#/parameters/subscription |
There was a problem hiding this comment.
This was removed from the previous api version and should be added back:
"default": {
"description": "Logic error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
| }, | ||
| "parameters": [ | ||
| { | ||
| "$ref": "#/parameters/subscription |
There was a problem hiding this comment.
This was removed from the previous api version and should be added back:
"default": {
"description": "Logic error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
| }, | ||
| "parameters": [ | ||
| { | ||
| "$ref": "#/parameters/subscription |
There was a problem hiding this comment.
This was removed from the previous api version and should be added back:
"default": {
"description": "Logic error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
There was a problem hiding this comment.
I just compared the swagger diff between 2019-05-01 to 2018-07-01. The only change is the version name.
The new swagger contains all this, where is this removed?
ryansbenson
added
the
ARMChangesRequested
|
I don’t see its removed.
The new api version has all this change.
From: ryansbenson <[email protected]>
Sent: Friday, July 12, 2019 4:16 PM
To: Azure/azure-rest-api-specs <[email protected]>
Cc: Vinita Sharma <[email protected]>; Mention <[email protected]>
Subject: Re: [Azure/azure-rest-api-specs] [LogicApps] New Api version (#6601)
@ryansbenson commented on this pull request.
Just some minor things that didn't come over from the last api version.
________________________________
In specification/logic/resource-manager/Microsoft.Logic/stable/2019-05-01/logic.json<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F6601%23discussion_r303174529&data=02%7C01%7CVinita.Sharma%40microsoft.com%7C4988a3f8d2c847ba453108d7071edc12%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636985701433386582&sdata=IEaT8tvbfHbqE9UK%2BYx1nZmPV49UIJmv9ah5yQV2gwk%3D&reserved=0>:
+ },
+ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Logic/workflows/{workflowName}/runs/{runName}/actions/{actionName}/requestHistories": {
+ "get": {
+ "tags": [
+ "WorkflowRunActions"
+ ],
+ "operationId": "WorkflowRunActionRequestHistories_List",
+ "description": "List a workflow run request history.",
+ "x-ms-examples": {
+ "List a request history": {
+ "$ref": "./examples/WorkflowRunActionRequestHistories_List.json"
+ }
+ },
+ "parameters": [
+ {
+ "$ref": "#/parameters/subscription
This was removed from the previous api version and should be added back:
"default": {
"description": "Logic error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
________________________________
In specification/logic/resource-manager/Microsoft.Logic/stable/2019-05-01/logic.json<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F6601%23discussion_r303174582&data=02%7C01%7CVinita.Sharma%40microsoft.com%7C4988a3f8d2c847ba453108d7071edc12%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636985701433396578&sdata=6uJvz%2FqvtCQVAQRCfNVFF%2FOojhPArwLbqQI0eNLI90w%3D&reserved=0>:
+ },
+ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Logic/workflows/{workflowName}/runs/{runName}/actions/{actionName}/requestHistories": {
+ "get": {
+ "tags": [
+ "WorkflowRunActions"
+ ],
+ "operationId": "WorkflowRunActionRequestHistories_List",
+ "description": "List a workflow run request history.",
+ "x-ms-examples": {
+ "List a request history": {
+ "$ref": "./examples/WorkflowRunActionRequestHistories_List.json"
+ }
+ },
+ "parameters": [
+ {
+ "$ref": "#/parameters/subscription
This was removed from the previous api version and should be added back:
"default": {
"description": "Logic error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
________________________________
In specification/logic/resource-manager/Microsoft.Logic/stable/2019-05-01/logic.json<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F6601%23discussion_r303174692&data=02%7C01%7CVinita.Sharma%40microsoft.com%7C4988a3f8d2c847ba453108d7071edc12%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636985701433406575&sdata=gke8Rr958njNigkImaFC5yBcRQI1%2FCWCWQyUV0mGoBs%3D&reserved=0>:
+ },
+ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Logic/workflows/{workflowName}/runs/{runName}/actions/{actionName}/requestHistories": {
+ "get": {
+ "tags": [
+ "WorkflowRunActions"
+ ],
+ "operationId": "WorkflowRunActionRequestHistories_List",
+ "description": "List a workflow run request history.",
+ "x-ms-examples": {
+ "List a request history": {
+ "$ref": "./examples/WorkflowRunActionRequestHistories_List.json"
+ }
+ },
+ "parameters": [
+ {
+ "$ref": "#/parameters/subscription
This was removed from the previous api version and should be added back:
"default": {
"description": "Logic error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F6601%3Femail_source%3Dnotifications%26email_token%3DAI3GSZUGJ42Y7VSGR236YOLP7EGB3A5CNFSM4IBWNGP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6LEPBA%23pullrequestreview-261506948&data=02%7C01%7CVinita.Sharma%40microsoft.com%7C4988a3f8d2c847ba453108d7071edc12%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636985701433406575&sdata=wxA%2B6nZj7yjxawM8SubgwqzEsVGNRHcASr%2BqjF4qmb4%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAI3GSZRJW3ICJABUS6XEEN3P7EGB3ANCNFSM4IBWNGPQ&data=02%7C01%7CVinita.Sharma%40microsoft.com%7C4988a3f8d2c847ba453108d7071edc12%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636985701433416571&sdata=bTGFxMvJBFdsUGFU4VavCsTnRhlXs2SPzVBXAgaOSpo%3D&reserved=0>.
|
You need to add a "default" response to cover all errors in your Swagger. This is missing from new and existing paths. Take a look at blueprint swagger, we have implemented that there. Refers to: specification/logic/resource-manager/Microsoft.Logic/stable/2019-05-01/logic.json:5110 in 4ee2e9a. [](commit_id = 4ee2e9a, deletion_comment = False) |
Your comments suggest that this is an asynchronous/long-running operation, but you are missing x-ms-long-running-operation extension. Please add it to all long running operations. Refers to: specification/logic/resource-manager/Microsoft.Logic/stable/2019-05-01/logic.json:5280 in 4ee2e9a. [](commit_id = 4ee2e9a, deletion_comment = False) |
In addition to the default response I mentioned earlier, you should also return 204 when the object doesn't exist. (DELETEs should never return 404.) Refers to: specification/logic/resource-manager/Microsoft.Logic/stable/2019-05-01/logic.json:5367 in 4ee2e9a. [](commit_id = 4ee2e9a, deletion_comment = False) |
The ARM RPC requires paths to follow the format type1/name1/type2/name2. I think the best option would be to rename it to Refers to: specification/logic/resource-manager/Microsoft.Logic/stable/2019-05-01/logic.json:5516 in 4ee2e9a. [](commit_id = 4ee2e9a, deletion_comment = False) |
specification/logic/resource-manager/Microsoft.Logic/stable/2019-05-01/logic.json
Show resolved
Hide resolved
Hi @jhendrixMSFT it seems that there is an issue related with code gen of go, I could not see where the problem locates, could you please help about this? |
specification/logic/resource-manager/Microsoft.Logic/stable/2019-05-01/logic.json
Outdated
Show resolved
Hide resolved
specification/logic/resource-manager/Microsoft.Logic/stable/2019-05-01/logic.json
Outdated
Show resolved
Hide resolved
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.