-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Cdn to add UrlRewrite and CacheKeyQueryString action to 2019-04-15 #6599
Merged
kpajdzik
merged 4 commits into
Azure:master
from
hytao:dev-cdn-Microsoft.Cdn-2019-06-15-preview
Jul 12, 2019
Merged
[Hub Generated] Review request for Microsoft.Cdn to add UrlRewrite and CacheKeyQueryString action to 2019-04-15 #6599
kpajdzik
merged 4 commits into
Azure:master
from
hytao:dev-cdn-Microsoft.Cdn-2019-06-15-preview
Jul 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Automation [Logs] (Generated from 9ec39b9, Iteration 4)Python: Azure/azure-sdk-for-python [Logs] [Diff]
Java: Azure/azure-sdk-for-java [Logs] [Diff]
Go: Azure/azure-sdk-for-go [Logs] [Diff]
.NET: Azure/azure-sdk-for-net [Logs] [Diff]
JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]
|
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goEncountered an unknown error: (azure-sdk-for-go)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 384, in _make_request
six.raise_from(e, None)
File "<string>", line 2, in raise_from
File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 380, in _make_request
httplib_response = conn.getresponse()
File "/usr/lib/python3.6/http/client.py", line 1331, in getresponse
response.begin()
File "/usr/lib/python3.6/http/client.py", line 297, in begin
version, status, reason = self._read_status()
File "/usr/lib/python3.6/http/client.py", line 258, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/usr/lib/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/usr/lib/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/usr/lib/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/usr/lib/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 638, in urlopen
_stacktrace=sys.exc_info()[2])
File "/usr/local/lib/python3.6/dist-packages/urllib3/util/retry.py", line 368, in increment
raise six.reraise(type(error), error, _stacktrace)
File "/usr/local/lib/python3.6/dist-packages/urllib3/packages/six.py", line 686, in reraise
raise value
File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 600, in urlopen
chunked=chunked)
File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 386, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 306, in _raise_timeout
raise ReadTimeoutError(self, url, "Read timed out. (read timeout=%s)" % timeout_value)
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='api.github.com', port=443): Read timed out. (read timeout=15)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
sdk_tag=sdk_tag
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 278, in generate_sdk_from_git_object
configure_user(gh_token, sdk_repo)
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 92, in configure_user
repo.git.config('user.email', user.email or '[email protected]')
File "/usr/local/lib/python3.6/dist-packages/github/AuthenticatedUser.py", line 134, in email
self._completeIfNotSet(self._email)
File "/usr/local/lib/python3.6/dist-packages/github/GithubObject.py", line 263, in _completeIfNotSet
self._completeIfNeeded()
File "/usr/local/lib/python3.6/dist-packages/github/GithubObject.py", line 267, in _completeIfNeeded
self.__complete()
File "/usr/local/lib/python3.6/dist-packages/github/GithubObject.py", line 272, in __complete
self._url.value
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 275, in requestJsonAndCheck
return self.__check(*self.requestJson(verb, url, parameters, headers, input, self.__customConnection(url)))
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 335, in requestJson
return self.__requestEncode(cnx, verb, url, parameters, headers, input, encode)
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 388, in __requestEncode
status, responseHeaders, output = self.__requestRaw(cnx, verb, url, requestHeaders, encoded_input)
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 412, in __requestRaw
response = cnx.getresponse()
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 114, in getresponse
r = verb(url, headers=self.headers, data=self.input, timeout=self.timeout, verify=self.verify, allow_redirects=False)
File "/usr/local/lib/python3.6/dist-packages/requests/sessions.py", line 546, in get
return self.request('GET', url, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/requests/sessions.py", line 533, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python3.6/dist-packages/requests/sessions.py", line 646, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/requests/adapters.py", line 529, in send
raise ReadTimeout(e, request=request)
requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='api.github.com', port=443): Read timed out. (read timeout=15) |
Can one of the admins verify this patch? |
nschonni
reviewed
Jul 11, 2019
specification/cdn/resource-manager/Microsoft.Cdn/preview/2019-06-15-preview/cdn.json
Outdated
Show resolved
Hide resolved
kpajdzik
reviewed
Jul 11, 2019
specification/cdn/resource-manager/Microsoft.Cdn/preview/2019-06-15-preview/cdn.json
Outdated
Show resolved
Hide resolved
kpajdzik
reviewed
Jul 11, 2019
specification/cdn/resource-manager/Microsoft.Cdn/preview/2019-06-15-preview/cdn.json
Outdated
Show resolved
Hide resolved
kpajdzik
reviewed
Jul 11, 2019
specification/cdn/resource-manager/Microsoft.Cdn/preview/2019-06-15-preview/cdn.json
Outdated
Show resolved
Hide resolved
kpajdzik
reviewed
Jul 11, 2019
specification/cdn/resource-manager/Microsoft.Cdn/preview/2019-06-15-preview/cdn.json
Outdated
Show resolved
Hide resolved
kpajdzik
approved these changes
Jul 11, 2019
After discussing with PM, we are going to make changes to the stable 2019-04-15 version instead of the 2019-06-15 preview version. I have move all my changes to 2019-04-15 version. |
hytao
changed the title
[Hub Generated] Review request for Microsoft.Cdn to add version preview/2019-06-15-preview
[Hub Generated] Review request for Microsoft.Cdn to add UrlRewrite and CacheKeyQueryString action to 2019-04-15
Jul 11, 2019
celikcigdem
pushed a commit
to celikcigdem/azure-rest-api-specs
that referenced
this pull request
Jul 17, 2019
…d CacheKeyQueryString action to 2019-04-15 (Azure#6599) * add UrlRewrite and CacheKeyQueryString actions. * fix typo * update * Move changes to 2019-04-15 version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist: