Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RP Data Share to specification folder [Public Preview] #6583

Merged
merged 3 commits into from
Jul 10, 2019
Merged

Add RP Data Share to specification folder [Public Preview] #6583

merged 3 commits into from
Jul 10, 2019

Conversation

gaurangisaxena
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 10, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 080fc05, Iteration 2)

Warning Python: Azure/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Succeeded Go: Azure/azure-sdk-for-go [Logs] [Diff]

@azuresdkci azuresdkci requested a review from mmyyrroonn July 10, 2019 17:04
@AutorestCI AutorestCI mentioned this pull request Jul 10, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 10, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6295

@AutorestCI
Copy link

AutorestCI commented Jul 10, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@gaurangisaxena
Copy link
Contributor Author

Link to the PR in private repo: https://github.com/Azure/azure-rest-api-specs-pr/pull/808

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jul 10, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 10, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5221

@mozehgir mozehgir requested a review from jhendrixMSFT July 10, 2019 17:16
@mozehgir
Copy link
Contributor

Hey @jhendrixMSFT
This spec was reviewed in the private repo by you, if this is good to go can we merge?

@jhendrixMSFT
Copy link
Member

@gaurangisaxena is the service live?

@gaurangisaxena
Copy link
Contributor Author

@gaurangisaxena is the service live?

@jhendrixMSFT We are working on removing "PrivatePreview" feature flags. It will be done in next 1 hour,

ryansbenson
ryansbenson approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataShare.json hasn't changed and was reviewed/approved in the PR repo

@ryansbenson ryansbenson added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 10, 2019
@jhendrixMSFT jhendrixMSFT merged commit 5701f7d into Azure:master Jul 10, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@gaurangisaxena @celikcigdem
Add RP Data Share to specification folder [Public Preview] (Azure#6583)
4411b10 
* add data share

* remove PII from examples

* remove unnecessary example files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryansbenson ryansbenson ryansbenson approved these changes

@mmyyrroonn mmyyrroonn Awaiting requested review from mmyyrroonn

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT

Assignees

@mmyyrroonn mmyyrroonn

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gaurangisaxena @AutorestCI @azuresdkci @mozehgir @jhendrixMSFT @ryansbenson @mmyyrroonn