Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated QnAMaker Runtime API headers descriptions #6559

Merged
merged 7 commits into from
Jul 25, 2019
Merged

Updated QnAMaker Runtime API headers descriptions #6559

merged 7 commits into from
Jul 25, 2019

Conversation

rokulka
Copy link
Member

@rokulka rokulka commented Jul 5, 2019

No description provided.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 5, 2019

SDK Automation [Logs] (Generated from 70d1ba4, Iteration 4)

Failed Python: Azure/azure-sdk-for-python [Logs]
  • No packages generated.
Failed Java: Azure/azure-sdk-for-java [Logs]
  • No packages generated.
Failed Go: Azure/azure-sdk-for-go [Logs]
  • No packages generated.
Failed JavaScript: Azure/azure-sdk-for-js [Logs]
  • No packages generated.
Warning Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@AutorestCI
Copy link

AutorestCI commented Jul 5, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5627

@AutorestCI
Copy link

AutorestCI commented Jul 5, 2019

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpctvpjxew/rest/specification/cognitiveservices/data-plane/QnAMaker/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpctvpjxew/sdk', '--java', '--multiapi', '[email protected]/[email protected]', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4383)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (2.1.85->2.1.85)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
FATAL: swagger-document/compose - FAILED
FATAL: Error: The 'title' across provided OpenAPI definitions has to match. Found: 'QnAMaker Client', 'QnAMaker Runtime Client'. Please adjust or provide an override (--title=...).
Process() cancelled due to exception : The 'title' across provided OpenAPI definitions has to match. Found: 'QnAMaker Client', 'QnAMaker Runtime Client'. Please adjust or provide an override (--title=...).
  Error: The 'title' across provided OpenAPI definitions has to match. Found: 'QnAMaker Client', 'QnAMaker Runtime Client'. Please adjust or provide an override (--title=...).

@AutorestCI
Copy link

AutorestCI commented Jul 5, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yaohaizh
Copy link
Contributor

yaohaizh commented Jul 8, 2019

@yangyuang, @DavidLiCIG Please help review this PR, thanks.

@yangyuan
Copy link
Member

Hi @rokulka and @bingisbestest

Can you explain why we have two swaggers with two titles and under two release tags?

If we want to have 1 package with 2 clients, we should include both in the same release tag.
If we want to have 2 packages and 1 client in each package, we need some structure changes in here.

@ghost
Copy link

ghost commented Jul 16, 2019

If we want to have 1 package with 2 clients, we should include both in the same release tag.

This is exactly the goal. @rokulka please fix the release tag as well.
Thanks @yangyuang for pointer

@yaohaizh yaohaizh added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Jul 16, 2019
@rokulka
Copy link
Member Author

rokulka commented Jul 16, 2019

Hi @rokulka and @bingisbestest

Can you explain why we have two swaggers with two titles and under two release tags?

If we want to have 1 package with 2 clients, we should include both in the same release tag.
If we want to have 2 packages and 1 client in each package, we need some structure changes in here.

@yangyuan We need different Titles, as we need different classes for our SDK. Could you suggest a way
for that? I will ping you over Teams for a brief sync up.

@yaohaizh yaohaizh removed the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Jul 22, 2019
@ghost
Copy link

ghost commented Jul 23, 2019

@yangyuan Please take a look.

@rokulka
Copy link
Member Author

rokulka commented Jul 25, 2019

@yaohaizh Can you please approve and merge the request.

@yaohaizh yaohaizh merged commit ad67077 into Azure:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants