Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cassandra connector properties for cosmos db C* account - #6550

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

bhba-coder
Copy link
Contributor

@bhba-coder bhba-coder commented Jul 3, 2019

enableCassandraConnector - This property, if set to true, will trigger the creation of the cassandra connector CCX pipeline which relicates data from native cassandra nodes to cosmos db C* account
connectorOffer - This property specifies the type of connector offer which will vary based on the data size of the native cassandra cluster
Validations -
Validated cosmos-db.json with autorest from https://github.com/Azure/azure-rest-api-specs/tree/master/specification/cosmos-db/resource-manager
Validated using the online schema validator - https://json-schema-validator.herokuapp.com

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

enableCassandraConnector - This property, if set to true, will trigger the creation of the cassandra connector CCX pipeline which relicates data from native cassandra nodes to cosmos db C* account
connectorOffer - This property specifies the type of connector offer which will vary based on the data size of the native cassandra cluster
Validations -
        Validated cosmos-db.json with autorest from https://github.com/Azure/azure-rest-api-specs/tree/master/specification/cosmos-db/resource-manager
        Validated using the online schema validator - https://json-schema-validator.herokuapp.com
@AutorestCI
Copy link

AutorestCI commented Jul 3, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5933

@AutorestCI
Copy link

AutorestCI commented Jul 3, 2019

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3409

@AutorestCI
Copy link

AutorestCI commented Jul 3, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5264

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 9, 2019
@@ -4343,6 +4343,14 @@
"enableMultipleWriteLocations": {
"description": "Enables the account to write in multiple locations",
"type": "boolean"
},
"enableCassandraConnector": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This involves adding a mutable property to an existing API version, which is considered a form of breaking change as it breaks the "GET->PUT pipeline." However, in this case, I think it is fairly safe.

@sergey-shandar sergey-shandar merged commit 3e57cec into Azure:master Jul 16, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
…re#6550)

enableCassandraConnector - This property, if set to true, will trigger the creation of the cassandra connector CCX pipeline which relicates data from native cassandra nodes to cosmos db C* account
connectorOffer - This property specifies the type of connector offer which will vary based on the data size of the native cassandra cluster
Validations -
        Validated cosmos-db.json with autorest from https://github.com/Azure/azure-rest-api-specs/tree/master/specification/cosmos-db/resource-manager
        Validated using the online schema validator - https://json-schema-validator.herokuapp.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-sdk-breaking-change WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants