Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close EnterpriseKnowledgeGraph go fence #6547

Merged
merged 2 commits into from
Jul 3, 2019
Merged

fix: close EnterpriseKnowledgeGraph go fence #6547

merged 2 commits into from
Jul 3, 2019

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Jul 3, 2019

No description provided.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 3, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from e5018e3)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jul 3, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Jul 3, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5193

@azuresdkci azuresdkci requested a review from shahabhijeet July 3, 2019 02:47
@AutorestCI
Copy link

AutorestCI commented Jul 3, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@nschonni
Copy link
Contributor Author

nschonni commented Jul 3, 2019

@jhendrixMSFT I think this was a problem before, but I'm not sure why it still fails

@nschonni nschonni changed the title fix: close EnterpriseKnowledgeGraph go fench fix: close EnterpriseKnowledgeGraph go fence Jul 3, 2019
@jhendrixMSFT
Copy link
Member

Here's the relevant failure info from the build.
FATAL: System.InvalidOperationException: codegen for preview swagger Microsoft.EnterpriseKnowledgeGraph/preview/2018-12-03/EnterpriseKnowledgeGraphSwagger.json must be under a preview subdirectory
The output path was wrong due to incorrect tags. Should be fixed now.

@AutorestCI AutorestCI mentioned this pull request Jul 3, 2019
Merged
@nschonni
Copy link
Contributor Author

nschonni commented Jul 3, 2019

Thanks @jhendrixMSFT! Looks like 2 files are being put under a double "preview" folder in the PR https://github.com/Azure/azure-sdk-for-go/pull/5192/files#diff-38e13a7f4d93f4d084cbbdfdc56733c7

@jhendrixMSFT
Copy link
Member

The double-preview folder is a known issue with the preview profile. It was designed before we moved preview packages under the preview directory. :(

@jhendrixMSFT jhendrixMSFT merged commit 3f9e277 into Azure:master Jul 3, 2019
@nschonni nschonni deleted the fix--close-EnterpriseKnowledgeGraph-go-fench branch July 3, 2019 17:07
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@nschonni @celikcigdem
fix: close EnterpriseKnowledgeGraph go fence (Azure#6547)
f4d0a32 
* fix: close EnterpriseKnowledgeGraph go fench

* fix Go SDK build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@shahabhijeet shahabhijeet Awaiting requested review from shahabhijeet

Assignees

@shahabhijeet shahabhijeet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nschonni @AutorestCI @azuresdkci @jhendrixMSFT @shahabhijeet