-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/ccelik/dedicated host swagger #6475
Dev/ccelik/dedicated host swagger #6475
Conversation
SDK Automation [Logs] (Generated from 2b0c742)
|
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Can one of the admins verify this patch? |
@sarangan12 @sergey-shandar linter emitted below error:
This is the PATCH request payload and is not used as response model. However this type derive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new file is not referenced in the readme file. Please update it
@sarangan12, @anuchandy, I resolved your comments, the new iteration is available. Could you please review it? |
@hyonholee , @huangpf could you please review this PR? |
"$ref": "#/definitions/DedicatedHostProperties" | ||
}, | ||
"sku": { | ||
"$ref": "#/definitions/Sku", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@celikcigdem @sarangan12, should this be #/definitions/sku or something else?
This definition does not exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correction: this Sku exists. Its comment says it describes a virtual machine scale set sku. I will use it for now, but I would have imagined that a new type DedicatedHostSkuTypes would be defined for this property.
Added new APIs for DedicatedHostGroups and DedicatedHosts
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.