Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/ccelik/dedicated host swagger #6475

Merged
merged 10 commits into from
Jul 3, 2019

Conversation

celikcigdem
Copy link
Contributor

Added new APIs for DedicatedHostGroups and DedicatedHosts

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 27, 2019

SDK Automation [Logs] (Generated from 2b0c742)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 27, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5195

@AutorestCI
Copy link

AutorestCI commented Jun 27, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5853

@AutorestCI
Copy link

AutorestCI commented Jun 27, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 27, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@anuchandy
Copy link
Member

@sarangan12 @sergey-shandar linter emitted below error:

R2020 - RequiredPropertiesMissingInResourceModel
Model definition 'DedicatedHostGroupUpdate' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. 
at specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json:5491

This is the PATCH request payload and is not used as response model.

However this type derive UpdateResource type which is marked as "x-ms-azure-resource", I don't see a need to mark it so though. Do you think linter emit this error due to this annotation? or anything else causing this error to trigger?

@anuchandy anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 27, 2019
Copy link
Contributor

@sarangan12 sarangan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new file is not referenced in the readme file. Please update it

@celikcigdem
Copy link
Contributor Author

The new file is not referenced in the readme file. Please update it

@sarangan12, @anuchandy, I resolved your comments, the new iteration is available. Could you please review it?

@celikcigdem
Copy link
Contributor Author

@hyonholee , @huangpf could you please review this PR?

@sarangan12 sarangan12 added the ARM-overdue ARM review has not occurred within the expected timeframe label Jul 3, 2019
"$ref": "#/definitions/DedicatedHostProperties"
},
"sku": {
"$ref": "#/definitions/Sku",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@celikcigdem @sarangan12, should this be #/definitions/sku or something else?

This definition does not exist

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: this Sku exists. Its comment says it describes a virtual machine scale set sku. I will use it for now, but I would have imagined that a new type DedicatedHostSkuTypes would be defined for this property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM-overdue ARM review has not occurred within the expected timeframe WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants