Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Portal to add version preview/2015-08-01-preview #6470

Merged
merged 8 commits into from
Jul 12, 2019
Merged

[Hub Generated] Review request for Microsoft.Portal to add version preview/2015-08-01-preview #6470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
03714a5
Adds base for updating Microsoft.Portal from version preview/2015-11-…
jjbfour Jun 26, 2019
35978c7
Updates readme
jjbfour Jun 26, 2019
d7b92eb
Updates API version in new specs and examples
jjbfour Jun 26, 2019
9eb0026
Add object type to each of the definitions
jjbfour Jun 28, 2019
5d8f4a5
Remove old api version and update to have the correct api-version
jjbfour Jul 2, 2019
e8c467c
Fix readme for sdk generation
jjbfour Jul 2, 2019
e7e9e0c
Fix auto rest version generation
jjbfour Jul 9, 2019
ac6f48c
update the preview version for dashboards
jjbfour Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...iew/examples/createOrUpdateDashboard.json → ...iew/examples/createOrUpdateDashboard.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"parameters": {
"dashboardName": "testDashboard",
"resourceGroupName": "testRG",
"api-version": "2015-11-01-preview",
"api-version": "2015-08-01-preview",
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"dashboard": {
"properties": {
Expand Down
2 changes: 1 addition & 1 deletion ...-01-preview/examples/deleteDashboard.json → ...-01-preview/examples/deleteDashboard.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"parameters": {
"dashboardName": "testDashboard",
"resourceGroupName": "testRG",
"api-version": "2015-11-01-preview",
"api-version": "2015-08-01-preview",
"subscriptionId": "00000000-0000-0000-0000-000000000000"
},
"responses": {
Expand Down
2 changes: 1 addition & 1 deletion ...-11-01-preview/examples/getDashboard.json → ...-08-01-preview/examples/getDashboard.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"parameters": {
"dashboardName": "testDashboard",
"resourceGroupName": "testRG",
"api-version": "2015-11-01-preview",
"api-version": "2015-08-01-preview",
"subscriptionId": "00000000-0000-0000-0000-000000000000"
},
"responses": {
Expand Down
2 changes: 1 addition & 1 deletion ...amples/listDashboardsByResourceGroup.json → ...amples/listDashboardsByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"parameters": {
"resourceGroupName": "testRG",
"api-version": "2015-11-01-preview",
"api-version": "2015-08-01-preview",
"subscriptionId": "00000000-0000-0000-0000-000000000000"
},
"responses": {
Expand Down
2 changes: 1 addition & 1 deletion ...xamples/listDashboardsBySubscription.json → ...xamples/listDashboardsBySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"parameters": {
"api-version": "2015-11-01-preview",
"api-version": "2015-08-01-preview",
"subscriptionId": "00000000-0000-0000-0000-000000000000"
},
"responses": {
Expand Down
2 changes: 1 addition & 1 deletion ...1-01-preview/examples/operationsList.json → ...8-01-preview/examples/operationsList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"parameters": {
"api-version": "2015-11-01-preview"
"api-version": "2015-08-01-preview"
},
"responses": {
"200": {
Expand Down
2 changes: 1 addition & 1 deletion ...-01-preview/examples/updateDashboard.json → ...-01-preview/examples/updateDashboard.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"parameters": {
"dashboardName": "testDashboard",
"resourceGroupName": "testRG",
"api-version": "2015-11-01-preview",
"api-version": "2015-08-01-preview",
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"dashboard": {
"tags": {
Expand Down
12 changes: 11 additions & 1 deletion ...al/preview/2015-11-01-preview/portal.json → ...al/preview/2015-08-01-preview/portal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"swagger": "2.0",
"info": {
"version": "2015-11-01-preview",
"version": "2015-08-01-preview",
"title": "portal",
"description": "Allows creation and deletion of Azure Shared Dashboards.",
"x-ms-code-generation-settings": {
Expand Down Expand Up @@ -379,6 +379,7 @@
},
"definitions": {
"DashboardListResult": {
"type": "object",
"properties": {
"value": {
"type": "array",
Expand All @@ -395,6 +396,7 @@
"description": "List of dashboards."
},
"DashboardParts": {
"type": "object",
"description": "A dashboard part.",
"required": [
"position"
Expand Down Expand Up @@ -445,6 +447,7 @@
}
},
"DashboardLens": {
"type": "object",
"description": "A dashboard lens.",
jjbfour marked this conversation as resolved.
Show resolved Hide resolved
"required": [
"order",
Expand Down Expand Up @@ -472,6 +475,7 @@
}
},
"DashboardProperties": {
"type": "object",
"description": "The shared dashboard properties.",
jjbfour marked this conversation as resolved.
Show resolved Hide resolved
"properties": {
"lenses": {
Expand All @@ -491,6 +495,7 @@
}
},
"Dashboard": {
"type": "object",
"description": "The shared dashboard resource definition.",
jjbfour marked this conversation as resolved.
Show resolved Hide resolved
"x-ms-azure-resource": true,
"x-ms-client-flatten": true,
Expand Down Expand Up @@ -536,6 +541,7 @@
}
},
"PatchableDashboard": {
"type": "object",
"description": "The shared dashboard resource definition.",
jjbfour marked this conversation as resolved.
Show resolved Hide resolved
"x-ms-azure-resource": true,
"x-ms-client-flatten": true,
Expand All @@ -555,6 +561,7 @@
}
},
"ResourceProviderOperationList": {
"type": "object",
"description": "Results of the request to list operations.",
"readOnly": true,
"properties": {
Expand All @@ -572,6 +579,7 @@
}
},
"ResourceProviderOperation": {
"type": "object",
"description": "Supported operations of this resource provider.",
jjbfour marked this conversation as resolved.
Show resolved Hide resolved
"readOnly": true,
"properties": {
Expand Down Expand Up @@ -607,6 +615,7 @@
}
},
"ErrorResponse": {
"type": "object",
"description": "Error response.",
jjbfour marked this conversation as resolved.
Show resolved Hide resolved
"properties": {
"error": {
Expand All @@ -616,6 +625,7 @@
}
},
"ErrorDefinition": {
"type": "object",
"description": "Error definition.",
jjbfour marked this conversation as resolved.
Show resolved Hide resolved
"properties": {
"code": {
Expand Down
10 changes: 5 additions & 5 deletions specification/portal/resource-manager/readme.go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ go:
clear-output-folder: true
```

### Tag: package-2015-11-01-preview and go
### Tag: package-2015-08-01-preview and go

These settings apply only when `--tag=package-2015-11-01-preview --go` is specified on the command line.
These settings apply only when `--tag=package-2015-08-01-preview --go` is specified on the command line.
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

```yaml $(tag) == 'package-2015-11-01-preview' && $(go)
output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2015-11-01-preview/$(namespace)
```
```yaml $(tag) == 'package-2015-08-01-preview' && $(go)
output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2015-08-01-preview/$(namespace)
```
15 changes: 8 additions & 7 deletions specification/portal/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,19 @@ For other options on installation see [Installing AutoRest](https://aka.ms/autor

These are the global settings for the portal.

```yaml
``` yaml
openapi-type: arm
tag: package-2015-11-01-preview
tag: package-2015-08-01-preview
```

### Tag: package-2015-11-01-preview

These settings apply only when `--tag=package-2015-11-01-preview` is specified on the command line.
### Tag: package-2015-08-01-preview

```yaml $(tag) == 'package-2015-11-01-preview'
These settings apply only when `--tag=package-2015-08-01-preview` is specified on the command line.

```yaml $(tag) == 'package-2015-08-01-preview'
input-file:
- Microsoft.Portal/preview/2015-11-01-preview/portal.json
- Microsoft.Portal/preview/2015-08-01-preview/portal.json
anthony-c-martin marked this conversation as resolved.
Show resolved Hide resolved
```

---
Expand All @@ -47,7 +48,7 @@ input-file:
This section describes what SDK should be generated by the automatic system.
This is not used by Autorest itself.

```yaml $(swagger-to-sdk)
``` yaml $(swagger-to-sdk)
swagger-to-sdk:
- repo: azure-sdk-for-python
- repo: azure-sdk-for-java
Expand Down
2 changes: 1 addition & 1 deletion specification/portal/resource-manager/readme.python.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ python:
payload-flattening-threshold: 2
namespace: Microsoft.Portal
package-name: portal
package-version: 2015-11-01-preview
package-version: 2015-08-01-preview
clear-output-folder: true
```

Expand Down
8 changes: 4 additions & 4 deletions specification/portal/resource-manager/readme.ruby.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@ These settings apply only when `--ruby` is specified on the command line.

```yaml
package-name: azure_mgmt_portal
package-version: 2015-11-01-preview
package-version: 2015-08-01-preview
azure-arm: true
```

### Tag: package-2015-11-01-preview and ruby
### Tag: package-2015-08-01-preview and ruby

These settings apply only when `--tag=package-2015-11-01-preview --ruby` is specified on the command line.
These settings apply only when `--tag=package-2015-08-01-preview --ruby` is specified on the command line.
Please also specify `--ruby-sdks-folder=<path to the root directory of your azure-sdk-for-ruby clone>`.

```yaml $(tag) == 'package-2015-11-01-preview' && $(ruby)
```yaml $(tag) == 'package-2015-08-01-preview' && $(ruby)
namespace: Microsoft.Portal
output-folder: $(ruby-sdks-folder)/portal
```