Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding objects necessary for mapping Oracle schemas and tables to PostgreSQL databases and tables #6456

Merged
merged 6 commits into from
Jul 11, 2019
Merged

Adding objects necessary for mapping Oracle schemas and tables to PostgreSQL databases and tables #6456

merged 6 commits into from
Jul 11, 2019

Conversation

vchske
Copy link
Contributor

@vchske vchske commented Jun 26, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@vchske vchske requested a review from hitenjava as a code owner June 26, 2019 00:33
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 26, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 4f5182d)

Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Failed Go: Azure/azure-sdk-for-go [Logs]
  • No packages generated.
Succeeded JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.
Failed Java: Azure/azure-sdk-for-java [Logs] [Diff]

@hitenjava hitenjava requested a review from huang91shu June 26, 2019 00:34
@AutorestCI
Copy link

AutorestCI commented Jun 26, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci azuresdkci requested a review from erich-wang June 26, 2019 00:35
@AutorestCI AutorestCI mentioned this pull request Jun 26, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 26, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5417

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

hitenjava
hitenjava reviewed Jun 26, 2019
View reviewed changes
...ft.DataMigration/preview/2018-07-15-preview/definitions/OracleAzureDbPostgreSqlSyncTask.json
"selectedSchemas"
]
},
"GetUserTablesOracleTaskOutput": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing change - Where are these being referred?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to the missing parts in Tasks.json? If so, these have been added now.

@AutorestCI
Copy link

AutorestCI commented Jun 26, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5224

@AutorestCI AutorestCI mentioned this pull request Jun 26, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 26, 2019 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#3730

@AutorestCI AutorestCI mentioned this pull request Jun 26, 2019
Closed
@vchske
Copy link
Contributor Author

vchske commented Jun 26, 2019

@erich-wang I was told that instead of submitting a new commit for any changes that I should force the new changes onto a single commit. As I am not a git master, do you have guidance on how this is done?

@nschonni
Copy link
Contributor

@vchske I think they "squash merge" when landing PRs, so you should be able to just push the additional commit. If you want to cleanup the commits down to 1, you can use a rebase and squash like http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html and then git push -f to force the new single commit as the branch

@erich-wang
Copy link
Member

@vchske , please resolve the comments from @huang91shu and @hitenjava.

@vchske
Copy link
Contributor Author

vchske commented Jul 1, 2019

@erich-wang Comments have been resolved and the change is approved so I think we are ready for a merge.

@erich-wang erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 2, 2019
@erich-wang
Copy link
Member

@vchske , I just noticed that you missed the ARM API Review Checklist, so just added WaitForARMFeedback. Of course we could skip this step if @huang91shu is from ARM review board.

@vchske
Copy link
Contributor Author

vchske commented Jul 2, 2019

@erich-wang We aren't making a breaking change with this. We aren't adding or removing an API endpoint. Based on this, I don't believe an ARM review is necessary. This is essentially the same as #5801 and that one also did not require an ARM review.

@erich-wang
Copy link
Member

@vchske , you're adding properties which falls into below checklist:

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

@erich-wang
Copy link
Member

@ravbhatnagar, could you help review this PR from ARM perspective?

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 10, 2019
@erich-wang erich-wang merged commit b453699 into Azure:master Jul 11, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@vchske @celikcigdem
Adding objects necessary for mapping Oracle schemas and tables to Pos…
703740c 
…tgreSQL databases and tables (Azure#6456)

* Update MongoDbTasks.json

* Update readme.md

* Adding objects necessary for mapping Oracle schemas and tables to PostgreSQL databases and tables 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hitenjava hitenjava hitenjava left review comments

@nschonni nschonni nschonni left review comments

@ryansbenson ryansbenson ryansbenson approved these changes

@huang91shu huang91shu huang91shu approved these changes

@erich-wang erich-wang erich-wang approved these changes

Assignees

@erich-wang erich-wang

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vchske @AutorestCI @azuresdkci @nschonni @erich-wang @hitenjava @huang91shu @ryansbenson