Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ProximityPlacementGroupType description to scope out 'Ultra' from usage #6404

Merged
merged 9 commits into from
Jun 25, 2019

Conversation

aspand
Copy link
Contributor

@aspand aspand commented Jun 21, 2019

Latest improvements:

This PR for updating description of ProximityPlacementGroupType (added in #5507). ProximityPlacementGroupType can assume value 'Standard' or 'Ultra'. ProximityPlacementGroupType 'Ultra' is not supported. Support for 'Ultra' shall be added in future .
The PR is to add this detail in description of ProximityPlacementGroupType so that user can be informed (from documentation generated using the swagger spec) to not use 'Ultra'.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@aspand aspand requested review from huangpf and hyonholee as code owners June 21, 2019 09:13
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 21, 2019

SDK Automation [Logs] (Generated from 451b51f)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 21, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 21, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5853

@AutorestCI
Copy link

AutorestCI commented Jun 21, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5108

@AutorestCI
Copy link

AutorestCI commented Jun 21, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@kpajdzik
Copy link
Contributor

Do you want to fix Model Validation errors in this PR?

@aspand
Copy link
Contributor Author

aspand commented Jun 25, 2019

Do you want to fix Model Validation errors in this PR?

The scope of the PR is to just add the description

@sergey-shandar sergey-shandar merged commit 0a66610 into Azure:master Jun 25, 2019
@steveesp
Copy link

Only the description should be changed, as follows:
Ultra – For future use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants