Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Resources API update to 2019-05-10 #6402

Merged
merged 9 commits into from
Jun 28, 2019
Merged

Microsoft.Resources API update to 2019-05-10 #6402

merged 9 commits into from
Jun 28, 2019

Conversation

hjhhh3000vitae
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 20, 2019

SDK Automation [Logs] (Generated from 2d55a98)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#6155

@hjhhh3000vitae hjhhh3000vitae added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 20, 2019
@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3337

@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@hjhhh3000vitae hjhhh3000vitae removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 21, 2019
@hjhhh3000vitae hjhhh3000vitae marked this pull request as ready for review June 21, 2019 01:20
@hjhhh3000vitae hjhhh3000vitae added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 26, 2019
@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 27, 2019
@hjhhh3000vitae
Copy link
Contributor Author

@tjprescott Could you please review this PR as ARM has signed off.

@tjprescott
Copy link
Member

Waiting for @antmarti-microsoft to sign-off on changes.

@tjprescott tjprescott merged commit c6eb684 into Azure:master Jun 28, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
* Adds base for updating Microsoft.Resources from version stable/2019-05-01 to version 2019-05-10

* Updates readme

* Updates API version in new specs and examples

* Update readme

* Revert unintentional change

* Remove unwanted test

* Add back all examples

* Update description

* Update API version
leni-msft pushed a commit to leni-msft/azure-rest-api-specs that referenced this pull request May 13, 2022
* Update SAPVirtualInstance.json

updated databaseInstance props

* Update SAPVirtualInstance.json

minor fix

* Changes to add database type to Database Configuration/Single Server configuration, Changes to remove health from Database Instance examples.

* Corrections.

Co-authored-by: Ajay Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants