Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failover database and elastic pool swagger changes #6365

Merged
merged 8 commits into from
Jul 9, 2019
Merged

Failover database and elastic pool swagger changes #6365

merged 8 commits into from
Jul 9, 2019

Conversation

emgu-ms
Copy link
Contributor

@emgu-ms emgu-ms commented Jun 17, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Description:
Changes to add failover database and failover elastic pool to swagger.

@emgu-ms emgu-ms requested a review from jaredmoo as a code owner June 17, 2019 20:58
@azuresdkci azuresdkci requested a review from yaohaizh June 17, 2019 20:59
@AutorestCI
Copy link

AutorestCI commented Jun 17, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5771

@AutorestCI AutorestCI mentioned this pull request Jun 17, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 17, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#2635

@AutorestCI AutorestCI mentioned this pull request Jun 17, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 17, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3877

@AutorestCI
Copy link

AutorestCI commented Jun 17, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 17, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 23564cc)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

jaredmoo
jaredmoo approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@jaredmoo jaredmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the api is available in production, then you need to add links to these files in readme.md

...ication/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/FailoverDatabases.json
"tags": [
"FailoverDatabases"
],
"description": "Failovers a database.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails a database over?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there is any less jargony way to describe this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API is available in production, I will go ahead and add to the readme.md. For failover database, customers know what a failover is. We originally had restart database but opted for failover instead as in the future we're thinking about doing planned and unplanned failovers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok in that case please add to all package-composite-v*, and also the package-pure- which matches the api version.

@AutorestCI
Copy link

AutorestCI commented Jun 18, 2019 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#3004

@AutorestCI AutorestCI mentioned this pull request Jun 18, 2019
Merged
@AutorestCI AutorestCI mentioned this pull request Jun 18, 2019
Closed
@yaohaizh yaohaizh added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 18, 2019
@nschonni
Copy link
Contributor

Avocado failures are because the files have a BOM. You'd need to resave as regular UTF-8-without BOM to fix it

@sergey-shandar
Copy link
Contributor

@daschult could you check JS SDK generation failure?

@ghost
Copy link

ghost commented Jun 19, 2019

@sergey-shandar We've disabled the JavaScript portion of Swagger to SDK in favor of the JavaScript portion of SDK Automation (which is green in the SDK Automation comment above). I recommend disabling the JavaScript Swagger to SDK check for this repository.

@ravbhatnagar
Copy link
Contributor

Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 26, 2019
@yaohaizh
Copy link
Contributor

@emgu-ms could help resolve the conflict first?

@yaohaizh
Copy link
Contributor

yaohaizh commented Jul 8, 2019

@emgu-ms Any update on this? Could you help resolve the conflict?

@emgu-ms
Copy link
Contributor Author

emgu-ms commented Jul 8, 2019

@emgu-ms Any update on this? Could you help resolve the conflict?
On it, sorry was oof until today

@emgu-ms
Copy link
Contributor Author

emgu-ms commented Jul 8, 2019

@yaohaizh Merge conflicts resolved, thank you!

@yaohaizh yaohaizh merged commit 597f7dd into Azure:master Jul 9, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@emgu-ms @celikcigdem
Failover database and elastic pool swagger changes (Azure#6365)
21f1fc6 
* Add swagger changes for failover databases and failover elastic pools

* Fixed api version for FailoverDatabases

* Add examples

* Add to read me

* Remove BOM from files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredmoo jaredmoo jaredmoo approved these changes

@yaohaizh yaohaizh yaohaizh approved these changes

Assignees

@yaohaizh yaohaizh

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@emgu-ms @AutorestCI @azuresdkci @nschonni @sergey-shandar @ravbhatnagar @yaohaizh @jaredmoo