Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Security to add version preview/2017-08-01-preview #6361

Merged
merged 1 commit into from
Jun 20, 2019
Merged

[Hub Generated] Review request for Microsoft.Security to add version preview/2017-08-01-preview #6361

merged 1 commit into from
Jun 20, 2019

Conversation

MichalHel
Copy link
Contributor

@MichalHel MichalHel commented Jun 17, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@AutorestCI
Copy link

AutorestCI commented Jun 17, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 17, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@azuresdkci azuresdkci requested a review from yungezz June 17, 2019 06:00
@AutorestCI
Copy link

AutorestCI commented Jun 17, 2019 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Jun 17, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jun 17, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yungezz
Copy link
Member

yungezz commented Jun 17, 2019

HI @sergey-shandar do you know who is code owner for this area to help look at this change? thanks.

@yungezz
Copy link
Member

yungezz commented Jun 18, 2019

hello @dortibi could you pls review the change since it's a breaking change?

@MichalHel
Copy link
Contributor Author

MichalHel commented Jun 18, 2019 via email

@sergey-shandar sergey-shandar mentioned this pull request Jun 19, 2019
Open
@yungezz yungezz merged commit 38de98d into Azure:master Jun 20, 2019
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 20, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 8f04d58)

Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-shandar sergey-shandar sergey-shandar approved these changes

@yungezz yungezz Awaiting requested review from yungezz

Assignees

@yungezz yungezz

Labels
potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MichalHel @AutorestCI @azuresdkci @yungezz @sergey-shandar