[HDInsight] Add ListBillingSpecs API to HDInsight's stable and preview version #6360

aim-for-better · 2019-06-17T03:35:05Z

Add ListBillingSpecs API to HDInsight's two api version(stable/2018-06-01-preview, preview/2015-03-01-preview)

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-06-17T03:35:07Z

SDK Automation [Logs] (Generated from ddf1a22)

Go: Azure/azure-sdk-for-go

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

Python: Azure/azure-sdk-for-python

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

AutorestCI · 2019-06-17T03:36:34Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-06-17T03:36:44Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6082

AutorestCI · 2019-06-17T03:36:52Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3833

AutorestCI · 2019-06-17T03:38:29Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5169

AutorestCI · 2019-06-17T03:39:48Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3285

nschonni

exlucsion -> exclusion

...ion/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/locations.json

...tion/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/locations.json

azuresdkci · 2019-06-17T04:23:07Z

Can one of the admins verify this patch?

idear1203 · 2019-06-17T06:33:01Z

LGTM.

yungezz · 2019-06-17T09:01:42Z

this is adding new Api and properties in preview and stable versions, need ARM review.

jhendrixMSFT · 2019-06-17T23:13:41Z

@AutorestCI regenerate azure-sdk-for-go

sergey-shandar · 2019-06-18T00:19:51Z

...tion/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/locations.json

@@ -72,6 +72,45 @@
          }


Why is there preview version inside stable folder?

Why is there preview version inside stable folder?

@idear1203 could you please help me reply this?

@sergey-shandar This is intentional. It’s a little confusing, but per rule #5 here, whether the swagger spec is in the preview or stable folder “is not a direct analog for whether or not an API Version has the ‘-preview’ suffix or not. SDKs that are generated from 'preview' folder items should indicate to their customers in the most idiomatic way that breaking changes may still be coming.”

Basically the short version is that HDInsight is a GA service that still has an API with a -preview tag. Somebody made the decision several years ago to release stable versions of Hydra/Hyak SDKs for .NET, JavaScript, etc. that consumed this the -preview API. We are now releasing stable swagger-based SDKs so we can at least finally deprecate the Hydra/Hyak SDKs. As a result, we are making a commitment that we will not make breaking changes to this swagger spec version so we can GA some swagger-based SDKs.

idear1203 · 2019-06-20T23:59:20Z

@yungezz Is there a ETA for ARM feedback? We have been waiting for several days

idear1203 · 2019-06-24T17:16:19Z

@NelsonDaniel Could we get some ARM feedback? This PR is blocking for one week now

NelsonDaniel · 2019-06-24T19:35:10Z

@idear1203 I am not the ARM reviewer, I am the spec reviewer. As stated on top of the PR: "If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process."
Hope this helps. Also, I will go ahead and perform the swagger review, but still, it needs ARM review.

NelsonDaniel · 2019-06-24T23:20:37Z

...tion/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/locations.json

@@ -123,6 +162,140 @@
        }
      },
      "readOnly": true
+    },
+    "BillingResponseListResult": {
+      "description": "The response for the operation to get regional billingSpecs for a subscription.",


The type field must be added in every model that does not have it. In this case, type: object must be added. For your reference: https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/creating-swagger.md#understanding-the-importance-of-type-keyword-while-defining-model-types #Resolved

NelsonDaniel · 2019-06-24T23:43:18Z

...tion/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/locations.json

+          "description": "The managed disk billing sku, P30 or S30.",
+          "type": "string"
+        },
+        "tier": {


From the description there is a limited set of values this will accept. Would it be better to have an x-ms-enum? #Resolved

There can be other values. Let's keep it as it is now

...ion/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/locations.json

NelsonDaniel · 2019-06-24T23:45:58Z

...ion/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/locations.json

@@ -338,6 +377,140 @@
          }
        }
      }
+    },
+    "BillingResponseListResult": {


type: object #Resolved

NelsonDaniel · 2019-06-24T23:46:11Z

...ion/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/locations.json

+        }
+      }
+    },
+    "VmSizeCompatibilityFilterV2": {


type: object #Resolved

NelsonDaniel · 2019-06-24T23:49:57Z

...ion/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/locations.json

+        }
+      }
+    },
+    "BillingResources": {


type: object #Resolved

NelsonDaniel · 2019-06-24T23:50:22Z

...ion/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/locations.json

+        }
+      }
+    },
+    "BillingMeters": {


type: object #Resolved

NelsonDaniel · 2019-06-24T23:51:50Z

...tion/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/locations.json

+        }
+      }
+    },
+    "VmSizeCompatibilityFilterV2": {


type: object #Resolved

NelsonDaniel · 2019-06-24T23:52:25Z

...tion/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/locations.json

+      "description": "This class represent a single filter object that defines a multidimensional set. The dimensions of this set are Regions, ClusterFlavors, NodeTypes and ClusterVersions. The constraint should be defined based on the following: FilterMode (Exclude vs Include), VMSizes (the vm sizes in affect of exclusion/inclusion) and the ordering of the Filters. Later filters override previous settings if conflicted.",
+      "properties": {
+        "filterMode": {
+          "description": "The filtering mode. Effectively this can enabling or disabling the VM sizes in a particular set.",


Would something other than string make more sense since you have only two states? #Resolved

NelsonDaniel · 2019-06-24T23:53:18Z

...tion/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/locations.json

+        }
+      }
+    },
+    "BillingResources": {


type: object #Resolved

idear1203 · 2019-06-25T12:23:33Z

@NelsonDaniel Thank you for the information! We have notified ARM team for a review. Meanwhile, we are updating code per your comments:)

idear1203 · 2019-06-26T07:15:07Z

Hi @NelsonDaniel , after adding type: object, we got the following model validation error. Could you please help take a look?


Validating "examples" and "x-ms-examples" in  specification/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/locations.json: |  
-- | --
  |   |  
  | error : |  
  | operationId: Locations_ListBillingSpecs |  
  | scenario: Get the subscription billingSpecs for the specified location |  
  | source: response |  
  | responseCode: '200' |  
  | severity: 0 |  
  | code: INVALID_TYPE |  
  | details: |  
  | code: INVALID_TYPE |  
  | params: |  
  | - object |  
  | - undefined |  
  | message: Expected type object but found type undefined |  
  | path: '' |  
  | title: '#/definitions/BillingResponseListResult' |  
  | description: >- |  
  | The response for the operation to get regional billingSpecs for a |  
  | subscription. |  
  | position: |  
  | line: 381 |  
  | column: 34 |  
  | url: >- |  
  | specification/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/locations.json |  
  | directives: {} |  
  | jsonPath: '' |  
  |   |  
  | Validating "examples" and "x-ms-examples" in  specification/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/locations.json: |  
  |   |  
  | error : |  
  | operationId: Locations_ListBillingSpecs |  
  | scenario: Get the subscription billingSpecs for the specified location |  
  | source: response |  
  | responseCode: '200' |  
  | severity: 0 |  
  | code: INVALID_TYPE |  
  | details: |  
  | code: INVALID_TYPE |  
  | params: |  
  | - object |  
  | - undefined |  
  | message: Expected type object but found type undefined |  
  | path: '' |  
  | title: '#/definitions/BillingResponseListResult' |  
  | description: >- |  
  | The response for the operation to get regional billingSpecs for a |  
  | subscription. |  
  | position: |  
  | line: 166 |  
  | column: 34 |  
  | url: >- |  
  | specification/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/locations.json |  
  | directives: {} |  
  | jsonPath: '' |  
  |   |  
  | ##[error]Bash exited with code '1'.

jhendrixMSFT · 2019-06-26T17:23:58Z

@AutorestCI regenerate azure-sdk-for-go

ravbhatnagar · 2019-06-26T22:50:50Z

Signing off from ARM side.

Fix model validation errors

idear1203 · 2019-06-26T23:56:18Z

Hi @NelsonDaniel , after adding type: object, we got the following model validation error. Could you please help take a look?


Validating "examples" and "x-ms-examples" in  specification/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/locations.json: |  
-- | --
  |   |  
  | error : |  
  | operationId: Locations_ListBillingSpecs |  
  | scenario: Get the subscription billingSpecs for the specified location |  
  | source: response |  
  | responseCode: '200' |  
  | severity: 0 |  
  | code: INVALID_TYPE |  
  | details: |  
  | code: INVALID_TYPE |  
  | params: |  
  | - object |  
  | - undefined |  
  | message: Expected type object but found type undefined |  
  | path: '' |  
  | title: '#/definitions/BillingResponseListResult' |  
  | description: >- |  
  | The response for the operation to get regional billingSpecs for a |  
  | subscription. |  
  | position: |  
  | line: 381 |  
  | column: 34 |  
  | url: >- |  
  | specification/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/locations.json |  
  | directives: {} |  
  | jsonPath: '' |  
  |   |  
  | Validating "examples" and "x-ms-examples" in  specification/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/locations.json: |  
  |   |  
  | error : |  
  | operationId: Locations_ListBillingSpecs |  
  | scenario: Get the subscription billingSpecs for the specified location |  
  | source: response |  
  | responseCode: '200' |  
  | severity: 0 |  
  | code: INVALID_TYPE |  
  | details: |  
  | code: INVALID_TYPE |  
  | params: |  
  | - object |  
  | - undefined |  
  | message: Expected type object but found type undefined |  
  | path: '' |  
  | title: '#/definitions/BillingResponseListResult' |  
  | description: >- |  
  | The response for the operation to get regional billingSpecs for a |  
  | subscription. |  
  | position: |  
  | line: 166 |  
  | column: 34 |  
  | url: >- |  
  | specification/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/locations.json |  
  | directives: {} |  
  | jsonPath: '' |  
  |   |  
  | ##[error]Bash exited with code '1'.

Resolved by correct example file: change "Body" to "body"

NelsonDaniel · 2019-06-27T18:28:33Z

...ion/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/locations.json

+          ],
+          "x-ms-enum": {
+            "name": "Tier",
+            "modelAsString": false


Please change this to true.

I think this should be "modelAsString" : true
@ravbhatnagar, do you agree?

We cannot do this because our SDK is GA now and it will be a breaking change. We will fix the issue in the next API version. Created a GitHub issue #6505 to track this.

NelsonDaniel · 2019-06-27T18:29:00Z

...tion/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/locations.json

+          ],
+          "x-ms-enum": {
+            "name": "Tier",
+            "modelAsString": false


Please change this to true.

I think this should be "modelAsString" : true
@ravbhatnagar, do you agree?

We cannot do this because our SDK is GA now and it will be a breaking change. We will fix the issue in the next API version. Created a GitHub issue #6505 to track this.

NelsonDaniel · 2019-06-28T01:10:58Z

...ion/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/locations.json

+            ],
+            "x-ms-enum": {
+              "name": "OSType",
+              "modelAsString": false


I think this should be "modelAsString" : true
@ravbhatnagar, do you agree?

We want to reuse the exising OSType definition here. If we change "modelAsString" as true for this OSType definition, we will get the following error:

FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'OSType' and different values: Windows,Linux vs. Windows,Linux at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/ObjectBuilder.cs:line 150 at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 217 at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 48 at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/ObjectBuilder.cs:line 182 at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 217 at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 48 at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 133 at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/ObjectBuilder.cs:line 182 at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 217 at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 48 at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 133 at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 348 at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 66 at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 60 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at NewPlugin.<Process>d__15.MoveNext() FATAL: csharp/imodeler1 - FAILED FATAL: Error: Plugin imodeler1 reported failure. Process() cancelled due to exception : Plugin imodeler1 reported failure. Error: Plugin imodeler1 reported failure.

That definition should also be corrected

We cannot do this because our SDK is GA now and it will be a breaking change. We will fix the issue in the next API version. Created a GitHub issue #6505 to track this.

NelsonDaniel · 2019-06-28T01:11:10Z

...ion/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/locations.json

+          ],
+          "x-ms-enum": {
+            "name": "Tier",
+            "modelAsString": false


I think this should be "modelAsString" : true
@ravbhatnagar, do you agree?

NelsonDaniel · 2019-06-28T01:11:22Z

...tion/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/locations.json

+            ],
+            "x-ms-enum": {
+              "name": "OSType",
+              "modelAsString": false


I think this should be "modelAsString" : true
@ravbhatnagar, do you agree?

We want to reuse the exising Tier definition here. If we change "modelAsString" as true for this Tier definition, we will get the following error:

FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'Tier' and different values: Standard,Premium vs. Standard,Premium at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/ObjectBuilder.cs:line 150 at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 217 at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 48 at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 133 at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/ObjectBuilder.cs:line 182 at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 217 at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 48 at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 133 at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/ObjectBuilder.cs:line 182 at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 217 at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 48 at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 133 at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 348 at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 66 at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 60 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at NewPlugin.<Process>d__15.MoveNext() FATAL: csharp/imodeler1 - FAILED FATAL: Error: Plugin imodeler1 reported failure. Process() cancelled due to exception : Plugin imodeler1 reported failure. Error: Plugin imodeler1 reported failure.

That definition should also be corrected

We cannot do this because our SDK is GA now and it will be a breaking change. We will fix the issue in the next API version. Created a GitHub issue #6505 to track this.

NelsonDaniel · 2019-06-28T01:11:35Z

...tion/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/locations.json

+          ],
+          "x-ms-enum": {
+            "name": "Tier",
+            "modelAsString": false


I think this should be "modelAsString" : true
@ravbhatnagar, do you agree?

NelsonDaniel

In the future x-ms-enums should "modelAsString": true to avoid breaking changes in the generated types. @idear1203 created an issue here #6505

…w version (Azure#6360) * Add ListBillingSpecs API to stable and preview version * Add enum for tier, osType and filtermode * Update HDI_Locations_ListBillingSpecs.json Fix model validation errors * Update HDI_Locations_ListBillingSpecs.json Fix model validation errors

azuresdkci assigned NelsonDaniel Jun 17, 2019

azuresdkci requested a review from NelsonDaniel June 17, 2019 03:36

AutorestCI mentioned this pull request Jun 17, 2019

[AutoPR hdinsight/resource-manager] [HDInsight] Add ListBillingSpecs API to HDInsight's stable and preview version Azure/azure-sdk-for-python#5888

Closed

AutorestCI mentioned this pull request Jun 17, 2019

[AutoPR hdinsight/resource-manager] [HDInsight] Add ListBillingSpecs API to HDInsight's stable and preview version Azure/azure-sdk-for-java#3936

Merged

nschonni reviewed Jun 17, 2019

View reviewed changes

...ion/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/locations.json Outdated Show resolved Hide resolved

...tion/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/locations.json Outdated Show resolved Hide resolved

Add ListBillingSpecs API to stable and preview version

f748fe9

aim-for-better force-pushed the AddBillingSpec branch from 5b385e8 to f748fe9 Compare June 17, 2019 06:41

yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 17, 2019

AutorestCI mentioned this pull request Jun 17, 2019

[AutoPR hdinsight/resource-manager] [HDInsight] Add ListBillingSpecs API to HDInsight's stable and preview version Azure/azure-sdk-for-go#5033

Closed

sergey-shandar reviewed Jun 18, 2019

View reviewed changes

idear1203 added the HDInsight label Jun 21, 2019

NelsonDaniel suggested changes Jun 24, 2019

View reviewed changes

Add enum for tier, osType and filtermode

c3eda28

AutorestCI mentioned this pull request Jun 26, 2019

[AutoPR hdinsight/resource-manager] [HDInsight] Add ListBillingSpecs API to HDInsight's stable and preview version Azure/azure-sdk-for-python#6104

Merged

AutorestCI mentioned this pull request Jun 26, 2019

[AutoPR hdinsight/resource-manager] [HDInsight] Add ListBillingSpecs API to HDInsight's stable and preview version Azure/azure-sdk-for-go#5131

Merged

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 26, 2019

idear1203 added 2 commits June 27, 2019 07:47

Update HDI_Locations_ListBillingSpecs.json

96ac8ce

Fix model validation errors

Update HDI_Locations_ListBillingSpecs.json

ddf1a22

Fix model validation errors

NelsonDaniel reviewed Jun 27, 2019

View reviewed changes

NelsonDaniel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 28, 2019

NelsonDaniel reviewed Jun 28, 2019

View reviewed changes

NelsonDaniel approved these changes Jun 28, 2019

View reviewed changes

NelsonDaniel merged commit db00be4 into Azure:master Jun 28, 2019

NelsonDaniel removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 28, 2019

aim-for-better mentioned this pull request Aug 13, 2019

[HDInsight] Add three new features GetCapabilites, AutoScale, GetBillingSpec Azure/azure-sdk-for-net#7254

Merged

[HDInsight] Add ListBillingSpecs API to HDInsight's stable and preview version #6360

[HDInsight] Add ListBillingSpecs API to HDInsight's stable and preview version #6360

Conversation

aim-for-better commented Jun 17, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jun 17, 2019 • edited Loading

SDK Automation [Logs] (Generated from ddf1a22)

AutorestCI commented Jun 17, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 17, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 17, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Jun 17, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jun 17, 2019 • edited Loading

Automation for azure-sdk-for-java

nschonni left a comment

Choose a reason for hiding this comment

azuresdkci commented Jun 17, 2019

idear1203 commented Jun 17, 2019

yungezz commented Jun 17, 2019

jhendrixMSFT commented Jun 17, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

idear1203 commented Jun 20, 2019

idear1203 commented Jun 24, 2019

NelsonDaniel commented Jun 24, 2019 • edited Loading

NelsonDaniel Jun 24, 2019 • edited by idear1203 Loading

Choose a reason for hiding this comment

NelsonDaniel Jun 24, 2019 • edited by idear1203 Loading

Choose a reason for hiding this comment

idear1203 Jun 26, 2019 • edited Loading

Choose a reason for hiding this comment

NelsonDaniel Jun 24, 2019 • edited by idear1203 Loading

Choose a reason for hiding this comment

NelsonDaniel Jun 24, 2019 • edited by idear1203 Loading

Choose a reason for hiding this comment

NelsonDaniel Jun 24, 2019 • edited by idear1203 Loading

Choose a reason for hiding this comment

NelsonDaniel Jun 24, 2019 • edited by idear1203 Loading

Choose a reason for hiding this comment

NelsonDaniel Jun 24, 2019 • edited by idear1203 Loading

Choose a reason for hiding this comment

NelsonDaniel Jun 24, 2019 • edited by idear1203 Loading

Choose a reason for hiding this comment

NelsonDaniel Jun 24, 2019 • edited by idear1203 Loading

Choose a reason for hiding this comment

idear1203 commented Jun 25, 2019

idear1203 commented Jun 26, 2019 • edited Loading

jhendrixMSFT commented Jun 26, 2019

ravbhatnagar commented Jun 26, 2019

idear1203 commented Jun 26, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NelsonDaniel left a comment

Choose a reason for hiding this comment

aim-for-better commented Jun 17, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

NelsonDaniel commented Jun 24, 2019 •

edited

Loading

NelsonDaniel Jun 24, 2019 •

edited by idear1203

Loading

NelsonDaniel Jun 24, 2019 •

edited by idear1203

Loading

idear1203 Jun 26, 2019 •

edited

Loading

NelsonDaniel Jun 24, 2019 •

edited by idear1203

Loading

NelsonDaniel Jun 24, 2019 •

edited by idear1203

Loading

NelsonDaniel Jun 24, 2019 •

edited by idear1203

Loading

NelsonDaniel Jun 24, 2019 •

edited by idear1203

Loading

NelsonDaniel Jun 24, 2019 •

edited by idear1203

Loading

NelsonDaniel Jun 24, 2019 •

edited by idear1203

Loading

NelsonDaniel Jun 24, 2019 •

edited by idear1203

Loading

idear1203 commented Jun 26, 2019 •

edited

Loading