Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Public swagger update) Add TeradataSource,TeradataPartitionSettings,TeradataTableDataset,TeradataTableDatasetTypeProperties #6346

Merged
merged 8 commits into from
Jun 20, 2019
Merged

(Public swagger update) Add TeradataSource,TeradataPartitionSettings,TeradataTableDataset,TeradataTableDatasetTypeProperties #6346

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f756788
Modify the public swagger by reference to private swagger
Mar 14, 2019
3015288
Merge remote-tracking branch 'upstream/master'
Apr 23, 2019
2727b7c
Merge remote-tracking branch 'upstream/master'
Apr 25, 2019
047db66
Merge remote-tracking branch 'upstream/master'
May 15, 2019
1a04dc6
Merge remote-tracking branch 'upstream/master'
May 22, 2019
7e6a62e
Merge remote-tracking branch 'upstream/master'
Jun 14, 2019
d2b6a0a
add TerdateTableDataset,TeradataSource
Jun 14, 2019
0fb95a0
modify specified
Jun 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions ...factory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Dataset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,6 +1182,36 @@
}
}
},
"TeradataTableDatasetTypeProperties": {
Copy link
Member

@majastrz majastrz Jun 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teradata [](start = 5, length = 8)

I am really confused about these changes. The new definitions aren't really referenced in any paths, so this will result in no change to the API contract. Autorest might generate types for all the new definitions, but the clients won't get any new methods to utilize them.

What is the intent here? If you are planning to add paths later, will you be introducing a new API version? #Closed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that we're using discriminator value.

In reply to: 295493306 [](ancestors = 295493306)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The users know that they're expected to update to latest SDK to use newest types of data sets.

In reply to: 295580149 [](ancestors = 295580149,295493306)

"description": "Teradata dataset properties.",
"properties": {
"database": {
"type": "object",
"description": "The database name of Teradata. Type: string (or Expression with resultType string)."
},
"table": {
"type": "object",
"description": "The table name of Teradata. Type: string (or Expression with resultType string)."
}
}
},
"TeradataTableDataset": {
"x-ms-discriminator-value": "TeradataTable",
"description": "The Teradata database dataset.",
"type": "object",
Copy link
Member

@majastrz majastrz Jun 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

object [](start = 15, length = 6)

I see that you're modeling a lot of properties as object without referencing a definition. In the c# generated SDK, the property type will be object. Is that intended? How do you pass an expression via the C# SDK? What kind of expression are these also? #Closed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on a call. C# SDK has a class that users can new up and pass in for the property value. Also backend supports multiple types.

In reply to: 295494222 [](ancestors = 295494222)

"allOf": [
{
"$ref": "#/definitions/Dataset"
}
],
"properties": {
"typeProperties": {
"description": "Teradata dataset properties.",
"x-ms-client-flatten": true,
"$ref": "#/definitions/TeradataTableDatasetTypeProperties"
}
}
},
"AzureMySqlTableDataset": {
"x-ms-discriminator-value": "AzureMySqlTable",
"description": "The Azure MySQL database dataset.",
Expand Down
9 changes: 5 additions & 4 deletions ...y/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/LinkedService.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,6 +937,10 @@
"TeradataLinkedServiceTypeProperties": {
"description": "Teradata linked service properties.",
"properties": {
"connectionString": {
"description": "Teradata ODBC connection string. Type: string, SecureString or AzureKeyVaultSecretReference.",
"type": "object"
},
"server": {
"type": "object",
"description": "Server name for connection. Type: string (or Expression with resultType string)."
Expand Down Expand Up @@ -965,10 +969,7 @@
"type": "object",
"description": "The encrypted credential used for authentication. Credentials are encrypted using the integration runtime credential manager. Type: string (or Expression with resultType string)."
}
},
"required": [
"server"
]
}
},
"AzureMLLinkedService": {
"x-ms-discriminator-value": "AzureML",
Expand Down
50 changes: 50 additions & 0 deletions ...actory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1373,6 +1373,56 @@
}
}
},
"TeradataSource": {
"description": "A copy activity Teradata source.",
"type": "object",
"allOf": [
{
"$ref": "#/definitions/CopySource"
}
],
"properties": {
"query": {
"type": "object",
"description": "Teradata query. Type: string (or Expression with resultType string)."
},
"partitionOption": {
"description": "The partition mechanism that will be used for teradata read in parallel.",
"type": "object",
"enum": [
"None",
"Hash",
"DynamicRange"
],
"x-ms-enum": {
"name": "TabularPartitionOption",
"modelAsString": true
}
},
"partitionSettings": {
"description": "The settings that will be leveraged for teradata source partitioning.",
"$ref": "#/definitions/TeradataPartitionSettings"
}
}
},
"TeradataPartitionSettings": {
"description": "The settings that will be leveraged for teradata source partitioning.",
"type": "object",
"properties": {
"partitionColumnName": {
"type": "object",
"description": "The name of the column in integer type that will be used for proceeding range or hash partitioning. Type: string (or Expression with resultType string)."
},
"partitionUpperBound": {
"type": "object",
"description": "The maximum value of column specificed in partitionColumnName that will be used for proceeding range partitioning. Type: string (or Expression with resultType string)."
Yiliu-microsoft marked this conversation as resolved.
Show resolved Hide resolved
},
"partitionLowerBound": {
"type": "object",
"description": "The minimum value of column specificed in partitionColumnName that will be used for proceeding range partitioning. Type: string (or Expression with resultType string)."
Yiliu-microsoft marked this conversation as resolved.
Show resolved Hide resolved
}
}
},
"WebSource": {
"description": "A copy activity source for web page table.",
"type": "object",
Expand Down