Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datafactory] ADLS Gen 2 support for HDI BYOC and vNet support for HDI on demand #6204

Merged
merged 1 commit into from
Jun 7, 2019
Merged

[Datafactory] ADLS Gen 2 support for HDI BYOC and vNet support for HDI on demand #6204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...y/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/LinkedService.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,10 @@
"isEspEnabled": {
"type": "object",
"description": "Specify if the HDInsight is created with ESP (Enterprise Security Package). Type: Boolean."
},
"fileSystem": {
"type": "object",
"description": "Specify the FileSystem if the main storage for the HDInsight is ADLS Gen2. Type: string (or Expression with resultType string)."
}
},
"required": [
Expand Down Expand Up @@ -4406,6 +4410,14 @@
"items": {
"$ref": "#/definitions/ScriptAction"
}
},
"virtualNetworkId": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding properties within an API version, there is risk if the properties are updated by a current version client, but then the resource is modified by a down-level client. This is not strictly a breaking change, but you certainly have more control against accidental overwrite if exposed in a new API version. What is the behavior on the service if an update excludes these properties after they have been previously defined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are aware of these scenarios, and our customers also are used to these kinds of updates. We keep adding new features all the time, and they result in new properties, so adding new API version time is not feasible. The service overwrites the entities. This affects our SDK and Rest API users, but they are already aware of this, and keep getting new SDK versions when they want to use new properties. In fact, these changes are to catch up with our UX support.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks

"type": "object",
"description": "The ARM resource ID for the vNet to which the cluster should be joined after creation. Type: string (or Expression with resultType string)."
},
"subnetName": {
"type": "object",
"description": "The ARM resource ID for the subnet in the vNet. If virtualNetworkId was specified, then this property is required. Type: string (or Expression with resultType string)."
}
},
"required": [
Expand Down