Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: jsonfmt logic #6128

Merged
merged 1 commit into from
Jun 19, 2019
Merged

chore: jsonfmt logic #6128

merged 1 commit into from
Jun 19, 2019

Conversation

nschonni
Copy link
Contributor

Ran jsonfmt -w "specification/logic/**/*.json"

@azuresdkci azuresdkci requested a review from jhendrixMSFT May 28, 2019 04:57
@AutorestCI AutorestCI mentioned this pull request May 28, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented May 28, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5974

@AutorestCI
Copy link

AutorestCI commented May 28, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#4006

@AutorestCI AutorestCI mentioned this pull request May 28, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented May 28, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#3219

@AutorestCI AutorestCI mentioned this pull request May 28, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented May 28, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2656

@AutorestCI
Copy link

AutorestCI commented May 28, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5055

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request May 28, 2019
Merged
@nschonni
Copy link
Contributor Author

Adjusted the examples for the "MDN" and "NRR" casing to match the preview API, but since it's a preview api, maybe it's better to do the reverse

@jhendrixMSFT jhendrixMSFT requested a review from refortie June 3, 2019 17:01
@nschonni
chore: jsonfmt logic
37d9d68 
Ran `jsonfmt -w "specification/logic/**/*.json"`
@nschonni nschonni force-pushed the chore--jsonfmt-logic branch from 4844144 to 37d9d68 Compare June 19, 2019 20:53
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 19, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 37d9d68)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

This was referenced Jun 19, 2019
Merged
Merged
@nschonni
Copy link
Contributor Author

@jhendrixMSFT I pulled out the example changes to make this easier to land. I can submit those later

@AutorestCI AutorestCI mentioned this pull request Jun 19, 2019
Merged
@jhendrixMSFT
Copy link
Member

@nschonni thanks I was gonna suggest that but have been sidetracked with other stuff.

@nschonni
Copy link
Contributor Author

@jhendrixMSFT no worries, they didn't even resolve all the model validation issues 🤷‍♂

@jhendrixMSFT jhendrixMSFT merged commit d65e90c into Azure:master Jun 19, 2019
@nschonni nschonni deleted the chore--jsonfmt-logic branch June 19, 2019 21:12
@nschonni nschonni mentioned this pull request Jun 19, 2019
Merged
leni-msft pushed a commit to leni-msft/azure-rest-api-specs that referenced this pull request May 13, 2022
@nickweeds2
Remove TAC list (Azure#6128)
29603cc 
* Remove TAC List from 2022 API

* Make TAC List optional in 2021 API

* Microsoft.MobileNetwork ruleName and templateName must be unique

* Remove sim activation

* Add back TacList as optional in 2022 API

Co-authored-by: Sathiyan Sivathas <[email protected]>
Co-authored-by: Nick Weeds <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@refortie refortie Awaiting requested review from refortie

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nschonni @AutorestCI @azuresdkci @jhendrixMSFT