[Hub Generated] Review request for Microsoft.CostManagement to add version preview/2019-04-01-preview

[bgsky]

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[azuresdkci]

Can one of the admins verify this patch?

[AutorestCI]

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

[AutorestCI]

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2489

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5671

[AutorestCI]

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

[adxsdknet]

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6271
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@f746495
adxsdknet/azure-sdk-for-net@99f6bef
adxsdknet/azure-sdk-for-net@e87a897
adxsdknet/azure-sdk-for-net@8b9b455
adxsdknet/azure-sdk-for-net@1373d03

[bgsky]

@praries880 @ravbhatnagar @NelsonDaniel @gahorowi This PR introduces 3 APIs: view, checkNameAvailability, and budget, by merging two earlier ones, #5895 and #5881.

Please let us know if any comments to help schedule an API review meeting.

[AutorestCI]

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpe3zpd26h/rest/specification/cost-management/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmplqv0d9_2']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

[bgsky]

@ravbhatnagar @praries880 @RyanBensonMSFT Following API review with Ryan, we updated Swagger files with following changes:

1. Remove CheckNameAvailability
2. Remove batch deletion of views
3. Remove version and query version in view properties

Please let us know if any comments, as we would like it signed off to onboard manifest.

[sanjaiganesh]

@bgsky Two asks to help review this PR

1. Add description on the changes from previous api version
2. Add one iteration with old api version contents and then another iteration with new api version so that we can see the diff.. Thanks.

[bgsky]

@sanjaiganesh All the contents are new in this PR. No contents in old API version are included as there exist a few validation failures and we don't want conflicts as part of this PR.

To help understand PR, it introduces two new APIs, budget and view, following CRUD operations

[ryansbenson]

How is scope different than the Id of the resource? Your examples also just set this to empty string so I can't really follow what this is for.

No change on scope. It is part of resource id, and empty if the view is private/at tenant level. We would like scope in resource properties to pass to another resource, so it appears in response and user does not specify it in request body(included in request url). Please refer to an example of viewByResourceGroup as a use case.

[openapi-sdkautomation]

SDK Automation [Logs] (Generated from 292ab85)

Go: Azure/azure-sdk-for-go

• Package generation pending.

Python: Azure/azure-sdk-for-python

• Package generation pending.

Ruby: Azure/azure-sdk-for-ruby

• Package generation pending.

[bgsky]

@RyanBensonMSFT We updated spec and examples with the following parts:

1. Add x-ms-enum to Accumulated
2. Add no content 204 in case of deletion
3. No change on scope. It is part of resource id, and empty if the view is private/at tenant level. We would like scope in resource properties to pass to another resource, so it appears in response and user does not specify it in request body(included in request url). Please refer to an example of viewByResourceGroup as a use case.

[KrisBash]

ARM review feedback appears to be resolved. Thanks