Add managementGroups/{id}/descendants route to allow pagination of descendants #5917

daxfohl · 2019-05-10T21:53:13Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-05-10T21:53:55Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-05-10T21:54:11Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5673

AutorestCI · 2019-05-10T21:54:35Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3844

AutorestCI · 2019-05-10T21:57:34Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5026

AutorestCI · 2019-05-10T22:27:57Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3941

azuresdkci · 2019-05-10T22:31:40Z

Can one of the admins verify this patch?

REST Spec PR 'Azure/azure-rest-api-specs#5917' REST Spec PR Author 'daxfohl' REST Spec PR Last commit

adxsdknet · 2019-05-10T22:36:48Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6245
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@f54798f

daxfohl · 2019-05-13T15:14:43Z

ARM docs say to do the review before updating manifest. Here says functionality has to be available before review. Everywhere says please make sure API is approved before implementing. I'm confused.

daxfohl · 2019-05-13T15:16:50Z

Reviewing the documentation more, it seems like I should create a new api-version since it adds a new route. Is this correct?

jhendrixMSFT · 2019-05-14T17:01:15Z

You only need to create a new API version if you're introducing breaking changes which doesn't appear to be the case here.
We cannot merge this PR until the API has been deployed, however we can review it here along with ARM's review.

...ementgroups/resource-manager/Microsoft.Management/preview/2018-03-01-preview/management.json

jhendrixMSFT · 2019-05-20T21:08:37Z

@daxfohl is this API live or still waiting ARM review?

daxfohl · 2019-05-20T22:58:17Z

Still in ARM review.

…

On Mon, May 20, 2019 at 2:09 PM Joel Hendrix ***@***.***> wrote: @daxfohl <https://github.com/daxfohl> is this API live or still waiting ARM review? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5917?email_source=notifications&email_token=AAG464OTUYP66GMIFTJSE2TPWMHO7A5CNFSM4HMGOP7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV2CRAY#issuecomment-494151811>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG464KPXEYD3TLBZI7ECT3PWMHO7ANCNFSM4HMGOP7A> .

sanjaiganesh · 2019-05-31T21:25:19Z

signed off after discussing with Gaurav.

jhendrixMSFT · 2019-05-31T21:32:03Z

@daxfohl is this new endpoint live?

daxfohl · 2019-06-03T17:41:19Z

It is, but someone noticed a case sensitivity bug. So we should wait to publish it until that's fixed later this week.

…

On Fri, May 31, 2019 at 2:32 PM Joel Hendrix ***@***.***> wrote: @daxfohl <https://github.com/daxfohl> is this new endpoint live? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5917?email_source=notifications&email_token=AAG464NFXLH4JUOEKW5TSXDPYGKO3A5CNFSM4HMGOP7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWWNQQI#issuecomment-497866817>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG464NE7NIIMUMD2GOAZR3PYGKO3ANCNFSM4HMGOP7A> .

jhendrixMSFT · 2019-06-17T16:52:19Z

@daxfohl has this been resolved?

daxfohl · 2019-06-17T16:56:01Z

Yes, this can be merged now

…

On Mon, Jun 17, 2019, 9:52 AM Joel Hendrix ***@***.***> wrote: @daxfohl <https://github.com/daxfohl> has this been resolved? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5917?email_source=notifications&email_token=AAG464JJ427P2XZTEWBMG3LP266ODA5CNFSM4HMGOP7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3ZHKY#issuecomment-502764459>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG464I2736WJHDSQLA6TWTP266ODANCNFSM4HMGOP7A> .

openapi-sdkautomation · 2019-06-17T16:59:41Z

SDK Automation [Logs] (Generated from f41247d)

Python: Azure/azure-sdk-for-python

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

daxfohl added 2 commits May 10, 2019 14:48

Update management.json

cba551c

Create GetDescendants.json

3430fd9

AutorestCI mentioned this pull request May 10, 2019

[AutoPR managementgroups/resource-manager] Add managementGroups/{id}/descendants route to allow pagination of descendants Azure/azure-sdk-for-python#5182

Closed

AutorestCI mentioned this pull request May 10, 2019

[AutoPR managementgroups/resource-manager] Add managementGroups/{id}/descendants route to allow pagination of descendants Azure/azure-sdk-for-js#2814

Closed

AutorestCI mentioned this pull request May 10, 2019

[AutoPR managementgroups/resource-manager] Add managementGroups/{id}/descendants route to allow pagination of descendants Azure/azure-sdk-for-go#4774

Merged

AutorestCI mentioned this pull request May 10, 2019

[AutoPR managementgroups/resource-manager] Add managementGroups/{id}/descendants route to allow pagination of descendants Azure/azure-sdk-for-java#3622

Merged

azuresdkci assigned jhendrixMSFT May 10, 2019

azuresdkci requested a review from jhendrixMSFT May 10, 2019 22:36

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 10, 2019

.NET SDK Resource Provider:'ManagementGroups'

f54798f

REST Spec PR 'Azure/azure-rest-api-specs#5917' REST Spec PR Author 'daxfohl' REST Spec PR Last commit

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 14, 2019

jhendrixMSFT reviewed May 14, 2019

View reviewed changes

...ementgroups/resource-manager/Microsoft.Management/preview/2018-03-01-preview/management.json Outdated Show resolved Hide resolved

Reformat management.json changes for consistency.

f41247d

AutorestCI mentioned this pull request May 14, 2019

[AutoPR managementgroups/resource-manager] Add managementGroups/{id}/descendants route to allow pagination of descendants Azure/azure-sdk-for-js#2903

Closed

sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 31, 2019

jhendrixMSFT added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 6, 2019

jhendrixMSFT removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 17, 2019

jhendrixMSFT approved these changes Jun 17, 2019

View reviewed changes

jhendrixMSFT merged commit 7f48731 into Azure:master Jun 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add managementGroups/{id}/descendants route to allow pagination of descendants #5917

Add managementGroups/{id}/descendants route to allow pagination of descendants #5917

daxfohl commented May 10, 2019

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

azuresdkci commented May 10, 2019

adxsdknet commented May 10, 2019

daxfohl commented May 13, 2019

daxfohl commented May 13, 2019

jhendrixMSFT commented May 14, 2019

jhendrixMSFT commented May 20, 2019

daxfohl commented May 20, 2019 via email

sanjaiganesh commented May 31, 2019

jhendrixMSFT commented May 31, 2019

daxfohl commented Jun 3, 2019 via email

jhendrixMSFT commented Jun 17, 2019

daxfohl commented Jun 17, 2019 via email

openapi-sdkautomation bot commented Jun 17, 2019 •

edited

Loading

Add managementGroups/{id}/descendants route to allow pagination of descendants #5917

Add managementGroups/{id}/descendants route to allow pagination of descendants #5917

Conversation

daxfohl commented May 10, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented May 10, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented May 10, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 10, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented May 10, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented May 10, 2019 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented May 10, 2019

adxsdknet commented May 10, 2019

Automation for azure-sdk-for-net

daxfohl commented May 13, 2019

daxfohl commented May 13, 2019

jhendrixMSFT commented May 14, 2019

jhendrixMSFT commented May 20, 2019

daxfohl commented May 20, 2019 via email

sanjaiganesh commented May 31, 2019

jhendrixMSFT commented May 31, 2019

daxfohl commented Jun 3, 2019 via email

jhendrixMSFT commented Jun 17, 2019

daxfohl commented Jun 17, 2019 via email

openapi-sdkautomation bot commented Jun 17, 2019 • edited Loading

SDK Automation [Logs] (Generated from f41247d)

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 17, 2019 •

edited

Loading