Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: jsonfmt batch #5914

Merged
merged 2 commits into from
Jun 21, 2019
Merged

Conversation

nschonni
Copy link
Contributor

Ran jsonfmt -w "specification/batch/**/*.json"

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented May 10, 2019

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#2641

@AutorestCI
Copy link

AutorestCI commented May 10, 2019

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#5925

@AutorestCI
Copy link

AutorestCI commented May 10, 2019

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 172, in rest_handle_action
    return rest_pull_sync(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 200, in rest_pull_sync
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 257, in generate_sdk_from_git_object
    readme_files_infered = get_readme_files_from_git_object(git_object, restapi_git_folder)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkCore.py", line 146, in get_readme_files_from_git_object
    files_list = [file.filename for file in get_files(git_object)]
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkCore.py", line 146, in <listcomp>
    files_list = [file.filename for file in get_files(git_object)]
  File "/usr/local/lib/python3.6/dist-packages/github/PaginatedList.py", line 64, in __iter__
    newElements = self._grow()
  File "/usr/local/lib/python3.6/dist-packages/github/PaginatedList.py", line 76, in _grow
    newElements = self._fetchNextPage()
  File "/usr/local/lib/python3.6/dist-packages/github/PaginatedList.py", line 196, in _fetchNextPage
    headers=self.__headers
  File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 264, in requestJsonAndCheck
    return self.__check(*self.requestJson(verb, url, parameters, headers, input, self.__customConnection(url)))
  File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 275, in __check
    raise self.__createException(status, responseHeaders, output)
github.GithubException.GithubException: 502 {'message': 'Server Error'}

@AutorestCI
Copy link

AutorestCI commented May 10, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented May 10, 2019

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#3614

Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is really good, but the PR is hard to review.
I would suggest you close this PR and re-open multiple PRs for each RP separately which are easy to review and if there are any model/linter failures, it will be easy to fix them as well.

@nschonni
Copy link
Contributor Author

@shahabhijeet you can toggle the "ignore whitespace diffs" option to see the few places were it wasn't just changing the indenting. This was just an automated cleanup of the JSON files to match EditorConfig settings, so any preexisting failures would need to be fixed by the product owner

Ran `jsonfmt -w "specification/batch/**/*.json"`
@nschonni nschonni force-pushed the chore--jsonfmt-batch branch from 1f32108 to aaee3b3 Compare June 18, 2019 19:02
@nschonni nschonni requested a review from matthchr as a code owner June 18, 2019 19:02
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 18, 2019

SDK Automation [Logs] (Generated from 2e53542)

Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@nschonni nschonni requested a review from stankovski as a code owner June 18, 2019 21:16
@nschonni
Copy link
Contributor Author

@shahabhijeet ping

@nschonni
Copy link
Contributor Author

@jhendrixMSFT can you help land this?

@jhendrixMSFT jhendrixMSFT merged commit ecb759f into Azure:master Jun 21, 2019
@nschonni nschonni deleted the chore--jsonfmt-batch branch June 21, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants