-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: jsonfmt batch #5914
chore: jsonfmt batch #5914
Conversation
Can one of the admins verify this patch? |
Automation for azure-sdk-for-rubyA PR has been created for you: |
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-jsEncountered an unknown error: (azure-sdk-for-js)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 172, in rest_handle_action
return rest_pull_sync(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 200, in rest_pull_sync
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
sdk_tag=sdk_tag
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 257, in generate_sdk_from_git_object
readme_files_infered = get_readme_files_from_git_object(git_object, restapi_git_folder)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkCore.py", line 146, in get_readme_files_from_git_object
files_list = [file.filename for file in get_files(git_object)]
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkCore.py", line 146, in <listcomp>
files_list = [file.filename for file in get_files(git_object)]
File "/usr/local/lib/python3.6/dist-packages/github/PaginatedList.py", line 64, in __iter__
newElements = self._grow()
File "/usr/local/lib/python3.6/dist-packages/github/PaginatedList.py", line 76, in _grow
newElements = self._fetchNextPage()
File "/usr/local/lib/python3.6/dist-packages/github/PaginatedList.py", line 196, in _fetchNextPage
headers=self.__headers
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 264, in requestJsonAndCheck
return self.__check(*self.requestJson(verb, url, parameters, headers, input, self.__customConnection(url)))
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 275, in __check
raise self.__createException(status, responseHeaders, output)
github.GithubException.GithubException: 502 {'message': 'Server Error'} |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-javaA PR has been created for you: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is really good, but the PR is hard to review.
I would suggest you close this PR and re-open multiple PRs for each RP separately which are easy to review and if there are any model/linter failures, it will be easy to fix them as well.
@shahabhijeet you can toggle the "ignore whitespace diffs" option to see the few places were it wasn't just changing the indenting. This was just an automated cleanup of the JSON files to match EditorConfig settings, so any preexisting failures would need to be fixed by the product owner |
544aa83
to
1f32108
Compare
Ran `jsonfmt -w "specification/batch/**/*.json"`
1f32108
to
aaee3b3
Compare
SDK Automation [Logs] (Generated from 2e53542)Go: Azure/azure-sdk-for-go
JavaScript: Azure/azure-sdk-for-js
Python: Azure/azure-sdk-for-python
Java: Azure/azure-sdk-for-java
Ruby: Azure/azure-sdk-for-ruby
|
@shahabhijeet ping |
@jhendrixMSFT can you help land this? |
Ran
jsonfmt -w "specification/batch/**/*.json"