Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datafactory] Adding getFeatureValue API in factory scope #5591

Merged
merged 11 commits into from
Apr 26, 2019
Merged

[Datafactory] Adding getFeatureValue API in factory scope #5591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2130f16
Adding getFeatureValue API in factory scope
hvermis Apr 9, 2019
d7a4ff9
Updating examples for IfNoneMatch header on get calls
hvermis Apr 22, 2019
cf4d18c
Fixing example validation errors
hvermis Apr 22, 2019
d74be6a
remove ifNoneMatch=null from examples
hvermis Apr 23, 2019
33f4e80
More example validation fixes
hvermis Apr 23, 2019
5157126
One more IR example fix
hvermis Apr 23, 2019
3df9356
Deleted wrong property
hvermis Apr 23, 2019
78e7ed2
Fixing last example
hvermis Apr 23, 2019
0acb0cb
Restoring previous example
hvermis Apr 23, 2019
0c1a334
Testing example for validation
hvermis Apr 23, 2019
ac3d41b
Reverting last commit
hvermis Apr 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 55 additions & 4 deletions ...ion/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,57 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataFactory/factories/{factoryName}/getFeatureValue": {
"post": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this is replicating and existing API at another scope, but is there a reason these aren't GET requests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All our APIs are following guideline where Get is used only on items modeled as resources, and the rest are actions with POST. FeatureValues are not modeled as resources, as we don't intend to allow CRUD operations on them, and no list by parent. Validators report these as errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrisBash I replied to your comment.

"tags": [
"exposureControl"
],
"operationId": "ExposureControl_GetFeatureValueByFactory",
"x-ms-examples": {
"ExposureControl_GetFeatureValueByFactory": {
"$ref": "./examples/ExposureControl_GetFeatureValueByFactory.json"
}
},
"description": "Get exposure control feature for specific factory.",
"parameters": [
{
"$ref": "#/parameters/subscriptionId"
},
{
"$ref": "#/parameters/resourceGroupName"
},
{
"$ref": "#/parameters/factoryName"
},
{
"$ref": "#/parameters/api-version"
},
{
"name": "exposureControlRequest",
"description": "The exposure control request.",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/ExposureControlRequest"
}
}
],
"responses": {
"200": {
"description": "OK.",
"schema": {
"$ref": "#/definitions/ExposureControlResponse"
}
},
"default": {
"description": "An error response received from the Azure Data Factory service.",
"schema": {
"$ref": "#/definitions/CloudError"
}
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataFactory/factories": {
"get": {
"tags": [
Expand Down Expand Up @@ -2864,7 +2915,7 @@
],
"operationId": "RerunTriggers_Start",
"x-ms-examples": {
"Triggers_Start": {
"RerunTriggers_Start": {
"$ref": "./examples/RerunTriggers_Start.json"
}
},
Expand Down Expand Up @@ -2910,7 +2961,7 @@
],
"operationId": "RerunTriggers_Stop",
"x-ms-examples": {
"Triggers_Stop": {
"RerunTriggers_Stop": {
"$ref": "./examples/RerunTriggers_Stop.json"
}
},
Expand Down Expand Up @@ -2956,7 +3007,7 @@
],
"operationId": "RerunTriggers_Cancel",
"x-ms-examples": {
"Triggers_Cancel": {
"RerunTriggers_Cancel": {
"$ref": "./examples/RerunTriggers_Cancel.json"
}
},
Expand Down Expand Up @@ -3002,7 +3053,7 @@
],
"operationId": "RerunTriggers_ListByTrigger",
"x-ms-examples": {
"RerunTriggers_List": {
"RerunTriggers_ListByTrigger": {
"$ref": "./examples/RerunTriggers_ListByTrigger.json"
}
},
Expand Down
22 changes: 16 additions & 6 deletions ...ctory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/examples/Datasets_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,27 @@
"resourceGroupName": "exampleResourceGroup",
"factoryName": "exampleFactoryName",
"datasetName": "exampleDataset",
"ifNoneMatch": null,
"ifNoneMatch": "15004c4f-0000-0200-0000-5cbe090e0000",
"api-version": "2018-06-01"
},
"responses": {
"304": {
"headers": {
"Date": "Mon, 22 Apr 2019 18:33:50 GMT",
"X-Content-Type-Options": "nosniff",
"x-ms-ratelimit-remaining-subscription-reads": "11992",
"x-ms-request-id": "9db13e51-b9bb-4b29-89bf-2fb1636e7050",
"x-ms-correlation-request-id": "9db13e51-b9bb-4b29-89bf-2fb1636e7050"
},
"body": null
},
"200": {
"headers": {
"Date": "Sat, 16 Jun 2018 00:37:40 GMT",
"Date": "Mon, 22 Apr 2019 18:33:50 GMT",
"X-Content-Type-Options": "nosniff",
"x-ms-ratelimit-remaining-subscription-reads": "14993",
"x-ms-request-id": "19ef529d-6aac-4997-a6af-87cdc02e88c5",
"x-ms-correlation-request-id": "19ef529d-6aac-4997-a6af-87cdc02e88c5"
"x-ms-ratelimit-remaining-subscription-reads": "11993",
"x-ms-request-id": "48983fb5-612a-44c6-8158-add7ffebb32b",
"x-ms-correlation-request-id": "48983fb5-612a-44c6-8158-add7ffebb32b"
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-12345678abc/resourceGroups/exampleResourceGroup/providers/Microsoft.DataFactory/factories/exampleFactoryName/datasets/exampleDataset",
Expand Down Expand Up @@ -49,7 +59,7 @@
}
}
},
"etag": "0a0068d4-0000-0000-0000-5b245bd30000"
"etag": "15004c4f-0000-0200-0000-5cbe090e0000"
}
}
}
Expand Down
24 changes: 24 additions & 0 deletions ...soft.DataFactory/stable/2018-06-01/examples/ExposureControl_GetFeatureValueByFactory.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"parameters": {
"subscriptionId": "12345678-1234-1234-1234-12345678abc",
"resourceGroupName": "exampleResourceGroup",
"factoryName": "exampleFactoryName",
"exposureControlRequest": {
"featureName": "ADFIntegrationRuntimeSharingRbac",
"featureType": "Feature"
},
"api-version": "2018-06-01"
},
"responses": {
"200": {
"headers": {
"Date": "Sat, 22 Dec 2018 09:46:07 GMT",
"X-Content-Type-Options": "nosniff"
},
"body": {
"featureName": "ADFIntegrationRuntimeSharingRbac",
"value": "False"
}
}
}
}
11 changes: 11 additions & 0 deletions ...tory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/examples/Factories_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,20 @@
"subscriptionId": "12345678-1234-1234-1234-12345678abc",
"resourceGroupName": "exampleResourceGroup",
"factoryName": "exampleFactoryName",
"ifNoneMatch": "00004004-0000-0000-0000-5b28979e0000",
"api-version": "2018-06-01"
},
"responses": {
"304": {
"headers": {
"Date": "Mon, 22 Apr 2019 18:33:50 GMT",
"X-Content-Type-Options": "nosniff",
"x-ms-ratelimit-remaining-subscription-reads": "11992",
"x-ms-request-id": "9db13e51-b9bb-4b29-89bf-2fb1636e7050",
"x-ms-correlation-request-id": "9db13e51-b9bb-4b29-89bf-2fb1636e7050"
},
"body": null
},
"200": {
"headers": {
"Date": "Tue, 19 Jun 2018 05:41:50 GMT",
Expand Down
Loading