[Datafactory] [Do not merge] Add upgrade api #5297

leonliang33 · 2019-02-28T18:18:12Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ x ] I have reviewed the documentation for the workflow.
[ x ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ x ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azuresdkci · 2019-02-28T18:18:54Z

Can one of the admins verify this patch?

AutorestCI · 2019-02-28T18:20:03Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 16ddb0a0155b5c72d8e1baf4c90644a6bf1557cf
  stderr: 'fatal: reference is not a tree: 16ddb0a0155b5c72d8e1baf4c90644a6bf1557cf'

AutorestCI · 2019-02-28T18:23:42Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 16ddb0a0155b5c72d8e1baf4c90644a6bf1557cf
  stderr: 'fatal: reference is not a tree: 16ddb0a0155b5c72d8e1baf4c90644a6bf1557cf'

AutorestCI · 2019-02-28T18:29:22Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#4725

AutorestCI · 2019-02-28T18:46:21Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 16ddb0a0155b5c72d8e1baf4c90644a6bf1557cf
  stderr: 'fatal: reference is not a tree: 16ddb0a0155b5c72d8e1baf4c90644a6bf1557cf'

AutorestCI · 2019-02-28T20:38:11Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 16ddb0a0155b5c72d8e1baf4c90644a6bf1557cf
  stderr: 'fatal: reference is not a tree: 16ddb0a0155b5c72d8e1baf4c90644a6bf1557cf'

anuchandy · 2019-03-03T23:30:36Z

Requesting ARM review since this introduces a new api to stable API Version?
cc @KrisBash @ravbhatnagar

anuchandy · 2019-03-06T18:33:00Z

@KrisBash @ravbhatnagar could you take a look please?

sanjaiganesh · 2019-03-11T21:58:31Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+            "description": "OK.",
+            "schema": {
+              "$ref": "#/definitions/Factory"
+            }


I don't think you would like to return the resource representation here.. just 200 (OK) should be good.

@ravbhatnagar

Can you add more details on the upgrade behavior ? whether it is a one time thing, in the life cycle of a resource ?
POST can't be expressed in ARM template and is discouraged for things that customer would like to express them in declarative manner (in template).

In reply to: 264448182 [](ancestors = 264448182)

hvermis

Please do not merge these changes. It seems we do not need this API.

REST Spec PR 'Azure/azure-rest-api-specs#5297' REST Spec PR Author 'leonliang33' REST Spec PR Last commit

adxsdknet · 2019-03-12T02:36:47Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5403
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@f83f373

anuchandy · 2019-04-17T18:04:38Z

Requesting for reviewer reassign since I'm OOF

salameer · 2019-04-23T18:03:41Z

@hvermis if this is not deleted please close this PR

AutorestCI · 2019-04-23T18:04:59Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 16ddb0a0155b5c72d8e1baf4c90644a6bf1557cf
  stderr: 'fatal: reference is not a tree: 16ddb0a0155b5c72d8e1baf4c90644a6bf1557cf'

Leon Liang added 2 commits February 27, 2019 16:02

Upgrade swagger changes

01aae87

[DataFactory] Add Upgrade Swagger API

5a0a0a3

AutorestCI mentioned this pull request Feb 28, 2019

[AutoPR datafactory/resource-manager] [Datafactory] Add upgrade api Azure/azure-sdk-for-python#4458

Closed

azuresdkci assigned anuchandy Feb 28, 2019

azuresdkci requested a review from anuchandy February 28, 2019 18:20

AutorestCI mentioned this pull request Feb 28, 2019

[AutoPR datafactory/resource-manager] [Datafactory] Add upgrade api Azure/azure-sdk-for-go#4187

Closed

AutorestCI mentioned this pull request Feb 28, 2019

[AutoPR datafactory/resource-manager] [Datafactory] Add upgrade api Azure/azure-sdk-for-node#4788

Closed

AutorestCI mentioned this pull request Feb 28, 2019

[AutoPR datafactory/resource-manager] [Datafactory] Add upgrade api Azure/azure-sdk-for-js#1374

Closed

AutorestCI mentioned this pull request Feb 28, 2019

[AutoPR datafactory/resource-manager] [Datafactory] Add upgrade api Azure/azure-sdk-for-java#2989

Closed

hvermis approved these changes Feb 28, 2019

View reviewed changes

anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 3, 2019

anuchandy requested review from ravbhatnagar and KrisBash March 3, 2019 23:26

sanjaiganesh reviewed Mar 11, 2019

View reviewed changes

sanjaiganesh added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 11, 2019

hvermis requested changes Mar 12, 2019

View reviewed changes

hvermis changed the title ~~[Datafactory] Add upgrade api~~ [Datafactory] [Do not merge] Add upgrade api Mar 12, 2019

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 12, 2019

.NET SDK Resource Provider:'DataFactory'

f83f373

REST Spec PR 'Azure/azure-rest-api-specs#5297' REST Spec PR Author 'leonliang33' REST Spec PR Last commit

anuchandy added the Reassign label Apr 17, 2019

anuchandy removed their assignment Apr 17, 2019

azuresdkci assigned jhendrixMSFT Apr 17, 2019

azuresdkci requested a review from jhendrixMSFT April 17, 2019 18:20

hvermis closed this Apr 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Datafactory] [Do not merge] Add upgrade api #5297

[Datafactory] [Do not merge] Add upgrade api #5297

leonliang33 commented Feb 28, 2019

azuresdkci commented Feb 28, 2019

AutorestCI commented Feb 28, 2019 •

edited

Loading

AutorestCI commented Feb 28, 2019 •

edited

Loading

AutorestCI commented Feb 28, 2019 •

edited

Loading

AutorestCI commented Feb 28, 2019 •

edited

Loading

AutorestCI commented Feb 28, 2019 •

edited

Loading

anuchandy commented Mar 3, 2019

anuchandy commented Mar 6, 2019

sanjaiganesh Mar 11, 2019

sanjaiganesh Mar 11, 2019

sanjaiganesh Mar 12, 2019

hvermis left a comment

adxsdknet commented Mar 12, 2019

anuchandy commented Apr 17, 2019

salameer commented Apr 23, 2019

AutorestCI commented Apr 23, 2019 •

edited

Loading

[Datafactory] [Do not merge] Add upgrade api #5297

[Datafactory] [Do not merge] Add upgrade api #5297

Conversation

leonliang33 commented Feb 28, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azuresdkci commented Feb 28, 2019

AutorestCI commented Feb 28, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Feb 28, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Feb 28, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Feb 28, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Feb 28, 2019 • edited Loading

Automation for azure-sdk-for-java

anuchandy commented Mar 3, 2019

anuchandy commented Mar 6, 2019

sanjaiganesh Mar 11, 2019

Choose a reason for hiding this comment

sanjaiganesh Mar 11, 2019

Choose a reason for hiding this comment

sanjaiganesh Mar 12, 2019

Choose a reason for hiding this comment

hvermis left a comment

Choose a reason for hiding this comment

adxsdknet commented Mar 12, 2019

Automation for azure-sdk-for-net

anuchandy commented Apr 17, 2019

salameer commented Apr 23, 2019

AutorestCI commented Apr 23, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Feb 28, 2019 •

edited

Loading

AutorestCI commented Feb 28, 2019 •

edited

Loading

AutorestCI commented Feb 28, 2019 •

edited

Loading

AutorestCI commented Feb 28, 2019 •

edited

Loading

AutorestCI commented Feb 28, 2019 •

edited

Loading

AutorestCI commented Apr 23, 2019 •

edited

Loading