Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove enum from catalogPricingTier #5278

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Remove enum from catalogPricingTier #5278

merged 2 commits into from
Mar 25, 2019

Conversation

zhangyd2015
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Feb 27, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Feb 27, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Feb 27, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4381

@AutorestCI AutorestCI mentioned this pull request Feb 27, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Feb 27, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4379

@AutorestCI
Copy link

AutorestCI commented Feb 27, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3084

@AutorestCI AutorestCI mentioned this pull request Feb 27, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Feb 27, 2019 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#5048

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Feb 27, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1769

@jianghaolu
Copy link
Contributor

What's the reason for this change? How can customers discover what string to provide?

@zhangyd2015
Copy link
Contributor Author

What's the reason for this change? How can customers discover what string to provide?

This is actually a increasing list which comes from Azure SQL database. If we make it enum here, we need to update the list from time to time, so we decided to just change it to string and document it with a link from Azure SQL Database site. The current enum list is actually incorrect and out of date.

jianghaolu
jianghaolu suggested changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@jianghaolu jianghaolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay and thanks for the explanation.

You can keep the changes for the preview spec but you cannot change the stable spec. You will have to include this breaking change in the next API version update.

...resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/IntegrationRuntime.json Outdated
"name": "IntegrationRuntimeSsisCatalogPricingTier",
"modelAsString": true
}
"type": "string"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not allowed though. This is a stable API version so no breaking changes can be introduced.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianghaolu I revoked the changes in stable API version.

This was referenced Mar 13, 2019
Merged
Closed
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 13, 2019
@adxsdknet
.NET SDK Resource Provider:'DataFactory'
9841433 
REST Spec PR 'Azure/azure-rest-api-specs#5278'
REST Spec PR Author 'zhangyd2015'
REST Spec PR Last commit
@adxsdknet
Copy link

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5428
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@9841433

@zhangyd2015
Copy link
Contributor Author

@jianghaolu Could you please merge this PR if there is no further comments? Thanks.

@jianghaolu jianghaolu merged commit 9322b36 into Azure:master Mar 25, 2019
This was referenced Mar 25, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianghaolu jianghaolu jianghaolu approved these changes

@hvermis hvermis hvermis approved these changes

Assignees

@jianghaolu jianghaolu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhangyd2015 @AutorestCI @azuresdkci @jianghaolu @adxsdknet @hvermis