Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swagger to add target and credentials flag to the requests, and add examples. #5047

Merged
merged 13 commits into from
Jan 17, 2019
Merged

Update swagger to add target and credentials flag to the requests, and add examples. #5047

merged 13 commits into from
Jan 17, 2019

Conversation

shahzzzam
Copy link
Contributor

@shahzzzam shahzzzam commented Jan 16, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI AutorestCI mentioned this pull request Jan 16, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 16, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#948

@shahzzzam shahzzzam changed the title Add target and credentials flag to the requests. Update swagger to add target and credentials flag to the requests, and add examples. Jan 16, 2019
@AutorestCI AutorestCI mentioned this pull request Jan 16, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 16, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4206

@AutorestCI AutorestCI mentioned this pull request Jan 16, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 16, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2164

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

jhendrixMSFT
jhendrixMSFT requested changes Jan 16, 2019
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the indentation so it matches the original? The diff is extremely noisy.

@AutorestCI AutorestCI mentioned this pull request Jan 16, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jan 16, 2019 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4566

@AutorestCI AutorestCI mentioned this pull request Jan 16, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 16, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2460

@shahzzzam
Copy link
Contributor Author

Can you please fix the indentation so it matches the original? The diff is extremely noisy.

Yes, I am working on that

@AutorestCI AutorestCI mentioned this pull request Jan 16, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jan 16, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3904

@shahzzzam
Copy link
Contributor Author

Can you please fix the indentation so it matches the original? The diff is extremely noisy.

This has been fixed

@shahzzzam shahzzzam closed this Jan 16, 2019
@shahzzzam shahzzzam reopened this Jan 16, 2019
@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

This was referenced Jan 16, 2019
Merged
Merged
@shahzzzam
Copy link
Contributor Author

Can you please fix the indentation so it matches the original? The diff is extremely noisy.

This is fixed, @jhendrixMSFT

@shahzzzam
Copy link
Contributor Author

@jhendrixMSFT it seems I cannot resolve one of your reviews about indentation. Can you resolve it on your end? Seems like all the comments were addressed

@jhendrixMSFT
Copy link
Member

@shahzzzam no worries it looks good. Are these features live in production?

@shahzzzam
Copy link
Contributor Author

shahzzzam commented Jan 17, 2019 •
edited
Loading

@jhendrixMSFT Yes they are, just need to add them to CLI now

@jhendrixMSFT jhendrixMSFT merged commit 2149912 into Azure:master Jan 17, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@shahzzzam @AnuTalluri
Update swagger to add target and credentials flag to the requests, an…
88ab3c7 
…d add examples. (Azure#5047)

* Add target and credential flags to the Request

* Add target and credential flags to the Request

* Add two examples for CustomCredentials as well as target

* fix indentation

* fix spelling mistakes

* vaule to value

* update status code order

* remove gets or sets from description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shahzzzam @AutorestCI @azuresdkci @jhendrixMSFT @nschonni