Fix errors in old Network API version #4940

anton-evseev · 2018-12-18T10:40:06Z

Fixed validation errors:

OBJECT_MISSING_REQUIRED_PROPERTY_DEFINITION
- Remove property nextHopType from required as there was no such property in definition
EQUIVALENT_PATH
- Put get and put under one path

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azuresdkci · 2018-12-18T10:41:48Z

Can one of the admins verify this patch?

AutorestCI · 2018-12-18T10:45:09Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#904

AutorestCI · 2018-12-18T10:47:03Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2125

AutorestCI · 2018-12-18T10:54:17Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

AutorestCI · 2018-12-18T11:17:39Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#3812

AutorestCI · 2018-12-18T11:34:06Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4516

AutorestCI · 2018-12-18T11:37:32Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2591

jianghaolu · 2018-12-19T19:25:06Z

specification/network/resource-manager/Microsoft.Network/stable/2016-03-30/network.json

@@ -3282,45 +3282,6 @@
        "x-ms-long-running-operation": true
      }
    },
-    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/connections/{connectionSharedKeyName}/sharedkey": {


Why breaking this functionality in the old api version?

it's not breaking, there are two duplicate paths in old specs, one with PUT and one with GET, so I'm moving them under one entry

I see! Then it's fine

jianghaolu · 2019-01-04T01:12:25Z

Sorry I missed your comment during the holidays. Please reopen and target january-network-release and assign to me. Thanks!

MikhailTryakhov · 2019-01-04T06:41:16Z

@jianghaolu it need to be merged ASAP. In master in this case. Please remove january-network-release - I create branches myself :)

openapi-portal-comment · 2019-01-04T06:41:17Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

anton-evseev · 2019-01-07T07:14:35Z

@jianghaolu @MikhailTryakhov rebased PR against master, please take a look

MikhailTryakhov · 2019-01-07T22:34:56Z

@number213 please merge it to january branch as well

nschonni · 2019-01-08T04:50:05Z

Looks like this issue might be in the 2015-06-15 files as well https://travis-ci.org/Azure/azure-rest-api-specs/jobs/476680029#L690-L706

anton-evseev · 2019-01-08T08:06:48Z

Nick's right, I missed one API version. Opened PR for it: #5002
Also, ported those changes to January branch: #5003

anton-evseev requested a review from MikhailTryakhov as a code owner December 18, 2018 10:40

kpajdzik added the review label Dec 18, 2018

azuresdkci assigned jianghaolu Dec 18, 2018

azuresdkci requested a review from jianghaolu December 18, 2018 10:41

AutorestCI mentioned this pull request Dec 18, 2018

[AutoPR network/resource-manager] Fix errors in old Network API version Azure/azure-sdk-for-ruby#2098

Closed

anton-evseev mentioned this pull request Dec 18, 2018

fix: network/resource-manager/Microsoft.Network #4648

Closed

AutorestCI mentioned this pull request Dec 18, 2018

[AutoPR network/resource-manager] Fix errors in old Network API version Azure/azure-sdk-for-go#3755

Closed

jianghaolu reviewed Dec 19, 2018

View reviewed changes

jianghaolu closed this Jan 4, 2019

kpajdzik removed the review label Jan 4, 2019

MikhailTryakhov changed the base branch from december-network-release to master January 4, 2019 06:40

MikhailTryakhov reopened this Jan 4, 2019

kpajdzik added the review label Jan 4, 2019

Fix errors in old Network API version

a21a314

anton-evseev force-pushed the old-vpngw-fix branch from e4fa730 to a21a314 Compare January 7, 2019 06:19

AutorestCI mentioned this pull request Jan 7, 2019

[AutoPR network/resource-manager] Fix errors in old Network API version Azure/azure-sdk-for-java#2821

Merged

jianghaolu approved these changes Jan 7, 2019

View reviewed changes

jianghaolu merged commit 63a1143 into Azure:master Jan 7, 2019

kpajdzik removed the review label Jan 7, 2019

AutorestCI mentioned this pull request Jan 7, 2019

[AutoPR network/resource-manager] Fix errors in old Network API version Azure/azure-sdk-for-go#3811

Merged

anton-evseev deleted the old-vpngw-fix branch January 8, 2019 07:30

This was referenced Jan 8, 2019

Fix duplicate path in old Network API version #5002

Merged

Fix duplicate path in old Network API versions (Network January branch) #5003

Merged

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019

Fix errors in old Network API version (Azure#4940)

3a49501

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

Adding landing URL in environmentInfo (#4940)

2a10cf5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix errors in old Network API version #4940

Fix errors in old Network API version #4940

anton-evseev commented Dec 18, 2018

azuresdkci commented Dec 18, 2018

AutorestCI commented Dec 18, 2018 •

edited

Loading

AutorestCI commented Dec 18, 2018 •

edited

Loading

AutorestCI commented Dec 18, 2018 •

edited

Loading

AutorestCI commented Dec 18, 2018 •

edited

Loading

AutorestCI commented Dec 18, 2018 •

edited

Loading

AutorestCI commented Dec 18, 2018 •

edited

Loading

jianghaolu Dec 19, 2018

anton-evseev Dec 25, 2018

jianghaolu Jan 4, 2019

jianghaolu commented Jan 4, 2019

MikhailTryakhov commented Jan 4, 2019

openapi-portal-comment bot commented Jan 4, 2019

anton-evseev commented Jan 7, 2019

MikhailTryakhov commented Jan 7, 2019

nschonni commented Jan 8, 2019

anton-evseev commented Jan 8, 2019

Fix errors in old Network API version #4940

Fix errors in old Network API version #4940

Conversation

anton-evseev commented Dec 18, 2018

Contribution checklist:

ARM API Review Checklist

azuresdkci commented Dec 18, 2018

AutorestCI commented Dec 18, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Dec 18, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Dec 18, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Dec 18, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Dec 18, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Dec 18, 2018 • edited Loading

Automation for azure-sdk-for-java

jianghaolu Dec 19, 2018

Choose a reason for hiding this comment

anton-evseev Dec 25, 2018

Choose a reason for hiding this comment

jianghaolu Jan 4, 2019

Choose a reason for hiding this comment

jianghaolu commented Jan 4, 2019

MikhailTryakhov commented Jan 4, 2019

openapi-portal-comment bot commented Jan 4, 2019

anton-evseev commented Jan 7, 2019

MikhailTryakhov commented Jan 7, 2019

nschonni commented Jan 8, 2019

anton-evseev commented Jan 8, 2019

AutorestCI commented Dec 18, 2018 •

edited

Loading

AutorestCI commented Dec 18, 2018 •

edited

Loading

AutorestCI commented Dec 18, 2018 •

edited

Loading

AutorestCI commented Dec 18, 2018 •

edited

Loading

AutorestCI commented Dec 18, 2018 •

edited

Loading

AutorestCI commented Dec 18, 2018 •

edited

Loading