Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACR] Add IP rules #4895

Merged
merged 3 commits into from
Dec 12, 2018
Merged

[ACR] Add IP rules #4895

merged 3 commits into from
Dec 12, 2018

Conversation

djyou
Copy link
Member

@djyou djyou commented Dec 11, 2018 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI AutorestCI mentioned this pull request Dec 11, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4052

@azuresdkci azuresdkci requested a review from anuchandy December 11, 2018 23:00
@AutorestCI AutorestCI mentioned this pull request Dec 11, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1980

@AutorestCI AutorestCI mentioned this pull request Dec 11, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4232

@AutorestCI AutorestCI mentioned this pull request Dec 11, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3692

@AutorestCI AutorestCI mentioned this pull request Dec 11, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2460

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@djyou
Copy link
Member Author

djyou commented Dec 11, 2018

This is a subsequent PR of #4506

As requested by Azure Network Team, we have to support IP rules together with virtual network rules to ship this feature.

@ravbhatnagar As agreed earlier with this issue #4625 Adding these properties won't be a breaking change to this api-version. We will release a new api-version (presumably 2019-02-01) to follow the exact pattern suggested by ARM.

/cc @mnltejaswini @sajayantony

@anuchandy anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 11, 2018
@anuchandy
Copy link
Member

@ravbhatnagar please sign-off

anuchandy
anuchandy approved these changes Dec 11, 2018
View reviewed changes
...gistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json Outdated
},
"value": {
"description": "Specifies the IP or IP range in CIDR format. Only IPV4 address is allowed.",
"type": "string"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would be useful to apply following attribute

"x-ms-client-name": "IPAddressOrRange"

that way generated code is consistent with the same feature from other service? e.g. here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@AutorestCI AutorestCI mentioned this pull request Dec 11, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#623

@ravbhatnagar
Copy link
Contributor

Signing off from ARM side as we already have an issue to track the PUT behavior.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 12, 2018
@anuchandy anuchandy merged commit 7d6b139 into Azure:master Dec 12, 2018
@kpajdzik kpajdzik removed the review label Dec 12, 2018
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@djyou @AnuTalluri
[ACR] Add IP rules (Azure#4895)
66f7410 
* Add IP rules

* Remove chart actions

* Add x-ms-client-name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy approved these changes

@ravbhatnagar ravbhatnagar Awaiting requested review from ravbhatnagar

Assignees

@anuchandy anuchandy

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@djyou @AutorestCI @azuresdkci @anuchandy @ravbhatnagar @kpajdzik