typo: servicefabric/resource-manager/Microsoft.ServiceFabric #4529

nschonni · 2018-11-21T03:27:15Z

specificed -> specified
sucessful -> successful
resturns -> returns
commited -> committed
dataloss -> data loss
Double word "with"
applciation -> application
ABRIC -> FABRIC
resouce -> resource
mininum -> minimum
Double word "maximum"
revent -> prevent
empheral -> ephemeral
exmaple -> example
assgined -> assigned
carefull -> careful
primay -> primary
Dispaly -> Display
skus -> SKUs

If the values in x-ms-examples are breaking, I can rebase those out

openapi-portal-comment · 2018-11-21T03:27:16Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-11-21T03:27:39Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5063

AutorestCI · 2018-11-21T03:27:46Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2018-11-21T03:27:47Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5997

AutorestCI · 2018-11-21T03:28:02Z

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: ['/usr/local/bin/autorest', '/tmp/tmpfq07iqnd/rest/specification/servicefabric/resource-manager/readme.md', '--multiapi', '--ruby', '--ruby-sdks-folder=/tmp/tmpfq07iqnd/sdk', '[email protected]/autorest.ruby@preview', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4384)
   Loading AutoRest extension '@microsoft.azure/autorest.ruby' (preview->3.1.40)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.1.22->2.1.22)
Processing batch task - {"tag":"package-2019-03"} .
Processing batch task - {"tag":"package-2018-02"} .
FATAL: System.NullReferenceException: CodeModel doesn't have api-version set, specs in code model have mismatching api-versions.
   at AutoRest.Ruby.Azure.CodeGeneratorRba.<Generate>d__6.MoveNext() in /opt/vsts/work/1/s/src/azure/CodeGeneratorRba.cs:line 52
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Ruby.Program.<ProcessInternal>d__4.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 118
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.<Process>d__20.MoveNext() in /opt/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: ruby/generate - FAILED
FATAL: Error: Plugin ruby reported failure.
Process() cancelled due to exception : Plugin ruby reported failure.
Failure during batch task - {"tag":"package-2018-02"} -- Error: Plugin ruby reported failure..
  Error: Plugin ruby reported failure.

azuresdkci · 2018-11-21T03:29:23Z

Can one of the admins verify this patch?

AutorestCI · 2018-11-21T03:38:33Z

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmp9suipgfl/rest/specification/servicefabric/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmp9suipgfl/azure-sdk-for-node', '--nodejs', '[email protected]/[email protected]']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (2.2.131->2.2.131)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmp9suipgfl/rest/specification/servicefabric/resource-manager/Microsoft.ServiceFabric/preview/2017-07-01-preview/application.json:973:4 ($.definitions.ApplicationHealthPolicy)
    - file:///tmp/tmp9suipgfl/rest/specification/servicefabric/resource-manager/Microsoft.ServiceFabric/stable/2018-02-01/cluster.json:534:4 ($.definitions.ApplicationHealthPolicy)
Process() cancelled due to exception : Cancellation requested.
  Cancellation requested.

AutorestCI · 2018-11-21T03:40:17Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3731

openapi-portal-comment · 2018-11-26T17:24:40Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

openapi-portal-comment · 2018-11-30T19:47:54Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

nschonni · 2019-03-26T22:09:44Z

@juhacket any idea why the build is failing?

salameer · 2019-04-04T18:40:01Z

Hi @anuchandy

What's the status here? are these changes impacting the Main Swagger or is it only related to documentation

salameer · 2019-04-23T21:04:12Z

@vipul-modi

@nschonni is an awesome external contributer that provided these fixes to the swagger comments maily for Service fabric, would you kindly mind reviewing or tagging someone who can review?

salameer · 2019-04-25T19:39:51Z

@amanbha can you kindly review here?

nschonni · 2019-05-20T20:51:15Z

@salameer this got approved. I rebased just to get the latest checks, but the failures are pre-existing

- specificed -> specified - sucessful -> successful - resturns -> returns - commited -> committed - dataloss -> data loss - Double word "with" - applciation -> application - ABRIC -> FABRIC - resouce -> resource - mininum -> minimum - Double word "maximum" - revent -> prevent - empheral -> ephemeral - exmaple -> example - assgined -> assigned - carefull -> careful - primay -> primary - Dispaly -> Display - skus -> SKUs

openapi-sdkautomation · 2019-06-06T20:14:01Z

SDK Automation [Logs] (Generated from 6680c1b)

Python: Azure/azure-sdk-for-python

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

Ruby: Azure/azure-sdk-for-ruby

Package generation pending.

nschonni · 2019-06-06T20:22:37Z

@sergey-shandar is the "ReadOnly" rule in model validation expected to fail on older APIs?

nschonni · 2019-06-20T20:57:59Z

@jhendrixMSFT can you help land this?

azuresdkci assigned anuchandy Nov 21, 2018

azuresdkci requested a review from anuchandy November 21, 2018 03:27

AutorestCI mentioned this pull request Nov 21, 2018

[AutoPR servicefabric/resource-manager] servicefabric/resource-manager/Microsoft.ServiceFabric/servicefabric Azure/azure-sdk-for-java#2633

Closed

nschonni changed the title ~~servicefabric/resource-manager/Microsoft.ServiceFabric/servicefabric~~ typo: servicefabric/resource-manager/Microsoft.ServiceFabric/servicefabric Nov 21, 2018

nschonni closed this Nov 26, 2018

nschonni reopened this Nov 26, 2018

nschonni force-pushed the typo-servicefabric/resource-manager/Microsoft.ServiceFabric/servicefabric branch from dd14d41 to d35e0f7 Compare November 29, 2018 02:14

nschonni changed the title ~~typo: servicefabric/resource-manager/Microsoft.ServiceFabric/servicefabric~~ typo: Microsoft.ServiceFabric Nov 29, 2018

nschonni force-pushed the typo-servicefabric/resource-manager/Microsoft.ServiceFabric/servicefabric branch from d35e0f7 to 19f0265 Compare November 29, 2018 02:16

nschonni closed this Nov 30, 2018

nschonni reopened this Nov 30, 2018

This was referenced Nov 30, 2018

[AutoPR servicefabric/resource-manager/servicefabric/data-plane] typo: Microsoft.ServiceFabric Azure/azure-sdk-for-js#624

Closed

[AutoPR servicefabric/resource-manager/servicefabric/data-plane] typo: Microsoft.ServiceFabric Azure/azure-sdk-for-java#2674

Closed

nschonni force-pushed the typo-servicefabric/resource-manager/Microsoft.ServiceFabric/servicefabric branch from 19f0265 to 6f40b1d Compare December 5, 2018 06:05

AutorestCI mentioned this pull request Dec 5, 2018

[AutoPR servicefabric/resource-manager] typo: Microsoft.ServiceFabric Azure/azure-sdk-for-java#2739

Closed

nschonni changed the title ~~typo: Microsoft.ServiceFabric~~ typo: servicefabric/resource-manager/Microsoft.ServiceFabric Dec 11, 2018

nschonni closed this Dec 13, 2018

nschonni reopened this Dec 13, 2018

nschonni force-pushed the typo-servicefabric/resource-manager/Microsoft.ServiceFabric/servicefabric branch 3 times, most recently from 46678fd to 2eb3c25 Compare April 12, 2019 17:20

salameer requested review from amanbha and removed request for anuchandy April 25, 2019 19:39

amanbha approved these changes Apr 25, 2019

View reviewed changes

nschonni force-pushed the typo-servicefabric/resource-manager/Microsoft.ServiceFabric/servicefabric branch from 2eb3c25 to 9122a02 Compare May 20, 2019 20:45

nschonni force-pushed the typo-servicefabric/resource-manager/Microsoft.ServiceFabric/servicefabric branch from 9122a02 to 3196659 Compare May 24, 2019 17:42

AutorestCI mentioned this pull request May 24, 2019

[AutoPR servicefabric/resource-manager] typo: servicefabric/resource-manager/Microsoft.ServiceFabric Azure/azure-sdk-for-go#4871

Closed

nschonni force-pushed the typo-servicefabric/resource-manager/Microsoft.ServiceFabric/servicefabric branch from 3196659 to 6680c1b Compare June 6, 2019 20:13

nschonni requested a review from samedder as a code owner June 6, 2019 20:13

AutorestCI mentioned this pull request Jun 6, 2019

[AutoPR servicefabric/resource-manager] typo: servicefabric/resource-manager/Microsoft.ServiceFabric Azure/azure-sdk-for-python#5724

Closed

jhendrixMSFT closed this Jun 20, 2019

jhendrixMSFT reopened this Jun 20, 2019

jhendrixMSFT approved these changes Jun 20, 2019

View reviewed changes

jhendrixMSFT merged commit f90d70f into Azure:master Jun 20, 2019

nschonni deleted the typo-servicefabric/resource-manager/Microsoft.ServiceFabric/servicefabric branch June 20, 2019 21:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

typo: servicefabric/resource-manager/Microsoft.ServiceFabric #4529

typo: servicefabric/resource-manager/Microsoft.ServiceFabric #4529

nschonni commented Nov 21, 2018 •

edited

Loading

openapi-portal-comment bot commented Nov 21, 2018

AutorestCI commented Nov 21, 2018 •

edited

Loading

AutorestCI commented Nov 21, 2018 •

edited

Loading

AutorestCI commented Nov 21, 2018 •

edited

Loading

AutorestCI commented Nov 21, 2018 •

edited

Loading

azuresdkci commented Nov 21, 2018

AutorestCI commented Nov 21, 2018 •

edited

Loading

AutorestCI commented Nov 21, 2018 •

edited

Loading

openapi-portal-comment bot commented Nov 26, 2018

openapi-portal-comment bot commented Nov 30, 2018

nschonni commented Mar 26, 2019

salameer commented Apr 4, 2019

salameer commented Apr 23, 2019

salameer commented Apr 25, 2019

nschonni commented May 20, 2019

openapi-sdkautomation bot commented Jun 6, 2019 •

edited

Loading

nschonni commented Jun 6, 2019

nschonni commented Jun 20, 2019

typo: servicefabric/resource-manager/Microsoft.ServiceFabric #4529

typo: servicefabric/resource-manager/Microsoft.ServiceFabric #4529

Conversation

nschonni commented Nov 21, 2018 • edited Loading

openapi-portal-comment bot commented Nov 21, 2018

AutorestCI commented Nov 21, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Nov 21, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Nov 21, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Nov 21, 2018 • edited Loading

Automation for azure-sdk-for-ruby

azuresdkci commented Nov 21, 2018

AutorestCI commented Nov 21, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Nov 21, 2018 • edited Loading

Automation for azure-sdk-for-java

openapi-portal-comment bot commented Nov 26, 2018

openapi-portal-comment bot commented Nov 30, 2018

nschonni commented Mar 26, 2019

salameer commented Apr 4, 2019

salameer commented Apr 23, 2019

salameer commented Apr 25, 2019

nschonni commented May 20, 2019

openapi-sdkautomation bot commented Jun 6, 2019 • edited Loading

SDK Automation [Logs] (Generated from 6680c1b)

nschonni commented Jun 6, 2019

nschonni commented Jun 20, 2019

nschonni commented Nov 21, 2018 •

edited

Loading

AutorestCI commented Nov 21, 2018 •

edited

Loading

AutorestCI commented Nov 21, 2018 •

edited

Loading

AutorestCI commented Nov 21, 2018 •

edited

Loading

AutorestCI commented Nov 21, 2018 •

edited

Loading

AutorestCI commented Nov 21, 2018 •

edited

Loading

AutorestCI commented Nov 21, 2018 •

edited

Loading

openapi-sdkautomation bot commented Jun 6, 2019 •

edited

Loading