Add serverSecurityAlertPolicies APIs for MySQL servers #3644
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
|
Can one of the admins verify this patch? |
anuchandy
added
the
WaitForARMFeedback
There was a problem hiding this comment.
@ravbhatnagar please review the part referring storage account. Looks good from SDK side.
| "enum": [ | ||
| "default" | ||
| ], | ||
| "x-ms-parameter-location": "method" |
There was a problem hiding this comment.
It seems this definition is not used anywhere if so please remove it.
| "storageAccountAccessKey": { | ||
| "description": "Specifies the identifier key of the Threat Detection audit storage account.", | ||
| "type": "string" | ||
| }, |
There was a problem hiding this comment.
My understanding is ARM usually recommend to refer storage account using the fully qualified ARM resource id. This requires service to have linked access to storage that way service can reliably ensure there are sufficient permission to perform the operation (such as reading keys). Adding @ravbhatnagar from ARM team to comment.
There was a problem hiding this comment.
It is similar in all our APIs for Postgres, SQL and Managed Instance
https://github.com/Azure/azure-rest-api-specs/pull/2947/files
|
@ravbhatnagar please review |
|
@ayeletshpigelman whats your contact email? need to start an email thread with ARM with you in loop. |
| @@ -1062,6 +1062,126 @@ | |||
| } | |||
| } | |||
| }, | |||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/servers/{serverName}/securityAlertPolicies/{securityAlertPolicyName}": { | |||
There was a problem hiding this comment.
Should there be an API to list the collection of securityPOlicies under a server.
There was a problem hiding this comment.
There is only one policy, but the user can define its name.
|
@anuchandy can you please merge the pull request |
anuchandy
added
ARMSignedOff
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger