Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2 storage linked service type: AzureBlobStorage, AzureTableStorage and support aad auth for AzureBlobStorage #3331

Merged
merged 2 commits into from
Aug 1, 2018

Conversation

ligengatms
Copy link
Contributor

@ligengatms ligengatms commented Jun 29, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jun 29, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 29, 2018

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2293

@AutorestCI
Copy link

AutorestCI commented Jun 29, 2018

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2770

@AutorestCI
Copy link

AutorestCI commented Jun 29, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

@AutorestCI
Copy link

AutorestCI commented Jun 29, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2362

@ligengatms
Copy link
Contributor Author

I'm still waiting for backend service Production deploy, please wait for my signal before merge into master, thx

@hovsepm hovsepm added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 29, 2018
@hovsepm
Copy link
Contributor

hovsepm commented Jun 29, 2018

@ligengatms please ping me directly via IM or email when this PR will be ready to merge.

@hovsepm
Copy link
Contributor

hovsepm commented Jun 29, 2018

      "type": "object",

all these fields are of type string according to the description - why are then not modeled as "type": "string"?


Refers to: specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/LinkedService.json:117 in 9f225ae. [](commit_id = 9f225ae, deletion_comment = False)

@ligengatms
Copy link
Contributor Author

@hovsepm thank you for the help, I'll send you by mail when we're ready to merged. And for your comments, connectionString as the description said it may be string, secureString, depends on customer input, that's why we set it to object; and for sasUri it's also secret, so it's type is SecretBase which is defined in datafactory.json; for encryptedCredential, you are right, i'm changing it to string, thanks for pointing it out.

@ligengatms ligengatms closed this Jul 2, 2018
@ligengatms ligengatms reopened this Jul 2, 2018
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants