-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 2 storage linked service type: AzureBlobStorage, AzureTableStorage and support aad auth for AzureBlobStorage #3331
Conversation
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-nodeA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
I'm still waiting for backend service Production deploy, please wait for my signal before merge into master, thx |
@ligengatms please ping me directly via IM or email when this PR will be ready to merge. |
all these fields are of type string according to the description - why are then not modeled as "type": "string"? Refers to: specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/LinkedService.json:117 in 9f225ae. [](commit_id = 9f225ae, deletion_comment = False) |
@hovsepm thank you for the help, I'll send you by mail when we're ready to merged. And for your comments, connectionString as the description said it may be string, secureString, depends on customer input, that's why we set it to object; and for sasUri it's also secret, so it's type is SecretBase which is defined in datafactory.json; for encryptedCredential, you are right, i'm changing it to string, thanks for pointing it out. |
@AutorestCI regenerate azure-sdk-for-go |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger