Fixes for linting errors on gateway resources

[yushwang]

(1) wrong resource name
(2) wrong resource reference in the reponse
(3) missing SubResource reference

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • [] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-libraries-for-java

Encountered a Subprocess error: (azure-libraries-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmp6s1yftz_/rest/specification/network/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmp6s1yftz_/sdk', '--fluent', '--java', '--multiapi', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4280).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (~2.1.32->2.1.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Shutting Down
Shutting Down
FATAL: java/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.java' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.java' terminated.

[AutorestCI]

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpah8xqnvd/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpah8xqnvd/sdk', '--nodejs', '[email protected]/autorest.nodejs@^2.1.43']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4280).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (^2.1.43->2.1.59)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Shutting Down

[AutorestCI]

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

[AutorestCI]

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

[AutorestCI]

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

[veronicagg]

PR looks good.
@sergey-shandar is looking into the CI issue with the PR, external to this change.
I've labeled the PR with potential-SDK-breaking-changes, since the name change on the reference will cause that.
If you need approval from ARM for a linter violation, please follow up with @ravbhatnagar .

[sergey-shandar]

CI is fixed, There are still some problems with examples.

[sergey-shandar]

@ravbhatnagar breaking changes in stable API. AFAIK, the old spec didn't properly describe the service API.

[MikhailTryakhov]

Need approval from ARM side to have it merged

[dsgouda]

@sergey-shandar @veronicagg if the service was incorrectly described in the swagger, the service itself hasn't changed only the spec is being changed here. This will cause breaking changes to the generated sdks but that is acceptable if I am not wrong.
Do we still need @ravbhatnagar 's approval here?

[veronicagg]

@dsgouda since there were ARM violations @yushwang was already talking to @ravbhatnagar about them. If ARM team does not reply in the next 24 hours and owners of the PR want it to be merged anyway, you can merge without ARM's explicit approval.

[ravbhatnagar]

Looks good!

[MikhailTryakhov]

@dsgouda approval received

[sergey-shandar]

@dsgouda I think, we still need ARM approval. At least, ARM team is aware about these changes.