Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

Azure / azure-rest-api-specs Public

Notifications You must be signed in to change notification settings
Fork 5.2k
Star 2.7k

Code
Issues 1.8k
Pull requests 805
Discussions
Actions
Projects
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Change the Management policy example per feature PM request #3217

Merged

sergey-shandar merged 1 commit into Azure:master from blueww:managepolicy

Jun 12, 2018

Merged

[Storage] Change the Management policy example per feature PM request #3217

sergey-shandar merged 1 commit into Azure:master from blueww:managepolicy

Jun 12, 2018

Conversation 5 Commits 1 Checks 0 Files changed

Conversation

Copy link

Member

blueww commented Jun 12, 2018 •

edited

Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

We just have a PR #3197 changed the example. Per the PM request, just need another change.
The change is simple, just change 3 number in the example.

Following is the request from feature PM:

We can’t delete any blob with snapshots. So snapshot should be deleted before blob deletion, which means the snapshot delete days number should be smaller than the blob delete days (so instead of 5000, make it something like 30). I don’ think we should block the publishing of the current set. But I would like to update this as soon as possible. Can you make the update?

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Sorry, something went wrong.

All reactions


          [Storage] change the Management policy example per feature PM request

c4a766f

Copy link

AutorestCI commented Jun 12, 2018 •

edited

Loading

Automation for azure-libraries-for-java

Unable to detect any generation context from this PR.

All reactions

Sorry, something went wrong.

blueww changed the title ~~[Storage] cange the Management policy example per feature PM request~~ [Storage] Change the Management policy example per feature PM request

azuresdkci assigned sergey-shandar

azuresdkci requested a review from sergey-shandar

June 12, 2018 06:40

Copy link

AutorestCI commented Jun 12, 2018 •

edited

Loading

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

All reactions

Sorry, something went wrong.

Copy link

AutorestCI commented Jun 12, 2018 •

edited

Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

All reactions

Sorry, something went wrong.

Copy link

AutorestCI commented Jun 12, 2018 •

edited

Loading

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

All reactions

Sorry, something went wrong.

Copy link

AutorestCI commented Jun 12, 2018 •

edited

Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

All reactions

Sorry, something went wrong.

sergey-shandar approved these changes

View reviewed changes

sergey-shandar merged commit 788f8f8 into Azure:master

leniatgh pushed a commit that referenced this pull request


          [Hub Generated] Review request for Microsoft.CostManagement to add ve…

d2b168e

…rsion stable/2020-06-01 (#9982)

* Adds base for updating Microsoft.CostManagement from version stable/2019-11-01 to version 2020-06-01

* Updates readme

* Updates API version in new specs and examples

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Placed "code" and "message" inside an "error" object so it conforms to the standard error structure (line #3217)

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request


          [Hub Generated] Review request for Microsoft.CostManagement to add ve…

6a80962

…rsion stable/2020-06-01 (Azure#9982)

* Adds base for updating Microsoft.CostManagement from version stable/2019-11-01 to version 2020-06-01

* Updates readme

* Updates API version in new specs and examples

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Latest

* Placed "code" and "message" inside an "error" object so it conforms to the standard error structure (line Azure#3217)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sergey-shandar sergey-shandar approved these changes

Assignees

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.