Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge C# feature branch into main Azure.AI.Inference branch #31869

Draft
wants to merge 65 commits into
base: dargilco/ai-model-inference
Choose a base branch
from
Draft

Merge C# feature branch into main Azure.AI.Inference branch #31869

wants to merge 65 commits into from

Conversation

trangevi
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

trangevi added 30 commits May 31, 2024 15:08
@trangevi
Update ImageEmbeddingsClient to change embed to embedImage
51fb73b 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Add typespec-csharp to the tspconfig
fd54bf9 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Merge remote-tracking branch 'upstream/dargilco/ai-model-inference' i…
c53ca69 
…nto trangevi/ai-model-inference
@trangevi
Move csharp client property renames
08c7c64 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Missing semicolons
ab6c309 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Wrong namespace
4f8a7ea 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Incorrect namespaces
be84fda 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Aliases need to have things referenced differently, apparently
4f56fb3 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Need to specify parameters?
db6580b 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Move alias renames to the individual file for now
a5b3fbc 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Merge branch 'dargilco/ai-model-inference' into trangevi/ai-model-inf…
234a992 
…erence
@trangevi
Change ChatCompletionsOptions to a model
1c552f3 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
syntax
8e420b9 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Merge branch 'dargilco/ai-model-inference' into trangevi/ai-model-inf…
420cdf6 
…erence
@trangevi
Leave the model property
8c122c5 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Add additional properties for ChatCompletionsOptions
e6e24a1 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
3 dots, not 2
c33085f 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Can't add docstring to generic spread property
bc2ead4 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Change unknown parameters to extra parameters
cea8c46 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Merge branch 'dargilco/ai-model-inference' into trangevi/ai-model-inf…
e5f72fe 
…erence
@trangevi
Remove unnecessary rename
69c429f 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Removing api-key change for python, for now
9353cd8 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Merge branch 'main' into trangevi/ai-model-inference
404726c
@trangevi
Merge branch 'dargilco/ai-model-inference' into trangevi/ai-model-inf…
440f104 
…erence
@trangevi
Make operator method internal
acd2c9a 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Fix pass-through header
7e90c46 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Re-enable protocol methods for csharp
6525a08 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Remove "spread" for ChatCompletionsOptions
c625ccb 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Remove spread for additionalRequestHeaders
b3ff7cf 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
needed commas
3cad35a 
Signed-off-by: Travis Angevine <[email protected]>
trangevi added 25 commits July 29, 2024 14:09
@trangevi
Maybe needs to be an object?
7254471 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Add using
d752df6 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Revert to "good" state
4039eb1 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Merge branch 'dargilco/ai-model-inference' into trangevi/ai-model-inf…
33fb66c 
…erence
@trangevi
Merge branch 'dargilco/ai-model-inference' into trangevi/ai-model-inf…
d2d069e 
…erence
@trangevi
Try moving extra parameters. Change Parameters back to unknown
7b1e6e1 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Skip the alias
65239b3 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Is it the header which is causing issues?
323366c 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Headers in the options object seems to not work
1562993 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Remove commented operation
bd9d308 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Unnecessary using
7e3d4fd 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Merge branch 'dargilco/ai-model-inference' into trangevi/ai-model-inf…
9b2fbf0 
…erence
@trangevi
Add embeddings for csharp
376a388 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Merge branch 'dargilco/ai-model-inference' into trangevi/ai-model-inf…
b2d19d3 
…erence
@trangevi
Client changes for C#
56e81a8 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Need the options objects to be models
b1d22e9 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Make the embedding methods public for now, for intial testing
fb263d7 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Remove image embedding for now until it can be tested
2ef0546 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Add new streaming classes for C#
aa97e50 
Signed-off-by: Travis Angevine <[email protected]>
@trangevi
Merge branch 'dargilco/ai-model-inference' into trangevi/ai-model-inf…
96219f2 
…erence
@trangevi
Revert to Darren's branch to test
331fcb3 
Signed-off-by: trangevi <[email protected]>
@trangevi
Explicitly set the completions options object to be an input
3e5944b 
Signed-off-by: trangevi <[email protected]>
@trangevi
Other clients with spread parameters
8592ffc 
Signed-off-by: trangevi <[email protected]>
@trangevi
No image embedding client yet, so leave this out for now
844519f 
Signed-off-by: trangevi <[email protected]>
@trangevi
Operations need to be internal for all languages
19827a6 
Signed-off-by: trangevi <[email protected]>
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 13, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 13, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
.Net Azure.AI.Inference https://apiview.dev/Assemblies/Review/52190bf4171e4164a9eec8f5f51d137d?revisionId=a84b53a96cc6425bb50ec15d3e64f66a
Python azure-ai-inference https://apiview.dev/Assemblies/Review/f8a25f6729184c57a3853b51330b21da?revisionId=6acd6075b5ce472391f28bb2b7951fa9
TypeSpec ModelClient https://apiview.dev/Assemblies/Review/aa230d385fde45d69086ce67b31b9f48?revisionId=7d532d8d96d24c6ca90fc77185520773

@AzureRestAPISpecReview AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Dec 13, 2024
This was referenced Dec 13, 2024
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trangevi @AzureRestAPISpecReview