Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating documentation #3184

Merged
merged 7 commits into from
Jun 7, 2018
Merged

Updating documentation #3184

merged 7 commits into from
Jun 7, 2018

Conversation

mozehgir
Copy link
Contributor

@mozehgir mozehgir commented Jun 5, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci azuresdkci requested a review from annatisch June 5, 2018 21:16
@AutorestCI
Copy link

AutorestCI commented Jun 5, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@annatisch
Copy link
Member

@sarangan12 - this looks fine to me - is this waiting on any other external review?

@AutorestCI
Copy link

AutorestCI commented Jun 5, 2018 •
edited
Loading

Automation for azure-libraries-for-java

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

@mozehgir
Copy link
Contributor Author

mozehgir commented Jun 7, 2018

@annatisch - I don't think there is any other external review required. I have made some small changes to documentation here.

@annatisch annatisch merged commit e02b768 into Azure:master Jun 7, 2018
@bsiegel bsiegel removed the review label Jun 7, 2018
weidongxu-microsoft pushed a commit to weidongxu-microsoft/azure-rest-api-specs that referenced this pull request Jan 31, 2024
@JackTn
Merge pull request Azure#3184 from test-repo-billy/JackTn-patch-3
1604ba1 
Update azure-sdk-config.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annatisch annatisch annatisch approved these changes

Assignees

@annatisch annatisch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mozehgir @AutorestCI @annatisch @bsiegel @sarangan12