[correctness] updated operation type in Storage container to correct payload

[hiaga]

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

[openapi-pipeline-app]

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

[openapi-pipeline-app]

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup	https://apiview.dev/Assemblies/Review/8ee3943590cb4c18931e787bb8f8b817?revisionId=f2377995c04442a1b81c760ba49861d5
JavaScript	@azure/arm-recoveryservicesbackup	https://apiview.dev/Assemblies/Review/859c2af295154fe6816f57a966fd8dee?revisionId=51c54e8dd2264d4db9f135de144b1405
Java	azure-resourcemanager-recoveryservicesbackup	https://apiview.dev/Assemblies/Review/a4a183e5963645238761f94a38ed47e9?revisionId=e5ff54d5f356416697a602883a0f6caa
.Net	Azure.ResourceManager.RecoveryServicesBackup	https://apiview.dev/Assemblies/Review/2e670a3b8b294fadbf4a793f6c6aaa28?revisionId=587f4b2c30634473840e0ab2dde48a7e
Python	azure-mgmt-recoveryservicesbackup	https://apiview.dev/Assemblies/Review/0a14b8362f694541b56cb19ab03710bd?revisionId=6bd1bd7680bb451391e5cccd95482736

[azure-sdk]

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.RecoveryServices

[viveksheelsingh]

Since there is no svc behaviour chnage, and breaking chnage board has approved, approving.

[mikekistler]

@mikeharder Pls have a look at this PR. I think it should have been labeled VersioningReviewRequired since only compatible changes were made and with no API version change, but the bot labelled it BreakingChangeReviewRequired. There were no issues flagged by the BreakingChanges (Cross Version) PR check.

[mikeharder]

@mikeharder Pls have a look at this PR. I think it should have been labeled VersioningReviewRequired since only compatible changes were made and with no API version change, but the bot labelled it BreakingChangeReviewRequired. There were no issues flagged by the BreakingChanges (Cross Version) PR check.

Check BreakingChanges (Cross Version) passed, but check Swagger BreakingChanges failed. Given this, do you still think this PR should not have been lableled BreakingChangeReviewRequired?

I believe the current behavior matches the documentation. See the second bullet point here:

https://eng.ms/docs/products/azure-developer-experience/design/specs-pr-guides/pr-brch-deep#breakingchangereviewrequired-label

[mikekistler]

In the doc you linked it says:

The label VersioningReviewRequired denotes that your PR has a versioning issue possibly violating the Azure Versioning and Breaking Changes Policy. This happens when you made a non-breaking change, aka compatible change to an API version that was already published (merged to a production branch).

The issues flagged in the Swagger BreakingChanges check -- added enum values and added optional property -- would be perfectly fine if done in a new api-version. They are flagged only because they were made in an existing api-version. So I do think that VersioningReviewRequired is the correct label.

[hiaga]

Hi @mikeharder, @mikekistler could you please help find conclusion to above discussion. We're currently blocked on this PR for some PowerShell changes